* [PATCH] ALSA: xen-front: fix a loop timeout
@ 2018-05-31 6:25 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2018-05-31 6:25 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai
We want the loop to exit when "to" is set to zero, but in the current
code it's set to -1. Also I tweaked the indenting so it doesn't look
like we're passing "--to" to xenbus_read_unsigned().
Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index c18973a9bc9b..b089b13b5160 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
*/
while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
XenbusStateUnknown) != XenbusStateInitWait) &&
- to--)
+ --to)
msleep(10);
if (!to) {
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ALSA: xen-front: fix a loop timeout
@ 2018-05-31 6:25 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2018-05-31 6:25 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai
We want the loop to exit when "to" is set to zero, but in the current
code it's set to -1. Also I tweaked the indenting so it doesn't look
like we're passing "--to" to xenbus_read_unsigned().
Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index c18973a9bc9b..b089b13b5160 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
*/
while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
XenbusStateUnknown) != XenbusStateInitWait) &&
- to--)
+ --to)
msleep(10);
if (!to) {
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
2018-05-31 6:25 ` Dan Carpenter
@ 2018-05-31 6:44 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31 6:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai
On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> We want the loop to exit when "to" is set to zero, but in the current
> code it's set to -1. Also I tweaked the indenting so it doesn't look
> like we're passing "--to" to xenbus_read_unsigned().
>
> Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index c18973a9bc9b..b089b13b5160 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> */
> while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> XenbusStateUnknown) != XenbusStateInitWait) &&
> - to--)
> + --to)
> msleep(10);
>
> if (!to) {
Thank you for your patch,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
@ 2018-05-31 6:44 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31 6:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai
On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> We want the loop to exit when "to" is set to zero, but in the current
> code it's set to -1. Also I tweaked the indenting so it doesn't look
> like we're passing "--to" to xenbus_read_unsigned().
>
> Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index c18973a9bc9b..b089b13b5160 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> */
> while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> XenbusStateUnknown) != XenbusStateInitWait) &&
> - to--)
> + --to)
> msleep(10);
>
> if (!to) {
Thank you for your patch,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
2018-05-31 6:25 ` Dan Carpenter
(?)
(?)
@ 2018-05-31 6:44 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31 6:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai, Jaroslav Kysela
On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> We want the loop to exit when "to" is set to zero, but in the current
> code it's set to -1. Also I tweaked the indenting so it doesn't look
> like we're passing "--to" to xenbus_read_unsigned().
>
> Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index c18973a9bc9b..b089b13b5160 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> */
> while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> XenbusStateUnknown) != XenbusStateInitWait) &&
> - to--)
> + --to)
> msleep(10);
>
> if (!to) {
Thank you for your patch,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
2018-05-31 6:44 ` Oleksandr Andrushchenko
@ 2018-05-31 7:11 ` Takashi Iwai
-1 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-05-31 7:11 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Dan Carpenter
On Thu, 31 May 2018 08:44:39 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> > We want the loop to exit when "to" is set to zero, but in the current
> > code it's set to -1. Also I tweaked the indenting so it doesn't look
> > like we're passing "--to" to xenbus_read_unsigned().
> >
> > Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> > index c18973a9bc9b..b089b13b5160 100644
> > --- a/sound/xen/xen_snd_front.c
> > +++ b/sound/xen/xen_snd_front.c
> > @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> > */
> > while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> > XenbusStateUnknown) != XenbusStateInitWait) &&
> > - to--)
> > + --to)
> > msleep(10);
> > if (!to) {
> Thank you for your patch,
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
@ 2018-05-31 7:11 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-05-31 7:11 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Dan Carpenter
On Thu, 31 May 2018 08:44:39 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> > We want the loop to exit when "to" is set to zero, but in the current
> > code it's set to -1. Also I tweaked the indenting so it doesn't look
> > like we're passing "--to" to xenbus_read_unsigned().
> >
> > Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> > index c18973a9bc9b..b089b13b5160 100644
> > --- a/sound/xen/xen_snd_front.c
> > +++ b/sound/xen/xen_snd_front.c
> > @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> > */
> > while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> > XenbusStateUnknown) != XenbusStateInitWait) &&
> > - to--)
> > + --to)
> > msleep(10);
> > if (!to) {
> Thank you for your patch,
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: xen-front: fix a loop timeout
2018-05-31 6:44 ` Oleksandr Andrushchenko
(?)
(?)
@ 2018-05-31 7:11 ` Takashi Iwai
-1 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-05-31 7:11 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Dan Carpenter, Jaroslav Kysela
On Thu, 31 May 2018 08:44:39 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> > We want the loop to exit when "to" is set to zero, but in the current
> > code it's set to -1. Also I tweaked the indenting so it doesn't look
> > like we're passing "--to" to xenbus_read_unsigned().
> >
> > Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> > index c18973a9bc9b..b089b13b5160 100644
> > --- a/sound/xen/xen_snd_front.c
> > +++ b/sound/xen/xen_snd_front.c
> > @@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
> > */
> > while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
> > XenbusStateUnknown) != XenbusStateInitWait) &&
> > - to--)
> > + --to)
> > msleep(10);
> > if (!to) {
> Thank you for your patch,
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Applied, thanks.
Takashi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ALSA: xen-front: fix a loop timeout
@ 2018-05-31 6:25 Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2018-05-31 6:25 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai, Jaroslav Kysela
We want the loop to exit when "to" is set to zero, but in the current
code it's set to -1. Also I tweaked the indenting so it doesn't look
like we're passing "--to" to xenbus_read_unsigned().
Fixes: cc3196ae197c ("ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index c18973a9bc9b..b089b13b5160 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -334,7 +334,7 @@ static int xen_drv_remove(struct xenbus_device *dev)
*/
while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state",
XenbusStateUnknown) != XenbusStateInitWait) &&
- to--)
+ --to)
msleep(10);
if (!to) {
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-05-31 7:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31 6:25 [PATCH] ALSA: xen-front: fix a loop timeout Dan Carpenter
2018-05-31 6:25 ` Dan Carpenter
2018-05-31 6:44 ` Oleksandr Andrushchenko
2018-05-31 6:44 ` Oleksandr Andrushchenko
2018-05-31 7:11 ` Takashi Iwai
2018-05-31 7:11 ` Takashi Iwai
2018-05-31 7:11 ` Takashi Iwai
2018-05-31 6:44 ` Oleksandr Andrushchenko
2018-05-31 6:25 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.