All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	shuah@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/4] selftest/vm: verify mmap addr in mremap_test
Date: Thu, 21 Apr 2022 13:31:32 -0600	[thread overview]
Message-ID: <ff3db00d-3e18-8168-9f7d-d91a5591c7f2@linuxfoundation.org> (raw)
In-Reply-To: <20220420215721.4868-1-sidhartha.kumar@oracle.com>

On 4/20/22 3:57 PM, Sidhartha Kumar wrote:
> Avoid calling mmap with requested addresses that are less than the system's
> mmap_min_addr. When run as root, mmap returns EACCES when trying to map
> addresses < mmap_min_addr. This is not one of the error codes for the
> condition to retry the mmap in the test. Rather than arbitrarily retrying
> on EACCES, don't attempt an mmap until addr > vm.mmap_min_addr.
> 
> Add a munmap call after an alignment check as the mappings are retained
> after the retry and can reach the vm.max_map_count sysctl.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> v2:
> -change comment for description of get_mmap_min_addr()
> -fix commit message formatting
> 

Thank you.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

Andrew, please let me know if you would like me to take this
through kselftest tree.

thanks,
-- Shuah

      parent reply	other threads:[~2022-04-21 19:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 21:57 [PATCH v2 1/4] selftest/vm: verify mmap addr in mremap_test Sidhartha Kumar
2022-04-20 21:57 ` [PATCH v2 2/4] selftest/vm: verify remap destination address " Sidhartha Kumar
2022-04-21 19:31   ` Shuah Khan
2022-04-21 20:03     ` Andrew Morton
2022-04-20 21:57 ` [PATCH v2 3/4] selftest/vm: support xfail " Sidhartha Kumar
2022-04-20 21:57 ` [PATCH v2 4/4] selftest/vm: add skip support to mremap_test Sidhartha Kumar
2022-04-21 19:31 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff3db00d-3e18-8168-9f7d-d91a5591c7f2@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    --cc=sidhartha.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.