From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH 35/38] net/dpaa: add support for packet type parsing Date: Tue, 4 Jul 2017 17:41:48 +0530 Message-ID: References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com> <643705f9-1bc9-67bc-6339-e7902c65c3ba@intel.com> <3187fd31-6086-f3f8-d473-f6d059e269de@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , To: Ferruh Yigit Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0069.outbound.protection.outlook.com [104.47.41.69]) by dpdk.org (Postfix) with ESMTP id 0148E271 for ; Tue, 4 Jul 2017 14:02:43 +0200 (CEST) In-Reply-To: <3187fd31-6086-f3f8-d473-f6d059e269de@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Friday 30 June 2017 05:10 PM, Shreyansh Jain wrote: > On Wednesday 28 June 2017 09:20 PM, Ferruh Yigit wrote: >> On 6/16/2017 6:41 AM, Shreyansh Jain wrote: >>> Signed-off-by: Hemant Agrawal >>> Signed-off-by: Shreyansh Jain >> [...] >> >>> + >>> + m->tx_offload = annot->parse.ip_off[0]; >>> + m->tx_offload |= (annot->parse.l4_off - annot->parse.ip_off[0]) >>> + << DPAA_PKT_L3_LEN_SHIFT; >> >> This is a received mbuf right? Is it required to set tx_offload flag? >> [...] I had not replied to this in my previous response. DPAA hardware fills parsed information into the annotation (annot) area. When a packet is Rx'd, it would contain information about where the IP offset field it. Once we read the packet, the 'annot' area is overwritten in subsequent cycles. This packet received may be forwarded, in which case, this information (preserved in m->tx_offload) would be useful for optimized performance. Indeed, this is one of the cases, but at least some optimization is achieved using this. - Shreyansh