From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6MaF-0008Tc-Tq for qemu-devel@nongnu.org; Mon, 14 Nov 2016 14:06:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6MaB-0002xh-Uh for qemu-devel@nongnu.org; Mon, 14 Nov 2016 14:06:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48296) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6MaB-0002xU-Nd for qemu-devel@nongnu.org; Mon, 14 Nov 2016 14:06:19 -0500 References: <1478566785-4002-1-git-send-email-ashish.mittal@veritas.com> <1478566785-4002-2-git-send-email-ashish.mittal@veritas.com> <20161114150701.GD26198@stefanha-x1.localdomain> <20161114154906.GC2373@lemon> <20161114165034.GA1352@stefanha-x1.localdomain> <20161114180359.GA24217@lemon> From: Eric Blake Message-ID: Date: Mon, 14 Nov 2016 13:06:16 -0600 MIME-Version: 1.0 In-Reply-To: <20161114180359.GA24217@lemon> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Qq16TsUOq4FhARbtKPuWU3IsDhbKgH4j" Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , Stefan Hajnoczi Cc: kwolf@redhat.com, Venkatesha.Mg@veritas.com, ashish.mittal@veritas.com, jcody@redhat.com, qemu-devel@nongnu.org, Rakesh.Ranjan@veritas.com, armbru@redhat.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, pbonzini@redhat.com, Buddhi.Madhav@veritas.com, Ashish Mittal This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3Qq16TsUOq4FhARbtKPuWU3IsDhbKgH4j From: Eric Blake To: Fam Zheng , Stefan Hajnoczi Cc: kwolf@redhat.com, Venkatesha.Mg@veritas.com, ashish.mittal@veritas.com, jcody@redhat.com, qemu-devel@nongnu.org, Rakesh.Ranjan@veritas.com, armbru@redhat.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, pbonzini@redhat.com, Buddhi.Madhav@veritas.com, Ashish Mittal Message-ID: Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" References: <1478566785-4002-1-git-send-email-ashish.mittal@veritas.com> <1478566785-4002-2-git-send-email-ashish.mittal@veritas.com> <20161114150701.GD26198@stefanha-x1.localdomain> <20161114154906.GC2373@lemon> <20161114165034.GA1352@stefanha-x1.localdomain> <20161114180359.GA24217@lemon> In-Reply-To: <20161114180359.GA24217@lemon> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/14/2016 12:03 PM, Fam Zheng wrote: >>>> Please move system headers (<>) above user headers (""). This way y= ou >>>> can be sure the system header isn't affected by any macros defined b= y >>>> user headers. >>> >>> Yes, but still after "qemu/osdep.h", which prepares necessary bits fo= r any other >>> headers. >> >> I disagree. qnio_api.h is a third-party library that doesn't need QEM= U >> headers to fix up the environment for it. >> >> By including osdep.h first you mask bugs in qnio_api.h. Perhaps >> qnio_api.h forgot to include a header and we won't notice because >> osdep.h happened to bring in those headers first... >> >> Can you explain the rationale for your statement? >=20 > I point this out just because I rememebr this effort happened not long = ago, > which is to make osdep.h always included first (there is also a > ./scripts/clean-includes to reorder the include): >=20 > https://lists.nongnu.org/archive/html/qemu-devel/2015-12/msg01110.html >=20 > I think it is mostly for uncommon compilers that should have little to = do with > libqnio in particular, but this is a common practice of current QEMU. If the file is copied in verbatim from a third-party source, then it should not be including osdep.h, and should be added to the list of exempt files in scripts/clean-includes - at which point the file SHOULD be clean because it should already be usable as-is in its third-party original location. If we modify the file as part of including it in qemu, then qemu rules apply and having osdep.h first is good practice. So I guess you have to determine if libqnio is something that should compile completely independent from qemu, or whether it is so closely tied to the rest of qemu that it should follow qemu conventions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3Qq16TsUOq4FhARbtKPuWU3IsDhbKgH4j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYKgsoAAoJEKeha0olJ0Nq42cIAJ2NECUQ8xKm7Gk/7vE8fm0N 2qZ+JImfIZpdW0dS9nSyln/4EdwhRjrBJeBjK561XqH8Q2mpsqli5wpbIy+1gXMj OJNUZDlIVuyg/li1Sf7sUZ85lVwXySiDHSPyEd+fk1zbg7ydHP1mBAmr8aEQL8fA VdOvL3NlDqZIuZQ7k293+Cil0mTu7jPciBwWzdL9wd34N2T4GPobNvO+ekZQpYKJ 9bG+YjrNqdfZnElTUnSmxqrUxqdWr0K+OnhCnDLyfe/9WREFjKXeYbThB+61iiXX 6Hbpn0BuoDNwoSuCOibnjRDLZxmSmHGL5zOEF+HgOpVgcJkzV8038kcbhbRhGno= =b6Zb -----END PGP SIGNATURE----- --3Qq16TsUOq4FhARbtKPuWU3IsDhbKgH4j--