From: Andrzej Hajda <a.hajda@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Pitre <nico@fluxnic.net>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Leon Romanovsky <leon@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
netdev@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com>,
Saeed Mahameed <saeedm@mellanox.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
"David S. Miller" <davem@davemloft.net>,
linux-rdma@vger.kernel.org
Subject: Re: [RFC 4/6] drm/bridge/sii8620: fix extcon dependency
Date: Fri, 10 Apr 2020 08:56:28 +0200 [thread overview]
Message-ID: <ff7809b6-f566-9c93-1838-610be5d22431@samsung.com> (raw)
In-Reply-To: <20200408202711.1198966-5-arnd@arndb.de>
On 08.04.2020 22:27, Arnd Bergmann wrote:
> Using 'imply' does not work here, it still cause the same build
> failure:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_remove':
> sil-sii8620.c:(.text+0x1b8): undefined reference to `extcon_unregister_notifier'
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_probe':
> sil-sii8620.c:(.text+0x27e8): undefined reference to `extcon_find_edev_by_node'
> arm-linux-gnueabi-ld: sil-sii8620.c:(.text+0x2870): undefined reference to `extcon_register_notifier'
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_extcon_work':
> sil-sii8620.c:(.text+0x2908): undefined reference to `extcon_get_state'
>
> I tried the usual 'depends on EXTCON || !EXTCON' logic, but that caused
> a circular Kconfig dependency. Using IS_REACHABLE() is ugly but works.
'depends on EXTCON || !EXTCON' seems to be proper solution, maybe would be better to try to solve circular dependencies issue.
Regards
Andrzej
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Pitre <nico@fluxnic.net>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Leon Romanovsky <leon@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
netdev@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Saeed Mahameed <saeedm@mellanox.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
"David S. Miller" <davem@davemloft.net>,
linux-rdma@vger.kernel.org
Subject: Re: [RFC 4/6] drm/bridge/sii8620: fix extcon dependency
Date: Fri, 10 Apr 2020 08:56:28 +0200 [thread overview]
Message-ID: <ff7809b6-f566-9c93-1838-610be5d22431@samsung.com> (raw)
In-Reply-To: <20200408202711.1198966-5-arnd@arndb.de>
On 08.04.2020 22:27, Arnd Bergmann wrote:
> Using 'imply' does not work here, it still cause the same build
> failure:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_remove':
> sil-sii8620.c:(.text+0x1b8): undefined reference to `extcon_unregister_notifier'
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_probe':
> sil-sii8620.c:(.text+0x27e8): undefined reference to `extcon_find_edev_by_node'
> arm-linux-gnueabi-ld: sil-sii8620.c:(.text+0x2870): undefined reference to `extcon_register_notifier'
> arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/sil-sii8620.o: in function `sii8620_extcon_work':
> sil-sii8620.c:(.text+0x2908): undefined reference to `extcon_get_state'
>
> I tried the usual 'depends on EXTCON || !EXTCON' logic, but that caused
> a circular Kconfig dependency. Using IS_REACHABLE() is ugly but works.
'depends on EXTCON || !EXTCON' seems to be proper solution, maybe would be better to try to solve circular dependencies issue.
Regards
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-10 6:56 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 20:27 [RFC 0/6] Regressions for "imply" behavior change Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 1/6] thunder: select PTP driver if possible Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 2/6] net/mlx5e: fix VXLAN dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 3/6] LiquidIO VF: add dependency for PTP_1588_CLOCK Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 21:10 ` kbuild test robot
2020-04-08 21:13 ` Arnd Bergmann
2020-04-08 20:27 ` [RFC 4/6] drm/bridge/sii8620: fix extcon dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-10 6:56 ` Andrzej Hajda [this message]
2020-04-10 6:56 ` Andrzej Hajda
2020-04-14 15:04 ` Arnd Bergmann
2020-04-14 15:04 ` Arnd Bergmann
2020-04-14 15:37 ` Daniel Vetter
2020-04-14 15:37 ` Daniel Vetter
2020-04-15 6:58 ` Jani Nikula
2020-04-15 6:58 ` Jani Nikula
2020-04-08 20:27 ` [RFC 5/6] drm/rcar-du: fix selection of CMM driver Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-14 20:17 ` Laurent Pinchart
2020-04-14 20:17 ` Laurent Pinchart
2020-04-14 20:38 ` Arnd Bergmann
2020-04-14 20:38 ` Arnd Bergmann
2020-04-14 20:51 ` Laurent Pinchart
2020-04-14 20:51 ` Laurent Pinchart
2020-04-14 21:10 ` Arnd Bergmann
2020-04-14 21:10 ` Arnd Bergmann
2020-04-15 14:13 ` Geert Uytterhoeven
2020-04-15 14:13 ` Geert Uytterhoeven
2020-04-15 15:18 ` Arnd Bergmann
2020-04-15 15:18 ` Arnd Bergmann
2020-04-15 19:07 ` Arnd Bergmann
2020-04-15 19:07 ` Arnd Bergmann
2020-04-15 21:12 ` Laurent Pinchart
2020-04-15 21:12 ` Laurent Pinchart
2020-04-15 21:22 ` Arnd Bergmann
2020-04-15 21:22 ` Arnd Bergmann
2020-04-16 6:51 ` Daniel Vetter
2020-04-16 6:51 ` Daniel Vetter
2020-04-16 15:17 ` Laurent Pinchart
2020-04-16 15:17 ` Laurent Pinchart
2020-04-08 20:27 ` [RFC 6/6] drm/rcar-du: fix lvds dependency Arnd Bergmann
2020-04-08 20:27 ` Arnd Bergmann
2020-04-08 20:38 ` [RFC 0/6] Regressions for "imply" behavior change Nicolas Pitre
2020-04-08 20:38 ` Nicolas Pitre
2020-04-08 20:46 ` Saeed Mahameed
2020-04-08 20:46 ` Saeed Mahameed
2020-04-08 20:49 ` Arnd Bergmann
2020-04-08 20:49 ` Arnd Bergmann
2020-04-08 21:17 ` Nicolas Pitre
2020-04-08 21:17 ` Nicolas Pitre
2020-04-08 22:42 ` Jason Gunthorpe
2020-04-08 22:42 ` Jason Gunthorpe
2020-04-09 8:41 ` Jani Nikula
2020-04-09 8:41 ` Jani Nikula
2020-04-10 2:40 ` Saeed Mahameed
2020-04-10 2:40 ` Saeed Mahameed
2020-04-10 7:26 ` Geert Uytterhoeven
2020-04-10 7:26 ` Geert Uytterhoeven
2020-04-10 17:13 ` Jason Gunthorpe
2020-04-10 17:13 ` Jason Gunthorpe
2020-04-10 19:04 ` Saeed Mahameed
2020-04-10 19:04 ` Saeed Mahameed
2020-04-14 13:29 ` Jason Gunthorpe
2020-04-14 13:29 ` Jason Gunthorpe
2020-04-14 14:27 ` Arnd Bergmann
2020-04-14 14:27 ` Arnd Bergmann
2020-04-14 15:23 ` Jason Gunthorpe
2020-04-14 15:23 ` Jason Gunthorpe
2020-04-14 15:25 ` Arnd Bergmann
2020-04-14 15:25 ` Arnd Bergmann
2020-04-14 17:49 ` Saeed Mahameed
2020-04-14 17:49 ` Saeed Mahameed
2020-04-14 18:47 ` Arnd Bergmann
2020-04-14 18:47 ` Arnd Bergmann
2020-04-16 3:25 ` Saeed Mahameed
2020-04-16 3:25 ` Saeed Mahameed
2020-04-16 7:20 ` Arnd Bergmann
2020-04-16 7:20 ` Arnd Bergmann
2020-04-16 10:17 ` Jani Nikula
2020-04-16 10:17 ` Jani Nikula
2020-04-16 12:38 ` Arnd Bergmann
2020-04-16 12:38 ` Arnd Bergmann
2020-04-16 14:52 ` Jason Gunthorpe
2020-04-16 14:52 ` Jason Gunthorpe
2020-04-16 15:58 ` Arnd Bergmann
2020-04-16 15:58 ` Arnd Bergmann
2020-04-16 18:05 ` Jason Gunthorpe
2020-04-16 18:05 ` Jason Gunthorpe
2020-04-16 18:38 ` Saeed Mahameed
2020-04-16 18:38 ` Saeed Mahameed
2020-04-16 15:12 ` Nicolas Pitre
2020-04-16 15:12 ` Nicolas Pitre
2020-04-16 18:21 ` Jason Gunthorpe
2020-04-16 18:21 ` Jason Gunthorpe
2020-04-16 19:56 ` Andrzej Hajda
2020-04-16 19:56 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7809b6-f566-9c93-1838-610be5d22431@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.