From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2895C433F5 for ; Wed, 25 May 2022 06:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244120AbiEYGUk (ORCPT ); Wed, 25 May 2022 02:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242007AbiEYGUh (ORCPT ); Wed, 25 May 2022 02:20:37 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C55E6EC49 for ; Tue, 24 May 2022 23:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653459636; x=1684995636; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=vJJ4lj6JSngeRrcXNnkqhrxyjqnmsKVzIMYvdkGbUx8=; b=DPQvWmtdPZ9UFPpk1+SjbFWrWyGHWkG9ZIZfZyemnYAaFkJxmjSIlOL7 RCpKODaPv3pXdv+eZnYoaLc1gmcCNDCgd2wmqmP5JpbXIVEdKS0fkl248 xdMqCt9RCPM9x06SOZ1F3vf13IMLDafFWVjwfYRfruR0z0YP+a62znEn+ ldN1oyjoN6S+rMU3xO28pVlF705Oh1ERoDB8ZpplG5uZD38upVkA8Tw+F mPNdYJhcRj+Z8EMbAMazZHf4d0z1snWcnktgsDWTMWA7+p05q1LGY+am9 djDyhLPpmCGKhQ1/inUVTW4jKSoivDiMUNlgPPK9zd4g4VRPkdCbzfS6s Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="271303823" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="271303823" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:20:36 -0700 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="601681830" Received: from jwang96-mobl.ccr.corp.intel.com (HELO [10.255.29.139]) ([10.255.29.139]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:20:31 -0700 Message-ID: Date: Wed, 25 May 2022 14:20:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: baolu.lu@linux.intel.com, Jean-Philippe Brucker , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jacob jun Pan Subject: Re: [PATCH v7 03/10] iommu/sva: Add iommu_sva_domain support Content-Language: en-US To: Robin Murphy , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Kevin Tian , Ashok Raj , Will Deacon , Jean-Philippe Brucker , Dave Jiang , Vinod Koul References: <20220519072047.2996983-1-baolu.lu@linux.intel.com> <20220519072047.2996983-4-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 2022/5/24 22:36, Robin Murphy wrote: > On 2022-05-19 08:20, Lu Baolu wrote: > [...] >> diff --git a/drivers/iommu/iommu-sva-lib.c >> b/drivers/iommu/iommu-sva-lib.c >> index 106506143896..210c376f6043 100644 >> --- a/drivers/iommu/iommu-sva-lib.c >> +++ b/drivers/iommu/iommu-sva-lib.c >> @@ -69,3 +69,51 @@ struct mm_struct *iommu_sva_find(ioasid_t pasid) >>       return ioasid_find(&iommu_sva_pasid, pasid, __mmget_not_zero); >>   } >>   EXPORT_SYMBOL_GPL(iommu_sva_find); >> + >> +/* >> + * IOMMU SVA driver-oriented interfaces >> + */ >> +struct iommu_domain * >> +iommu_sva_alloc_domain(struct bus_type *bus, struct mm_struct *mm) > > Argh, please no new bus-based external interfaces! Domain allocation > needs to resolve to the right IOMMU instance to solve a number of > issues, and cleaning up existing users of iommu_domain_alloc() to > prepare for that is already hard enough. This is arguably even more > relevant here than for other domain types, since SVA support is more > likely to depend on specific features that can vary between IOMMU > instances even with the same driver. Please make the external interface > take a struct device, then resolve the ops through dev->iommu. > > Further nit: the naming inconsistency bugs me a bit - > iommu_sva_domain_alloc() seems more natural. Also I'd question the > symmetry vs. usability dichotomy of whether we *really* want two > different free functions for a struct iommu_domain pointer, where any > caller which might mix SVA and non-SVA usage then has to remember how > they allocated any particular domain :/ > >> +{ >> +    struct iommu_sva_domain *sva_domain; >> +    struct iommu_domain *domain; >> + >> +    if (!bus->iommu_ops || !bus->iommu_ops->sva_domain_ops) >> +        return ERR_PTR(-ENODEV); >> + >> +    sva_domain = kzalloc(sizeof(*sva_domain), GFP_KERNEL); >> +    if (!sva_domain) >> +        return ERR_PTR(-ENOMEM); >> + >> +    mmgrab(mm); >> +    sva_domain->mm = mm; >> + >> +    domain = &sva_domain->domain; >> +    domain->type = IOMMU_DOMAIN_SVA; >> +    domain->ops = bus->iommu_ops->sva_domain_ops; > > I'd have thought it would be logical to pass IOMMU_DOMAIN_SVA to the > normal domain_alloc call, so that driver-internal stuff like context > descriptors can be still be hung off the domain as usual (rather than > all drivers having to implement some extra internal lookup mechanism to > handle all the SVA domain ops), but that's something we're free to come Agreed with above comments. Thanks! I will post an additional patch for review later. > back and change later. FWIW I'd just stick the mm pointer in struct > iommu_domain, in a union with the fault handler stuff and/or iova_cookie > - those are mutually exclusive with SVA, right? "iova_cookie" is mutually exclusive with SVA, but I am not sure about the fault handler stuff. Did you mean @handler and @handler_token staffs below? struct iommu_domain { unsigned type; const struct iommu_domain_ops *ops; unsigned long pgsize_bitmap; /* Bitmap of page sizes in use */ iommu_fault_handler_t handler; void *handler_token; struct iommu_domain_geometry geometry; struct iommu_dma_cookie *iova_cookie; }; Is it only for DMA domains? From the point view of IOMMU faults, it seems to be generic. Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D5A0C433EF for ; Wed, 25 May 2022 06:20:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 010B741BA4; Wed, 25 May 2022 06:20:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G_VE5DKqM1z2; Wed, 25 May 2022 06:20:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5B3A841B95; Wed, 25 May 2022 06:20:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C281C0032; Wed, 25 May 2022 06:20:40 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7811DC002D for ; Wed, 25 May 2022 06:20:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5F70A41BA2 for ; Wed, 25 May 2022 06:20:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFkQKx_n7UHM for ; Wed, 25 May 2022 06:20:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by smtp4.osuosl.org (Postfix) with ESMTPS id 306B141B99 for ; Wed, 25 May 2022 06:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653459638; x=1684995638; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=vJJ4lj6JSngeRrcXNnkqhrxyjqnmsKVzIMYvdkGbUx8=; b=ENkskoJmfwlX58zavNQTEI2j/jdLKWAOnJHTij/zCI/BQAlr11Yz+FP1 sxCMUzeV26S7vTGjVeFCEtV1MsHSHJDOuI+xSXOJjcdMGBMNZbwH0WmL3 v55foxSfZxDxXcp7rm08Bp+CT0Zw4wOXmXonDliz6T5v3Vwsy/qs85S2x xKdCWBTrSGXWHmm0wWSl7oycOLPr5mdc81X3aqJgkioCZ0acAPBh4n477 Tdn1ybAKQX8UIzekq7eQ+Y5ain08AIw8EV44Fo7OghQH0A1qzyXafiO8H huYRa3NGkiRs65gvemjDHKGyMh6sH37fMfWfNAYhsnn7Gv8NHyah7mIQ4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="299060032" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="299060032" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:20:36 -0700 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="601681830" Received: from jwang96-mobl.ccr.corp.intel.com (HELO [10.255.29.139]) ([10.255.29.139]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:20:31 -0700 Message-ID: Date: Wed, 25 May 2022 14:20:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v7 03/10] iommu/sva: Add iommu_sva_domain support Content-Language: en-US To: Robin Murphy , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Kevin Tian , Ashok Raj , Will Deacon , Jean-Philippe Brucker , Dave Jiang , Vinod Koul References: <20220519072047.2996983-1-baolu.lu@linux.intel.com> <20220519072047.2996983-4-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Cc: Jean-Philippe Brucker , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob jun Pan X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgUm9iaW4sCgpPbiAyMDIyLzUvMjQgMjI6MzYsIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAy MDIyLTA1LTE5IDA4OjIwLCBMdSBCYW9sdSB3cm90ZToKPiBbLi4uXQo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9pb21tdS9pb21tdS1zdmEtbGliLmMgCj4+IGIvZHJpdmVycy9pb21tdS9pb21tdS1z dmEtbGliLmMKPj4gaW5kZXggMTA2NTA2MTQzODk2Li4yMTBjMzc2ZjYwNDMgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvaW9tbXUvaW9tbXUtc3ZhLWxpYi5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUv aW9tbXUtc3ZhLWxpYi5jCj4+IEBAIC02OSwzICs2OSw1MSBAQCBzdHJ1Y3QgbW1fc3RydWN0ICpp b21tdV9zdmFfZmluZChpb2FzaWRfdCBwYXNpZCkKPj4gwqDCoMKgwqDCoCByZXR1cm4gaW9hc2lk X2ZpbmQoJmlvbW11X3N2YV9wYXNpZCwgcGFzaWQsIF9fbW1nZXRfbm90X3plcm8pOwo+PiDCoCB9 Cj4+IMKgIEVYUE9SVF9TWU1CT0xfR1BMKGlvbW11X3N2YV9maW5kKTsKPj4gKwo+PiArLyoKPj4g KyAqIElPTU1VIFNWQSBkcml2ZXItb3JpZW50ZWQgaW50ZXJmYWNlcwo+PiArICovCj4+ICtzdHJ1 Y3QgaW9tbXVfZG9tYWluICoKPj4gK2lvbW11X3N2YV9hbGxvY19kb21haW4oc3RydWN0IGJ1c190 eXBlICpidXMsIHN0cnVjdCBtbV9zdHJ1Y3QgKm1tKQo+IAo+IEFyZ2gsIHBsZWFzZSBubyBuZXcg YnVzLWJhc2VkIGV4dGVybmFsIGludGVyZmFjZXMhIERvbWFpbiBhbGxvY2F0aW9uIAo+IG5lZWRz IHRvIHJlc29sdmUgdG8gdGhlIHJpZ2h0IElPTU1VIGluc3RhbmNlIHRvIHNvbHZlIGEgbnVtYmVy IG9mIAo+IGlzc3VlcywgYW5kIGNsZWFuaW5nIHVwIGV4aXN0aW5nIHVzZXJzIG9mIGlvbW11X2Rv bWFpbl9hbGxvYygpIHRvIAo+IHByZXBhcmUgZm9yIHRoYXQgaXMgYWxyZWFkeSBoYXJkIGVub3Vn aC4gVGhpcyBpcyBhcmd1YWJseSBldmVuIG1vcmUgCj4gcmVsZXZhbnQgaGVyZSB0aGFuIGZvciBv dGhlciBkb21haW4gdHlwZXMsIHNpbmNlIFNWQSBzdXBwb3J0IGlzIG1vcmUgCj4gbGlrZWx5IHRv IGRlcGVuZCBvbiBzcGVjaWZpYyBmZWF0dXJlcyB0aGF0IGNhbiB2YXJ5IGJldHdlZW4gSU9NTVUg Cj4gaW5zdGFuY2VzIGV2ZW4gd2l0aCB0aGUgc2FtZSBkcml2ZXIuIFBsZWFzZSBtYWtlIHRoZSBl eHRlcm5hbCBpbnRlcmZhY2UgCj4gdGFrZSBhIHN0cnVjdCBkZXZpY2UsIHRoZW4gcmVzb2x2ZSB0 aGUgb3BzIHRocm91Z2ggZGV2LT5pb21tdS4KPiAKPiBGdXJ0aGVyIG5pdDogdGhlIG5hbWluZyBp bmNvbnNpc3RlbmN5IGJ1Z3MgbWUgYSBiaXQgLSAKPiBpb21tdV9zdmFfZG9tYWluX2FsbG9jKCkg c2VlbXMgbW9yZSBuYXR1cmFsLiBBbHNvIEknZCBxdWVzdGlvbiB0aGUgCj4gc3ltbWV0cnkgdnMu IHVzYWJpbGl0eSBkaWNob3RvbXkgb2Ygd2hldGhlciB3ZSAqcmVhbGx5KiB3YW50IHR3byAKPiBk aWZmZXJlbnQgZnJlZSBmdW5jdGlvbnMgZm9yIGEgc3RydWN0IGlvbW11X2RvbWFpbiBwb2ludGVy LCB3aGVyZSBhbnkgCj4gY2FsbGVyIHdoaWNoIG1pZ2h0IG1peCBTVkEgYW5kIG5vbi1TVkEgdXNh Z2UgdGhlbiBoYXMgdG8gcmVtZW1iZXIgaG93IAo+IHRoZXkgYWxsb2NhdGVkIGFueSBwYXJ0aWN1 bGFyIGRvbWFpbiA6Lwo+IAo+PiArewo+PiArwqDCoMKgIHN0cnVjdCBpb21tdV9zdmFfZG9tYWlu ICpzdmFfZG9tYWluOwo+PiArwqDCoMKgIHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbjsKPj4g Kwo+PiArwqDCoMKgIGlmICghYnVzLT5pb21tdV9vcHMgfHwgIWJ1cy0+aW9tbXVfb3BzLT5zdmFf ZG9tYWluX29wcykKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBFUlJfUFRSKC1FTk9ERVYpOwo+ PiArCj4+ICvCoMKgwqAgc3ZhX2RvbWFpbiA9IGt6YWxsb2Moc2l6ZW9mKCpzdmFfZG9tYWluKSwg R0ZQX0tFUk5FTCk7Cj4+ICvCoMKgwqAgaWYgKCFzdmFfZG9tYWluKQo+PiArwqDCoMKgwqDCoMKg wqAgcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+ICsKPj4gK8KgwqDCoCBtbWdyYWIobW0pOwo+ PiArwqDCoMKgIHN2YV9kb21haW4tPm1tID0gbW07Cj4+ICsKPj4gK8KgwqDCoCBkb21haW4gPSAm c3ZhX2RvbWFpbi0+ZG9tYWluOwo+PiArwqDCoMKgIGRvbWFpbi0+dHlwZSA9IElPTU1VX0RPTUFJ Tl9TVkE7Cj4+ICvCoMKgwqAgZG9tYWluLT5vcHMgPSBidXMtPmlvbW11X29wcy0+c3ZhX2RvbWFp bl9vcHM7Cj4gCj4gSSdkIGhhdmUgdGhvdWdodCBpdCB3b3VsZCBiZSBsb2dpY2FsIHRvIHBhc3Mg SU9NTVVfRE9NQUlOX1NWQSB0byB0aGUgCj4gbm9ybWFsIGRvbWFpbl9hbGxvYyBjYWxsLCBzbyB0 aGF0IGRyaXZlci1pbnRlcm5hbCBzdHVmZiBsaWtlIGNvbnRleHQgCj4gZGVzY3JpcHRvcnMgY2Fu IGJlIHN0aWxsIGJlIGh1bmcgb2ZmIHRoZSBkb21haW4gYXMgdXN1YWwgKHJhdGhlciB0aGFuIAo+ IGFsbCBkcml2ZXJzIGhhdmluZyB0byBpbXBsZW1lbnQgc29tZSBleHRyYSBpbnRlcm5hbCBsb29r dXAgbWVjaGFuaXNtIHRvIAo+IGhhbmRsZSBhbGwgdGhlIFNWQSBkb21haW4gb3BzKSwgYnV0IHRo YXQncyBzb21ldGhpbmcgd2UncmUgZnJlZSB0byBjb21lIAoKQWdyZWVkIHdpdGggYWJvdmUgY29t bWVudHMuIFRoYW5rcyEgSSB3aWxsIHBvc3QgYW4gYWRkaXRpb25hbCBwYXRjaApmb3IgcmV2aWV3 IGxhdGVyLgoKPiBiYWNrIGFuZCBjaGFuZ2UgbGF0ZXIuIEZXSVcgSSdkIGp1c3Qgc3RpY2sgdGhl IG1tIHBvaW50ZXIgaW4gc3RydWN0IAo+IGlvbW11X2RvbWFpbiwgaW4gYSB1bmlvbiB3aXRoIHRo ZSBmYXVsdCBoYW5kbGVyIHN0dWZmIGFuZC9vciBpb3ZhX2Nvb2tpZSAKPiAtIHRob3NlIGFyZSBt dXR1YWxseSBleGNsdXNpdmUgd2l0aCBTVkEsIHJpZ2h0PwoKImlvdmFfY29va2llIiBpcyBtdXR1 YWxseSBleGNsdXNpdmUgd2l0aCBTVkEsIGJ1dCBJIGFtIG5vdCBzdXJlIGFib3V0CnRoZSBmYXVs dCBoYW5kbGVyIHN0dWZmLgoKRGlkIHlvdSBtZWFuIEBoYW5kbGVyIGFuZCBAaGFuZGxlcl90b2tl biBzdGFmZnMgYmVsb3c/CgpzdHJ1Y3QgaW9tbXVfZG9tYWluIHsKICAgICAgICAgdW5zaWduZWQg dHlwZTsKICAgICAgICAgY29uc3Qgc3RydWN0IGlvbW11X2RvbWFpbl9vcHMgKm9wczsKICAgICAg ICAgdW5zaWduZWQgbG9uZyBwZ3NpemVfYml0bWFwOyAgICAvKiBCaXRtYXAgb2YgcGFnZSBzaXpl cyBpbiB1c2UgKi8KICAgICAgICAgaW9tbXVfZmF1bHRfaGFuZGxlcl90IGhhbmRsZXI7CiAgICAg ICAgIHZvaWQgKmhhbmRsZXJfdG9rZW47CiAgICAgICAgIHN0cnVjdCBpb21tdV9kb21haW5fZ2Vv bWV0cnkgZ2VvbWV0cnk7CiAgICAgICAgIHN0cnVjdCBpb21tdV9kbWFfY29va2llICppb3ZhX2Nv b2tpZTsKfTsKCklzIGl0IG9ubHkgZm9yIERNQSBkb21haW5zPyBGcm9tIHRoZSBwb2ludCB2aWV3 IG9mIElPTU1VIGZhdWx0cywgaXQKc2VlbXMgdG8gYmUgZ2VuZXJpYy4KCkJlc3QgcmVnYXJkcywK YmFvbHUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9t bXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8v bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11