From: Tom Rix <trix@redhat.com>
To: Xu Yilun <yilun.xu@intel.com>,
lee.jones@linaro.org, linux-kernel@vger.kernel.org
Cc: matthew.gerlach@linux.intel.com, russell.h.weight@intel.com,
lgoncalv@redhat.com, hao.wu@intel.com
Subject: Re: [PATCH v2 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap
Date: Tue, 26 Jan 2021 07:00:42 -0800 [thread overview]
Message-ID: <ff9cf230-8a77-febc-d9af-5d9ecf868649@redhat.com> (raw)
In-Reply-To: <1611643836-7183-4-git-send-email-yilun.xu@intel.com>
On 1/25/21 10:50 PM, Xu Yilun wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> This patch adds access tables to the MAX 10 BMC regmap. This prevents
> the host from accessing the unwanted I/O space. It also filters out the
> invalid outputs when reading the regmap debugfs interface.
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> ---
> v2: no change.
v2: Use M10BMC_LEGACY_BUILD_VER
Looks good.
Reviewed-by: Tom Rix <trix@redhat.com>
> ---
> drivers/mfd/intel-m10-bmc.c | 13 +++++++++++++
> include/linux/mfd/intel-m10-bmc.h | 5 ++++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c
> index aad86f0..4240e99 100644
> --- a/drivers/mfd/intel-m10-bmc.c
> +++ b/drivers/mfd/intel-m10-bmc.c
> @@ -23,10 +23,23 @@ static struct mfd_cell m10bmc_pacn3000_subdevs[] = {
> { .name = "n3000bmc-secure" },
> };
>
> +static const struct regmap_range m10bmc_regmap_range[] = {
> + regmap_reg_range(M10BMC_LEGACY_BUILD_VER, M10BMC_LEGACY_BUILD_VER),
> + regmap_reg_range(M10BMC_SYS_BASE, M10BMC_SYS_END),
> + regmap_reg_range(M10BMC_FLASH_BASE, M10BMC_FLASH_END),
> +};
> +
> +static const struct regmap_access_table m10bmc_access_table = {
> + .yes_ranges = m10bmc_regmap_range,
> + .n_yes_ranges = ARRAY_SIZE(m10bmc_regmap_range),
> +};
> +
> static struct regmap_config intel_m10bmc_regmap_config = {
> .reg_bits = 32,
> .val_bits = 32,
> .reg_stride = 4,
> + .wr_table = &m10bmc_access_table,
> + .rd_table = &m10bmc_access_table,
> .max_register = M10BMC_MEM_END,
> };
>
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index 99f44b1..dc2e858 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -11,7 +11,10 @@
>
> #define M10BMC_LEGACY_BUILD_VER 0x300468
> #define M10BMC_SYS_BASE 0x300800
> -#define M10BMC_MEM_END 0x1fffffff
> +#define M10BMC_SYS_END 0x300fff
> +#define M10BMC_FLASH_BASE 0x10000000
> +#define M10BMC_FLASH_END 0x1fffffff
> +#define M10BMC_MEM_END M10BMC_FLASH_END
>
> /* Register offset of system registers */
> #define NIOS2_FW_VERSION 0x0
next prev parent reply other threads:[~2021-01-26 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 6:50 [PATCH v2 0/4] Some improvement for Intel MAX 10 MFD drivers Xu Yilun
2021-01-26 6:50 ` [PATCH v2 1/4] mfd: intel-m10-bmc: Fix the register access range Xu Yilun
2021-01-26 6:50 ` [PATCH v2 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition Xu Yilun
2021-01-26 14:58 ` Tom Rix
2021-01-26 6:50 ` [PATCH v2 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap Xu Yilun
2021-01-26 15:00 ` Tom Rix [this message]
2021-01-26 6:50 ` [PATCH v2 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver Xu Yilun
2021-01-26 15:06 ` Tom Rix
2021-01-27 1:33 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9cf230-8a77-febc-d9af-5d9ecf868649@redhat.com \
--to=trix@redhat.com \
--cc=hao.wu@intel.com \
--cc=lee.jones@linaro.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.