From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Zheyu Ma <zheyuma97@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] tty: serial: jsm: allocate queue buffer at probe time
Date: Wed, 7 Jul 2021 21:13:13 +0200 [thread overview]
Message-ID: <ffa624c5-fc2a-780a-17d2-404cd94a289a@kernel.org> (raw)
In-Reply-To: <CAHp75Vceenv5ctk6f_eEtXBVzodXHhnpuudaniLM9A1edqYrXA@mail.gmail.com>
On 07. 07. 21, 14:52, Andy Shevchenko wrote:
> On Wed, Jul 7, 2021 at 10:50 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>> On 05. 07. 21, 14:53, Zheyu Ma wrote:
>
>> So how it comes an interrupt came before
>> neo_param() in jsm_tty_open was called?
>
> If IRQ is shared we have a special debug feature to test shared IRQs
> on freeing IRQ stage (*).
> But it doesn't matter, the IRQ handler must survive at any stage after
> the action has been listed.
Yes, but IRQ_NONE is returned from the ISR in that case.
The issue the patch is fixing is for a "malicious" device and I am not
sure we want to fix this -- if I can put in a malicious device, I can
use hammer to kill the box too…
thanks,
--
js
next prev parent reply other threads:[~2021-07-07 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 12:53 [PATCH v4] tty: serial: jsm: allocate queue buffer at probe time Zheyu Ma
2021-07-07 7:49 ` Jiri Slaby
2021-07-07 12:28 ` Zheyu Ma
2021-07-07 12:52 ` Andy Shevchenko
2021-07-07 19:13 ` Jiri Slaby [this message]
2021-07-09 14:00 ` Zheyu Ma
2021-07-09 14:20 ` Greg Kroah-Hartman
2021-07-09 14:55 ` Zheyu Ma
[not found] ` <CAHp75Vdne2fVAdmMYPn71T8LnSNMxVhBVK8dbmMASTSTUnOjBA@mail.gmail.com>
2021-07-07 10:37 ` Zheyu Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffa624c5-fc2a-780a-17d2-404cd94a289a@kernel.org \
--to=jirislaby@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.