All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
	Rasesh Mody <rmody@marvell.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	dpdk stable <stable@dpdk.org>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: add support for secondary process
Date: Tue, 14 Jan 2020 18:51:34 +0000	[thread overview]
Message-ID: <ffbc9890-c6de-14d9-e185-1842d064c2b7@redhat.com> (raw)
In-Reply-To: <CALBAE1Pm9sAN9gy6Fc69xbWxP1o1ZY+L760z5p6gRf35kJG-Xw@mail.gmail.com>

On 14/01/2020 04:51, Jerin Jacob wrote:
> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody <rmody@marvell.com> wrote:
>>
>> Skip the device re-initialization for secondary process.
>>
>> Cc: stable@dpdk.com
> 
> Correct Cc: to stable@dpdk.org
> 

Is it a fix, or secondary process was not intended to be supported
previously? If it is a fix, please provide the Fixed commit (will save
Ferruh searching for it).

> Applied to dpdk-next-net-mrvl/master. Thanks
> 
> 
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> 
>> ---
>>  drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
>> index 20b045ff87..7864b5b80a 100644
>> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
>> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
>> @@ -598,6 +598,11 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
>>
>>         eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops : &bnx2x_eth_dev_ops;
>>
>> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
>> +               PMD_DRV_LOG(ERR, sc, "Skipping device init from secondary process");
>> +               return 0;
>> +       }
>> +
>>         rte_eth_copy_pci_info(eth_dev, pci_dev);
>>
>>         sc->pcie_bus    = pci_dev->addr.bus;
>> --
>> 2.18.0
>>
> 


  reply	other threads:[~2020-01-14 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21  1:41 [dpdk-dev] [PATCH] net/bnx2x: add support for secondary process Rasesh Mody
2020-01-14  4:51 ` Jerin Jacob
2020-01-14 18:51   ` Kevin Traynor [this message]
2020-01-14 19:51     ` [dpdk-dev] [EXT] " Rasesh Mody
2020-01-15 10:58       ` Kevin Traynor
2020-01-15 12:47         ` Ferruh Yigit
2020-01-15 12:57           ` Kevin Traynor
2020-01-15 13:11             ` Ferruh Yigit
2020-01-15 14:02               ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffbc9890-c6de-14d9-e185-1842d064c2b7@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=GR-Everest-DPDK-Dev@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.