From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591CAC4361B for ; Thu, 3 Dec 2020 14:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97DAA2243E for ; Thu, 3 Dec 2020 14:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388468AbgLCOiJ (ORCPT ); Thu, 3 Dec 2020 09:38:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388712AbgLCOiI (ORCPT ); Thu, 3 Dec 2020 09:38:08 -0500 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F575C061A4E for ; Thu, 3 Dec 2020 06:37:28 -0800 (PST) Received: by mail-qk1-x742.google.com with SMTP id d9so2194996qke.8 for ; Thu, 03 Dec 2020 06:37:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tRaksBdiJ9O3u8mQ5z+bBUCn8VpNBVTbpG+ZUh7pbQQ=; b=kpYJ8mb/ShcMAiNzLiEB+p/aBtblThc0DZJd9ro0DuU3BjVw5Q7mHxKpEm5Z35eOPq 6vZxEiSgr46CaICHgD8sMy7QVVEzU4NVWDCRxehtTN8UbR9YMBuHXCFQ7uIUEzzHM9yT e2OhCAcHyCUsgYCKiWS0kXuUaY3BhGOpR/s0p6hbpqbt3AJUT9Xhe0rBsRJ7ZV9bc46Y TDp/1GUTIOvK3bJ1cNX3p8zNq9t0X/bWDnjnn45ZdG3E48pVEAz6ET+C+Ranm39plFdB ygxPw4NbcMOei5EZksnKbx4ryJ2DkC7LGeplGWEcJbC7zTrfd8p9jZEzhDW6KHE55ata K/yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tRaksBdiJ9O3u8mQ5z+bBUCn8VpNBVTbpG+ZUh7pbQQ=; b=TOmiobZdIvyIJN5VeZV2nNsLFUtj38rZOG+G9uYIWyy/zU8E1pqcxaPxAEvcvJWYi4 q3K2PyXQ1+v16BirVf4qGLdk69PA3Kg7tz0ZdISxlorVNcYBsflXq3Ss+jblV5P5HBbZ Yv8cghQTJiYpR46O9JuCVrwT+d2BLa+0Pn7srQL/QzJBoE2JmggWhfExBtrODFGku5PM jsZ91Li3bBHrc92WLG2JAsymXa4rJArrcKOtKj2U7iJcpclErfktOHFGw065foxSN+bp 1Hv26YhNptajW9mgPdnd6GEDXzY41QK5+fHVAIt7KPRMdSCkq2L7E8AuYPhbe/VCC7EQ BljA== X-Gm-Message-State: AOAM530PAToAmJKXX6JVb89uRqO4DgzDzcrY3xKjJbgyLntnB/xVvl7Z Bv9S/bgqE9A2qTqaRvxixPTzzg== X-Google-Smtp-Source: ABdhPJzMX8HmCsVHfR0OmrZIiDkY3k1n+yjarn0l1aQitgNLcxdJGX8+i5hzVL952EH6qox7kOkGYA== X-Received: by 2002:a05:620a:790:: with SMTP id 16mr3154252qka.169.1607006247296; Thu, 03 Dec 2020 06:37:27 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id v9sm1394976qkv.34.2020.12.03.06.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 06:37:26 -0800 (PST) Subject: Re: [PATCH v6 11/11] btrfs: implement RWF_ENCODED writes To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: From: Josef Bacik Message-ID: Date: Thu, 3 Dec 2020 09:37:24 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 11/18/20 2:18 PM, Omar Sandoval wrote: > From: Omar Sandoval > > The implementation resembles direct I/O: we have to flush any ordered > extents, invalidate the page cache, and do the io tree/delalloc/extent > map/ordered extent dance. From there, we can reuse the compression code > with a minor modification to distinguish the write from writeback. This > also creates inline extents when possible. > > Now that read and write are implemented, this also sets the > FMODE_ENCODED_IO flag in btrfs_file_open(). > > Signed-off-by: Omar Sandoval Fix up the spacing thing and then you can add Reviewed-by: Josef Bacik Thanks, Josef