From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCE0C433B4 for ; Fri, 16 Apr 2021 14:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FD7761184 for ; Fri, 16 Apr 2021 14:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244999AbhDPOlV (ORCPT ); Fri, 16 Apr 2021 10:41:21 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:41274 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245198AbhDPOk2 (ORCPT ); Fri, 16 Apr 2021 10:40:28 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GEUtKK009382; Fri, 16 Apr 2021 16:39:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=Xbx2b/X53e/YNr87udE0tvXK0AMuNYFQVa+rw8yKsYw=; b=xaSYVT3S5/RwrdOKAd8j68wAmCp00E1Ia2ecibHukCf8xQcQjttQFSgV5Y82sWwlPYAy kJabxPdxNjVVv3MrGTOypQZB5WFWgEPn/O5PifOvKLu/GmxB3ufcvEqE3sGXVLgSDZn3 alm9CtstHU+A5cDVq4le1lGJFSrdamit096t86vgS9rVE8AGsYLxxOFULh8vyRMZRCTV NveiKlTFTDmeNHHEMTL12yVGwYV2tdccRPivevLZpRdcY7W7tmID811F6n4wYi4FO19Y LifTu0XnggeG3c3mr0epNi+7sQdguAK7Nb4Nr4yg7c17YExy9FUfSSd+pU1rgT2ZVjX6 Mg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37xes12j0g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 16:39:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F003710002A; Fri, 16 Apr 2021 16:39:46 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id DE6F3241576; Fri, 16 Apr 2021 16:39:46 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 16 Apr 2021 16:39:46 +0200 Subject: Re: [PATCH 2/7] clk: stm32mp1: The dev is always NULL, replace it with np To: Marek Vasut , "gabriel.fernandez@foss.st.com" , CC: Christophe Roullier , Patrice Chotard , Patrick Delaunay , Stephen Boyd , , References: <20210408185731.135511-1-marex@denx.de> <20210408185731.135511-3-marex@denx.de> <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> From: Alexandre TORGUE Message-ID: Date: Fri, 16 Apr 2021 16:39:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-16_07:2021-04-16,2021-04-16 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Marek On 4/16/21 3:39 PM, Marek Vasut wrote: > On 4/16/21 8:44 AM, gabriel.fernandez@foss.st.com wrote: >> Hi Marek, > > Hello Gabriel, > >> I have a patch-set in progress using $dev (convertion into module >> driver). >> >> https://patchwork.kernel.org/project/linux-clk/list/?series=421767 >> >> Then rebase of your patch, [PATCH 4/7] clk: stm32mp1: Add parent_data >> to ETHRX clock, can be done easily. > > I suspect the aforementioned patchset will have to be reworked, since > the current approach to push SCMI onto every system and renumerate the > clock has been rejected, because it caused DT ABI break and boot > problems on many systems. SCMI patches for clock drivers will be pushed (and merged one day :)). We only drop the DT part which will be done through dtbo in uboot/tfa/optee. regards alex > > btw please don't top-post. > >> Best regards >> Gabriel >> >> On 4/8/21 8:57 PM, Marek Vasut wrote: >>> Instead of passing around $dev to all the registration functions, which >>> is always NULL, pass around struct device_node pointer $np. This way it >>> is possible to use of_clk_hw_register*() functions and/or register clock >>> with associated $np pointer. > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31711C433B4 for ; Fri, 16 Apr 2021 14:43:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A81E561073 for ; Fri, 16 Apr 2021 14:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A81E561073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OzbQ2RXctCbrXMBf+oNdmj3flw9U2v8gHtNrMREqQ10=; b=RqzpWb0zV+f6g424BOYkFdRco HSdYqISvw1pc/ht5Jl3D5mkJDsgPejkabpveGsQHqn/3AKT2sroMS3uWIoQ1LTg/6xoToBL+Pp9hG Ph3MIlsWlWPfyVxPi4Y8h0zX/ezeSeXRsbHz58vy65oe7D2oU67ojbfjql4I1/o3jVkHV8unLIZrR AHnja49RMXa5BSmJGqoicGgyFsGWaKszwJ7P6egs1NM1nXE7vbGqCWPuHNkxaDnNLtwp2qOqvv3P+ gABqrEvoipJYCB/OdukaJ9Xvo2fPVFuyqD+Gd+3Wk7SG9St1WFqXHN+mQftD56wIKoue0xMqEetrA NiEVjuCuA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXPe5-002RX5-NO; Fri, 16 Apr 2021 14:40:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXPdb-002RJk-Lp for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 14:40:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=Xbx2b/X53e/YNr87udE0tvXK0AMuNYFQVa+rw8yKsYw=; b=UFa5w/qc2oW/XEohD+hbBKDFfV M0+uD4jYPp5b5bVpIa3xji34gttE0ntJo4vPyx5lGksSsFMXEFtaMrZTLAOUx1WnLbVUHEG4lECpV AB2eEzIKP/WFElkHpykY4l4MpczLIxQtcmgQfDiwVxZm9z9W8l2bwQ4FLWsdBWp/lK5PxQR+YOOis qzVYeGAVBjIbPxEUBqEJnDrG8JmIgz4Nc3SAOcTCNGuOlgBBn9Ec6U3lkiAAUSqFZnmRGIWG4B3PF EaFQtrOCoGwRk3pc2YB4lgPG596go2p+U6fFK8AxqP0BxUI7pz8tvXOBPtN+ViTN9lk2aWI6I3R7c E2M6Gqxw==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXPdW-009Sdg-2N for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 14:40:02 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GEUtKK009382; Fri, 16 Apr 2021 16:39:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=Xbx2b/X53e/YNr87udE0tvXK0AMuNYFQVa+rw8yKsYw=; b=xaSYVT3S5/RwrdOKAd8j68wAmCp00E1Ia2ecibHukCf8xQcQjttQFSgV5Y82sWwlPYAy kJabxPdxNjVVv3MrGTOypQZB5WFWgEPn/O5PifOvKLu/GmxB3ufcvEqE3sGXVLgSDZn3 alm9CtstHU+A5cDVq4le1lGJFSrdamit096t86vgS9rVE8AGsYLxxOFULh8vyRMZRCTV NveiKlTFTDmeNHHEMTL12yVGwYV2tdccRPivevLZpRdcY7W7tmID811F6n4wYi4FO19Y LifTu0XnggeG3c3mr0epNi+7sQdguAK7Nb4Nr4yg7c17YExy9FUfSSd+pU1rgT2ZVjX6 Mg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37xes12j0g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 16:39:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F003710002A; Fri, 16 Apr 2021 16:39:46 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id DE6F3241576; Fri, 16 Apr 2021 16:39:46 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 16 Apr 2021 16:39:46 +0200 Subject: Re: [PATCH 2/7] clk: stm32mp1: The dev is always NULL, replace it with np To: Marek Vasut , "gabriel.fernandez@foss.st.com" , CC: Christophe Roullier , Patrice Chotard , Patrick Delaunay , Stephen Boyd , , References: <20210408185731.135511-1-marex@denx.de> <20210408185731.135511-3-marex@denx.de> <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> From: Alexandre TORGUE Message-ID: Date: Fri, 16 Apr 2021 16:39:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-16_07:2021-04-16, 2021-04-16 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_073958_595973_438EA060 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek On 4/16/21 3:39 PM, Marek Vasut wrote: > On 4/16/21 8:44 AM, gabriel.fernandez@foss.st.com wrote: >> Hi Marek, > > Hello Gabriel, > >> I have a patch-set in progress using $dev (convertion into module >> driver). >> >> https://patchwork.kernel.org/project/linux-clk/list/?series=421767 >> >> Then rebase of your patch, [PATCH 4/7] clk: stm32mp1: Add parent_data >> to ETHRX clock, can be done easily. > > I suspect the aforementioned patchset will have to be reworked, since > the current approach to push SCMI onto every system and renumerate the > clock has been rejected, because it caused DT ABI break and boot > problems on many systems. SCMI patches for clock drivers will be pushed (and merged one day :)). We only drop the DT part which will be done through dtbo in uboot/tfa/optee. regards alex > > btw please don't top-post. > >> Best regards >> Gabriel >> >> On 4/8/21 8:57 PM, Marek Vasut wrote: >>> Instead of passing around $dev to all the registration functions, which >>> is always NULL, pass around struct device_node pointer $np. This way it >>> is possible to use of_clk_hw_register*() functions and/or register clock >>> with associated $np pointer. > [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel