All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode
Date: Tue, 29 Nov 2016 14:28:45 +0200	[thread overview]
Message-ID: <ffd04527-48c5-d226-63f2-715b300c806f@ti.com> (raw)
In-Reply-To: <87k2bmo662.fsf@linux.intel.com>

Hi,

On 29/11/16 13:51, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>> DCFG.DEVSPD == 0x3 is not valid and we need to set
>> DCFG.DEVSPD to 0x1 for full speed mode.
> 
> seems like it has been made invalid somewhere between 1.73a and
> 2.60a. Can you figure it out from Documentation why and when it was made
> invalid? We might need revision checks here.
> 

I'll try to dig out more.
For now from TI DRA7 TRM, 0x3 seems to be FS for serial PHY. (see below)
Do you know if any platform uses that mode?
If we need to support both Full speed modes, how do we specify which
mode we want to set? Some DT parameter?

"0x0: High Speed (HS): 480 Mbit/s - Supported from all
USB controllers
0x1: Full Speed (FS): 12 Mbit/s - Supported from all USB
controllers
0x3: Full Speed (FS): 12 Mbit/s on serial PHY: NOT
SUPPORTED
0x4: Super Speed (SS): 5 Gbit/s - Supported only from
USB1 controller
0x2: Low Speed (LS): 1.5 Mbit/s on serial PHY: NOT
SUPPORTED"

cheers,
-roger

  reply	other threads:[~2016-11-29 12:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 10:56 [PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration Roger Quadros
2016-11-29 10:56 ` [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Roger Quadros
2016-11-29 11:51   ` Felipe Balbi
2016-11-29 12:28     ` Roger Quadros [this message]
2016-12-07 12:16       ` Roger Quadros
2016-12-07 12:43         ` Felipe Balbi
2016-12-08  3:06           ` John Youn
2016-12-17  1:02             ` John Youn
2016-12-20 12:23               ` Felipe Balbi
2016-11-29 10:56 ` [PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffd04527-48c5-d226-63f2-715b300c806f@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.