From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A7DC433EF for ; Fri, 24 Sep 2021 07:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95D8F60F3A for ; Fri, 24 Sep 2021 07:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244477AbhIXHzS (ORCPT ); Fri, 24 Sep 2021 03:55:18 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:20006 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237965AbhIXHzS (ORCPT ); Fri, 24 Sep 2021 03:55:18 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HG41Q6DZXzbmlh; Fri, 24 Sep 2021 15:49:30 +0800 (CST) Received: from dggema766-chm.china.huawei.com (10.1.198.208) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Fri, 24 Sep 2021 15:53:44 +0800 Received: from [10.174.177.210] (10.174.177.210) by dggema766-chm.china.huawei.com (10.1.198.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Fri, 24 Sep 2021 15:53:43 +0800 Message-ID: Date: Fri, 24 Sep 2021 15:53:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] ramfs: fix mount source show for ramfs To: Al Viro CC: , , , , , References: <20210811122811.2288041-1-yangerkun@huawei.com> From: yangerkun In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema766-chm.china.huawei.com (10.1.198.208) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org 在 2021/9/24 12:35, Al Viro 写道: > On Wed, Aug 11, 2021 at 08:28:11PM +0800, yangerkun wrote: >> ramfs_parse_param does not parse key "source", and will convert >> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in >> vfs_parse_fs_param, which lead always "none" mount source for ramfs. Fix >> it by parse "source" in ramfs_parse_param. >> >> Signed-off-by: yangerkun >> --- >> fs/ramfs/inode.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c >> index 65e7e56005b8..0d7f5f655fd8 100644 >> --- a/fs/ramfs/inode.c >> +++ b/fs/ramfs/inode.c >> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context *fc, struct fs_parameter *param) >> struct ramfs_fs_info *fsi = fc->s_fs_info; >> int opt; >> >> + opt = vfs_parse_fs_param_source(fc, param); >> + if (opt != -ENOPARAM) >> + return opt; >> + >> opt = fs_parse(fc, ramfs_fs_parameters, param, &result); >> if (opt < 0) { >> /* > > Umm... If anything, I would rather call that thing *after* > fs_parse() gives negative, similar to what kernel/cgroup/cgroup-v1.c > does. Thanks for your advise. Will do it next version. > . >