All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Zou <zou_wei@huawei.com>
To: <linus.walleij@linaro.org>, <radim.pavlik@tbs-biometrics.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
Date: Tue, 8 Jun 2021 11:22:04 +0800	[thread overview]
Message-ID: <ffe5b0a2-7307-f4d0-16fc-0712d55ce36d@huawei.com> (raw)
In-Reply-To: <1623069869-39309-1-git-send-email-zou_wei@huawei.com>



On 2021/6/7 20:44, Zou Wei wrote:
> Add the missing unlock before return from function mcp23s08_irq()
> in the error handling case.
> 
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>   drivers/pinctrl/pinctrl-mcp23s08.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
> index 799d596..e12aa09 100644
> --- a/drivers/pinctrl/pinctrl-mcp23s08.c
> +++ b/drivers/pinctrl/pinctrl-mcp23s08.c
> @@ -353,6 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
>   
>   	if (intf == 0) {
>   		/* There is no interrupt pending */
> +		goto unlock;
>   		return IRQ_HANDLED;
One mistake here is to forget to delete the "return IRQ_HANDLED" line, 
please ignore this patch, I will send v2 later.
>   	}
>   
> 

      reply	other threads:[~2021-06-08  3:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 12:44 [PATCH -next] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq() Zou Wei
2021-06-08  3:22 ` Samuel Zou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffe5b0a2-7307-f4d0-16fc-0712d55ce36d@huawei.com \
    --to=zou_wei@huawei.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radim.pavlik@tbs-biometrics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.