From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2280C433EF for ; Thu, 27 Jan 2022 17:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236775AbiA0Rxz (ORCPT ); Thu, 27 Jan 2022 12:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231817AbiA0Rxy (ORCPT ); Thu, 27 Jan 2022 12:53:54 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D942C061714 for ; Thu, 27 Jan 2022 09:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xOfwpIfWLMPtjwB4vDcjz0nGgt//wy4YV2BIhmW85Fk=; b=bM4BiFOEIwTJLVGM39kyrhwBpk 3ba+N3s7G1FIDlUJv5vjHOYjMpk+qaD6mnpgQeonKKOvqz3jJ6JyXta4L2QdDbU5oowWsM2hDxqPN ICrgSXY8oMpCOSFR1pTRs9Z4ob79TKwpquB6kAq+EB2T7XA5oQ6yACGbvq+2cWq3cTMG04C5SZz1q gll/PxRXPO+b5mJ3Ws0w4Jx/SJTDoHNTG4ZSWPqa3BIwswI+QGpnpXxb9wfNPiYzoAJ7pxmYKSLSY 2QEfjSlR5G+OeWGLjj2fJuTyLm1NYpLWycdH3pvlbcrf6spdoF4OBOoCKydiLcfOAuLpp624Kmi86 selLBFpA==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:57435 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nD8xz-0006Bx-KX; Thu, 27 Jan 2022 18:53:51 +0100 Message-ID: Date: Thu, 27 Jan 2022 18:53:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver To: Maxime Ripard , robh+dt@kernel.org Cc: thierry.reding@gmail.com, sam@ravnborg.org, dave.stevenson@raspberrypi.com, david@lechnology.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20220125175700.37408-1-noralf@tronnes.org> <20220125175700.37408-4-noralf@tronnes.org> <20220127100452.bmxcgf6ye3nxrgtq@houat> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220127100452.bmxcgf6ye3nxrgtq@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Den 27.01.2022 11.04, skrev Maxime Ripard: > On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that is to be used by Linux. The 'compatible' Device Tree property with >> a '.bin' suffix will be used to load a firmware file that contains the >> controller configuration. >> >> Example (driver will load sainsmart18.bin): >> >> display@0 { >> compatible = "sainsmart18", "panel-mipi-dbi-spi"; >> reg = <0>; >> reset-gpios = <&gpio 25 0>; >> dc-gpios = <&gpio 24 0>; >> }; >> >> v2: >> - Drop model property and use compatible instead (Rob) >> - Add wiki entry in MAINTAINERS >> >> Signed-off-by: Noralf Trønnes >> --- >> MAINTAINERS | 8 + >> drivers/gpu/drm/panel/Kconfig | 11 + >> drivers/gpu/drm/panel/Makefile | 1 + >> drivers/gpu/drm/panel/panel-mipi-dbi.c | 394 +++++++++++++++++++++++++ >> 4 files changed, 414 insertions(+) >> create mode 100644 drivers/gpu/drm/panel/panel-mipi-dbi.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d03ad8da1f36..8baa98723bdc 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6047,6 +6047,14 @@ T: git git://anongit.freedesktop.org/drm/drm-misc >> F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt >> F: drivers/gpu/drm/tiny/mi0283qt.c >> >> +DRM DRIVER FOR MIPI DBI compatible panels >> +M: Noralf Trønnes >> +S: Maintained >> +W: https://github.com/notro/panel-mipi-dbi/wiki >> +T: git git://anongit.freedesktop.org/drm/drm-misc >> +F: Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml >> +F: drivers/gpu/drm/panel/panel-mipi-dbi.c >> + >> DRM DRIVER FOR MSM ADRENO GPU >> M: Rob Clark >> M: Sean Paul >> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig >> index 434c2861bb40..1851cda5f877 100644 >> --- a/drivers/gpu/drm/panel/Kconfig >> +++ b/drivers/gpu/drm/panel/Kconfig >> @@ -274,6 +274,17 @@ config DRM_PANEL_LG_LG4573 >> Say Y here if you want to enable support for LG4573 RGB panel. >> To compile this driver as a module, choose M here. >> >> +config DRM_PANEL_MIPI_DBI >> + tristate "MIPI DBI compatible panel" >> + depends on SPI >> + depends on BACKLIGHT_CLASS_DEVICE >> + depends on DRM_KMS_HELPER >> + select DRM_KMS_CMA_HELPER >> + select DRM_MIPI_DBI >> + help >> + Say Y here if you want to enable support for MIPI DBI compatible panels. >> + To compile this driver as a module, choose M here. >> + >> config DRM_PANEL_NEC_NL8048HL11 >> tristate "NEC NL8048HL11 RGB panel" >> depends on GPIOLIB && OF && SPI >> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile >> index d99fbbce49d1..a90c30459964 100644 >> --- a/drivers/gpu/drm/panel/Makefile >> +++ b/drivers/gpu/drm/panel/Makefile >> @@ -25,6 +25,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK050H3146W) += panel-leadtek-ltk050h3146w.o >> obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o >> obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o >> obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o >> +obj-$(CONFIG_DRM_PANEL_MIPI_DBI) += panel-mipi-dbi.o >> obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o >> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o >> obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o >> diff --git a/drivers/gpu/drm/panel/panel-mipi-dbi.c b/drivers/gpu/drm/panel/panel-mipi-dbi.c >> new file mode 100644 >> index 000000000000..6e3dc2de21d2 >> --- /dev/null >> +++ b/drivers/gpu/drm/panel/panel-mipi-dbi.c >> @@ -0,0 +1,394 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * DRM driver for MIPI DBI compatible display panels >> + * >> + * Copyright 2022 Noralf Trønnes >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include