From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932866AbcJGUl0 (ORCPT ); Fri, 7 Oct 2016 16:41:26 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34183 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757030AbcJGUlR (ORCPT ); Fri, 7 Oct 2016 16:41:17 -0400 Subject: Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document To: Moritz Fischer References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> Cc: Alan Tull , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel From: Joshua Clayton Message-ID: Date: Fri, 7 Oct 2016 13:41:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moritz, thank you very much for the review. On 10/06/2016 07:53 PM, Moritz Fischer wrote: > Hi Joshua, > > On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: >> Describe a cyclonespi devicetree entry, required features >> >> Signed-off-by: Joshua Clayton >> --- >> .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> >> diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> new file mode 100644 >> index 0000000..8de34db >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> @@ -0,0 +1,23 @@ >> +Altera SOCFPGA FPGA Manager > Copy & Paste? :) Oops :( As you might image, documentation was the last item done with the least attention. Will fix. > >> +Altera cyclone FPGAs support a method of loading the bitstream over what is > cyclone->Cyclone OK. >> +referred to as "passive serial". >> +The passive serial link is not technically spi, and might require extra >> +circuits in order to play nicely with other spi slaves on the same bus. >> + >> +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf >> + >> +Required properties: >> +- compatible : should contain "altr,cyclonespi-fpga-mgr" > Alan, do you guys have any input on the compat string? I am open to change if it makes sense. I tried to keep the format similar. > I think generally the bindings should go before the actual usage in > your patch series. Meaning you wanna document the binding > before you use it. I think this patch should be [1/3]. Ah, In my mind I had it backwards. > Cheers, > > Moritz I'll give Alan a chance to review and then spin a V2 Joshua Clayton From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Clayton Subject: Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document Date: Fri, 7 Oct 2016 13:41:07 -0700 Message-ID: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Moritz Fischer Cc: Alan Tull , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Devicetree List , Linux Kernel Mailing List , linux-arm-kernel List-Id: devicetree@vger.kernel.org Moritz, thank you very much for the review. On 10/06/2016 07:53 PM, Moritz Fischer wrote: > Hi Joshua, > > On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: >> Describe a cyclonespi devicetree entry, required features >> >> Signed-off-by: Joshua Clayton >> --- >> .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> >> diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> new file mode 100644 >> index 0000000..8de34db >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> @@ -0,0 +1,23 @@ >> +Altera SOCFPGA FPGA Manager > Copy & Paste? :) Oops :( As you might image, documentation was the last item done with the least attention. Will fix. > >> +Altera cyclone FPGAs support a method of loading the bitstream over what is > cyclone->Cyclone OK. >> +referred to as "passive serial". >> +The passive serial link is not technically spi, and might require extra >> +circuits in order to play nicely with other spi slaves on the same bus. >> + >> +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf >> + >> +Required properties: >> +- compatible : should contain "altr,cyclonespi-fpga-mgr" > Alan, do you guys have any input on the compat string? I am open to change if it makes sense. I tried to keep the format similar. > I think generally the bindings should go before the actual usage in > your patch series. Meaning you wanna document the binding > before you use it. I think this patch should be [1/3]. Ah, In my mind I had it backwards. > Cheers, > > Moritz I'll give Alan a chance to review and then spin a V2 Joshua Clayton -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: stillcompiling@gmail.com (Joshua Clayton) Date: Fri, 7 Oct 2016 13:41:07 -0700 Subject: [PATCH 2/3] doc: dt: add cyclone-spi binding document In-Reply-To: References: <4b4432c04b4ea92a2af814e3d7866c33f2eb12ea.1475783742.git.stillcompiling@gmail.com> <8d89e70475e8e1c3ce5117a0367c8444c11c61e3.1475783742.git.stillcompiling@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Moritz, thank you very much for the review. On 10/06/2016 07:53 PM, Moritz Fischer wrote: > Hi Joshua, > > On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: >> Describe a cyclonespi devicetree entry, required features >> >> Signed-off-by: Joshua Clayton >> --- >> .../bindings/fpga/cyclone-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> >> diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> new file mode 100644 >> index 0000000..8de34db >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt >> @@ -0,0 +1,23 @@ >> +Altera SOCFPGA FPGA Manager > Copy & Paste? :) Oops :( As you might image, documentation was the last item done with the least attention. Will fix. > >> +Altera cyclone FPGAs support a method of loading the bitstream over what is > cyclone->Cyclone OK. >> +referred to as "passive serial". >> +The passive serial link is not technically spi, and might require extra >> +circuits in order to play nicely with other spi slaves on the same bus. >> + >> +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf >> + >> +Required properties: >> +- compatible : should contain "altr,cyclonespi-fpga-mgr" > Alan, do you guys have any input on the compat string? I am open to change if it makes sense. I tried to keep the format similar. > I think generally the bindings should go before the actual usage in > your patch series. Meaning you wanna document the binding > before you use it. I think this patch should be [1/3]. Ah, In my mind I had it backwards. > Cheers, > > Moritz I'll give Alan a chance to review and then spin a V2 Joshua Clayton