All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 2.6.12-rc5-mm2] max6875: new i2c device driver
Date: Fri, 24 Jun 2005 15:35:18 +0000	[thread overview]
Message-ID: <gGnTe7JE.1119619845.6187990.khali@localhost> (raw)
In-Reply-To: <F06EB2894F3F0D45AD9BEA7246DE9C9076C659@WCSEXCMBS1.ad.wabtec.com>


Hi again Ben,

One more thing about the max6875 driver. After reading the datasheet, I
think I understand that each chip will respond to two I2C addresses
(0x50+0x51 or 0x52+0x53). Your driver should allocate a subclient for
the second address (see the asb100 driver for an example) so as to
prevent another driver (e.g. eeprom) from requesting it and cause a
conflict. Also, this should give you the possibility to improve your
device identification procedure: if the same register or EEPROM location
read from both addresses return different results, this certainly is a
misdetection. And the sole fact of ensuring that the other address is
responsive will avoid some misdetections too.

Thanks,
--
Jean Delvare

      parent reply	other threads:[~2005-06-24 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 19:04 [lm-sensors] [PATCH 2.6.12-rc5-mm2] max6875: new i2c device driver BGardner
2005-06-23 23:31 ` Jean Delvare
2005-06-24  0:33 ` BGardner
2005-06-24 11:29 ` Jean Delvare
2005-06-24 15:35 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gGnTe7JE.1119619845.6187990.khali@localhost \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.