[PATCH 1/2] kconfig-language: fix comment on dependency-generated menu structures.

[PATCH 1/2] kconfig-language: fix comment on dependency-generated menu structures.

[Dirk Gouders]

In the given example, the comment becomes visible when it's dependency
is set to 'n', but the text asserts the opposite.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
 Documentation/kbuild/kconfig-language.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/kbuild/kconfig-language.txt b/Documentation/kbuild/kconfig-language.txt
index c52856d..14dd131 100644
--- a/Documentation/kbuild/kconfig-language.txt
+++ b/Documentation/kbuild/kconfig-language.txt
@@ -241,9 +241,8 @@ comment "module support disabled"
 	depends on !MODULES
 
 MODVERSIONS directly depends on MODULES, this means it's only visible if
-MODULES is different from 'n'. The comment on the other hand is always
-visible when MODULES is visible (the (empty) dependency of MODULES is
-also part of the comment dependencies).
+MODULES is different from 'n'. The comment on the other hand is only
+visible when MODULES is set to 'n'.
 
 
 Kconfig syntax
-- 
2.8.1

[PATCH 0/2] kconfig-language: Fix and choices details

[Dirk Gouders]

Hi,

following are two patches for kconfig-language.txt.

The first one IMHO fixes wrong information, the second one includes more
elaborate information about the type of choices that I gathered while working on a patch.

Dirk

Dirk Gouders (2):
  kconfig-language: fix comment on dependency-generated menu structures.
  kconfig-language: elaborate on the type of a choice

 Documentation/kbuild/kconfig-language.txt | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

-- 
2.8.1

[PATCH 2/2] kconfig-language: elaborate on the type of a choice

[Dirk Gouders]

The type of a choice can be specified explicitely or it will be
set according to members of the choice group, see menu.c:menu_finalize().

Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
 Documentation/kbuild/kconfig-language.txt | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/Documentation/kbuild/kconfig-language.txt b/Documentation/kbuild/kconfig-language.txt
index 14dd131..db10185 100644
--- a/Documentation/kbuild/kconfig-language.txt
+++ b/Documentation/kbuild/kconfig-language.txt
@@ -284,12 +284,17 @@ choices:
 	"endchoice"
 
 This defines a choice group and accepts any of the above attributes as
-options. A choice can only be of type bool or tristate, while a boolean
-choice only allows a single config entry to be selected, a tristate
-choice also allows any number of config entries to be set to 'm'. This
-can be used if multiple drivers for a single hardware exists and only a
-single driver can be compiled/loaded into the kernel, but all drivers
-can be compiled as modules.
+options. A choice can only be of type bool or tristate.  If no type is
+specified for a choice, it's type will be determined by the type of
+the first choice element in the group or remain unknown if none of the
+choice elements have a type specified, as well.
+
+While a boolean choice only allows a single config entry to be
+selected, a tristate choice also allows any number of config entries
+to be set to 'm'. This can be used if multiple drivers for a single
+hardware exists and only a single driver can be compiled/loaded into
+the kernel, but all drivers can be compiled as modules.
+
 A choice accepts another option "optional", which allows to set the
 choice to 'n' and no entry needs to be selected.
 If no [symbol] is associated with a choice, then you can not have multiple
-- 
2.8.1

Re: [PATCH 0/2] kconfig-language: Fix and choices details

[Michal Marek]

On Fri, Apr 29, 2016 at 12:25:34PM +0200, Dirk Gouders wrote:
> 
> Hi,
> 
> following are two patches for kconfig-language.txt.
> 
> The first one IMHO fixes wrong information, the second one includes more
> elaborate information about the type of choices that I gathered while working on a patch.
> 
> Dirk
> 
> Dirk Gouders (2):
>   kconfig-language: fix comment on dependency-generated menu structures.
>   kconfig-language: elaborate on the type of a choice

Applied to kbuild.git#kconfig.

Michal