From: Colton Lewis <coltonlewis@google.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: alexandru.elisei@arm.com, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, maz@kernel.org,
eric.auger@redhat.com, oliver.upton@linux.dev, reijiw@google.com,
ricarkol@google.com
Subject: Re: [kvm-unit-tests PATCH] arm: Remove MAX_SMP probe loop
Date: Fri, 06 Jan 2023 17:37:16 +0000 [thread overview]
Message-ID: <gsntwn5zr2cz.fsf@coltonlewis-kvm.c.googlers.com> (raw)
In-Reply-To: <20230106071124.ytv6cmkvmvxhzmoh@orel> (message from Andrew Jones on Fri, 6 Jan 2023 08:11:24 +0100)
Andrew Jones <andrew.jones@linux.dev> writes:
>> We could cap at 8 for ACCEL=tcg. Even if no one cares, I'm tempted to do
>> it so no one hits the same little landmine as me in the future.
> TCG supports up to 255 CPUs. The only reason it'd have a max of 8 is if
> you were configuring a GICv2 instead of a GICv3.
That makes sense as it was the GICv2 tests failing that led me to this
rabbit hole. In that case, it should be completely safe to delete the
loop because all the GICv2 tests have ternary condition to cap at 8
already.
If we can't delete, the loop logic is still a suboptimal way to do
things as qemu reports the max cpus it can take. We could read MAX_SMP
from qemu error output.
next prev parent reply other threads:[~2023-01-06 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:52 [kvm-unit-tests PATCH] arm: Remove MAX_SMP probe loop Colton Lewis
2022-12-19 18:52 ` Colton Lewis
2022-12-20 10:41 ` Alexandru Elisei
2022-12-20 10:41 ` Alexandru Elisei
2022-12-20 16:32 ` Colton Lewis
2022-12-20 16:32 ` Colton Lewis
2022-12-26 18:21 ` Andrew Jones
2022-12-26 18:21 ` Andrew Jones
2023-01-05 23:09 ` Colton Lewis
2023-01-06 7:11 ` Andrew Jones
2023-01-06 17:37 ` Colton Lewis [this message]
2023-01-09 8:59 ` Andrew Jones
2023-01-09 21:43 ` Colton Lewis
2022-12-26 18:12 ` Andrew Jones
2022-12-26 18:12 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gsntwn5zr2cz.fsf@coltonlewis-kvm.c.googlers.com \
--to=coltonlewis@google.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=reijiw@google.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.