From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Fleming Date: Fri, 23 Apr 2010 20:13:07 -0500 Subject: [U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X In-Reply-To: <1270427570-29948-1-git-send-email-marek.vasut@gmail.com> References: <1270427570-29948-1-git-send-email-marek.vasut@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Apr 4, 2010 at 7:32 PM, Marek Vasut wrote: > In case the delays were set to 10000, the MMC card on PXA27X boards (and PXA3xx > boards) didn't initialize on first try. Increasing the delays and leaving just > those for PXA25x and 26x (that is 200000) fixes this problem. In general, I object to board-specific #ifdefs in drivers. At the very least, change this so that the value is specified like so: #ifndef PXA_TIMEOUT_DELAY #define PXA_TIMEOUT_DELAY 10000 #endif And then override the value in the PXA27X config file. That way, when the next board comes along, and someone objects to waiting a fifth of a second between each try, but they need more than 10,000us, they can override it to a different value without doing cascading #ifdefs. Andy