From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045Ab0DAVBQ (ORCPT ); Thu, 1 Apr 2010 17:01:16 -0400 Received: from mail-fx0-f227.google.com ([209.85.220.227]:58385 "EHLO mail-fx0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920Ab0DAVBM convert rfc822-to-8bit (ORCPT ); Thu, 1 Apr 2010 17:01:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=NVH4l/OegqApV7pDdbmgwC9FIm1+rKTiFJ7pA0qAo41dAQH8mfectIJTRIU6WVsWAb V6tFgYqyKPzmUaHdkfsbwdToRFbYJ7Zko1PRhuT09MeEWfLcEbbafhGTjfhXvTW4QwIp bJAhujH+jY3DfcDhxGNyORIhFYxev4rgsqgb8= MIME-Version: 1.0 In-Reply-To: <201004012248.38794.rjw@sisk.pl> References: <201004012228.06938.rjw@sisk.pl> <201004012248.38794.rjw@sisk.pl> Date: Thu, 1 Apr 2010 17:01:11 -0400 Message-ID: Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) From: Alex Deucher To: "Rafael J. Wysocki" Cc: Clemens Ladisch , Linus Torvalds , Linux PCI , Greg KH , Linux Kernel Mailing List , Jesse Barnes , dri-devel@lists.sourceforge.net, stable@kernel.org, Dave Airlie Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 1, 2010 at 4:48 PM, Rafael J. Wysocki wrote: > On Thursday 01 April 2010, Alex Deucher wrote: >> On Thu, Apr 1, 2010 at 4:28 PM, Rafael J. Wysocki wrote: >> > On Thursday 01 April 2010, Alex Deucher wrote: >> >> On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch wrote: >> >> > Alex Deucher wrote: >> >> >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki wrote: >> >> >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: >> >> >>>> >       PCI quirk: RS780/RS880: work around missing MSI initialization >> >> >>>> >> >> >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box >> >> >>>> which happens to have a RS780. >> >> > >> >> > So it's better to disable MSI unconditionally. >> >> > >> >> > Rafael, can you check if MSI works for the HDMI audio device? >> >> > (I'd guess it doesn't.) >> >> > >> >> >> I also have the attached patch queued in via Dave's tree to disable >> >> >> MSI on all IGP chips for the time being. >> >> > >> >> > This disables MSI only for the graphics device.  I'd prefer to have >> >> > the quirk on its bridge so that MSI gets disabled for the HDMI audio >> >> > device too, to avoid having to duplicate this quirk in the snd-hda-intel >> >> > driver. >> >> > >> >> > ========== >> >> > >> >> > PCI quirk: RS780/RS880: disable MSI completely >> >> > >> >> > The missing initialization of the nb_cntl.strap_msi_enable does not seem >> >> > to be the only problem that prevents MSI, so that quirk is not >> >> > sufficient to enable MSI on all machines.  To be safe, unconditionally >> >> > disable MSI for the internal graphics and HDMI audio on these chipsets. >> >> > >> >> > Signed-off-by: Clemens Ladisch >> >> >> >> Works fine here. >> >> >> >> Tested-by: Alex Deucher >> > >> > Unfortunately it doesn't work for me without the >> > >> > if ((rdev->family >= CHIP_RV380) && >> >            (!(rdev->flags & RADEON_IS_IGP))) >> > >> > radeon quirk. >> >> what are your pci ids? > > 1022:960b > > I guess 1022 is AMD. > > OK, I'll try to add that. It's possible your oem has the wrong vendor id for the 0x9602 bridge. Alex > > Rafael > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) Date: Thu, 1 Apr 2010 17:01:11 -0400 Message-ID: References: <201004012228.06938.rjw@sisk.pl> <201004012248.38794.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201004012248.38794.rjw@sisk.pl> Sender: linux-pci-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Clemens Ladisch , Linus Torvalds , Linux PCI , Greg KH , Linux Kernel Mailing List , Jesse Barnes , dri-devel@lists.sourceforge.net, stable@kernel.org, Dave Airlie List-Id: dri-devel@lists.freedesktop.org On Thu, Apr 1, 2010 at 4:48 PM, Rafael J. Wysocki wrote: > On Thursday 01 April 2010, Alex Deucher wrote: >> On Thu, Apr 1, 2010 at 4:28 PM, Rafael J. Wysocki wrot= e: >> > On Thursday 01 April 2010, Alex Deucher wrote: >> >> On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch wrote: >> >> > Alex Deucher wrote: >> >> >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki wrote: >> >> >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: >> >> >>>> > =A0 =A0 =A0 PCI quirk: RS780/RS880: work around missing MS= I initialization >> >> >>>> >> >> >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on m= y new test box >> >> >>>> which happens to have a RS780. >> >> > >> >> > So it's better to disable MSI unconditionally. >> >> > >> >> > Rafael, can you check if MSI works for the HDMI audio device? >> >> > (I'd guess it doesn't.) >> >> > >> >> >> I also have the attached patch queued in via Dave's tree to di= sable >> >> >> MSI on all IGP chips for the time being. >> >> > >> >> > This disables MSI only for the graphics device. =A0I'd prefer t= o have >> >> > the quirk on its bridge so that MSI gets disabled for the HDMI = audio >> >> > device too, to avoid having to duplicate this quirk in the snd-= hda-intel >> >> > driver. >> >> > >> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> > >> >> > PCI quirk: RS780/RS880: disable MSI completely >> >> > >> >> > The missing initialization of the nb_cntl.strap_msi_enable does= not seem >> >> > to be the only problem that prevents MSI, so that quirk is not >> >> > sufficient to enable MSI on all machines. =A0To be safe, uncond= itionally >> >> > disable MSI for the internal graphics and HDMI audio on these c= hipsets. >> >> > >> >> > Signed-off-by: Clemens Ladisch >> >> >> >> Works fine here. >> >> >> >> Tested-by: Alex Deucher >> > >> > Unfortunately it doesn't work for me without the >> > >> > if ((rdev->family >=3D CHIP_RV380) && >> > =A0 =A0 =A0 =A0 =A0 =A0(!(rdev->flags & RADEON_IS_IGP))) >> > >> > radeon quirk. >> >> what are your pci ids? > > 1022:960b > > I guess 1022 is AMD. > > OK, I'll try to add that. It's possible your oem has the wrong vendor id for the 0x9602 bridge. Alex > > Rafael >