All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] boost: more elaborate and correct usage of GCC atomicity.
Date: Thu, 05 Nov 2009 17:41:11 +0100	[thread overview]
Message-ID: <hcuv77$uhe$1@ger.gmane.org> (raw)
In-Reply-To: <4AF2F6F0.9060606@cs.put.poznan.pl>

On 05-11-09 17:01, Przemyslaw Wesolek wrote:
> Koen Kooi wrote:
>> Your patch seems to be based on an old (as in: the day before yesterday)
>> snapshot of OE. I added a different set of patches which do almost the
>> same, but keep proper atomic ops for armv6 and armv7a, while yours would
>> fall back to emulated atomic ops for all arm platforms.
>
> Great. But I see that my change:
>
>>> diff --git a/recipes/boost/files/atomic_count_gcc_atomicity.patch
>>> b/recipes/boost/files/atomic_count_gcc_atomicity.patch
>>> index 7d08e73..3b09a8a 100644
>>> --- a/recipes/boost/files/atomic_count_gcc_atomicity.patch
>>> +++ b/recipes/boost/files/atomic_count_gcc_atomicity.patch
>>> @@ -2,12 +2,15 @@ Index: boost_1_33_1/boost/detail/atomic_count_gcc.hpp
>>>    ===================================================================
>>>    --- boost_1_33_1.orig/boost/detail/atomic_count_gcc.hpp
>>> 2008-05-01 20:43:45.000000000 +0200
>>>    +++ boost_1_33_1/boost/detail/atomic_count_gcc.hpp    2008-05-01
>>> 20:43:55.000000000 +0200
>>> -@@ -17,7 +17,7 @@
>>> +@@ -17,7 +17,11 @@
>>>     //  http://www.boost.org/LICENSE_1_0.txt)
>>>     //
>>>
>>> --#include<bits/atomicity.h>
>>> ++#if __GNUC__ * 100 + __GNUC_MINOR__>= 402
>>>    +#include<ext/atomicity.h>
>>> ++#else
>>> + #include<bits/atomicity.h>
>>> ++#endif
>>>
>>>     namespace boost
>>>     {
>
> is still applicable. Shell I post a patch for this issue separately?

Yes please :)




  reply	other threads:[~2009-11-05 16:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1256849813-10538-1-git-send-email-przemyslaw.wesolek@cs.put.poznan.pl>
2009-11-05 13:18 ` [PATCH] boost: more elaborate and correct usage of GCC atomicity Przemyslaw Wesolek
2009-11-05 15:31   ` Koen Kooi
2009-11-05 16:01     ` Przemyslaw Wesolek
2009-11-05 16:41       ` Koen Kooi [this message]
2009-11-05 19:12         ` [PATCH] boost: corrected atomicity.h include for GCC<4.2 Przemyslaw Wesolek
2009-11-08 22:37           ` Przemyslaw Wesolek
2009-11-05 14:58 ` [PATCH] boost: more elaborate and correct usage of GCC atomicity Przemyslaw Wesolek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='hcuv77$uhe$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.