All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [RESEND PATCH 07/12] iwlwifi: mvm: move early time-point before nvm_init in non-unified
Date: Fri,  5 Feb 2021 11:06:37 +0200	[thread overview]
Message-ID: <iwlwifi.20210205110447.bb6d28ceca01.I770fdf3b9b9fa555fe0935926e32cc3509d980de@changeid> (raw)
In-Reply-To: <20210205090642.1553849-1-luca@coelho.fi>

From: Luca Coelho <luciano.coelho@intel.com>

We were starting the early time-point too late in non-unified
firmwares.  Unlike with unified firmwares, we were starting it only
after reading the NVM, so errors in the NVM read phase were not
logged.

Solve this by moving the time-point to the same place as we do with
unified firmwares, i.e. just before we go into the wait-alive code.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 0637eb1cff4e..be1cc8653147 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -633,6 +633,8 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm)
 				   iwl_wait_phy_db_entry,
 				   mvm->phy_db);
 
+	iwl_dbg_tlv_time_point(&mvm->fwrt, IWL_FW_INI_TIME_POINT_EARLY, NULL);
+
 	/* Will also start the device */
 	ret = iwl_mvm_load_ucode_wait_alive(mvm, IWL_UCODE_INIT);
 	if (ret) {
@@ -1312,8 +1314,6 @@ static int iwl_mvm_load_rt_fw(struct iwl_mvm *mvm)
 	if (ret)
 		return ret;
 
-	iwl_dbg_tlv_time_point(&mvm->fwrt, IWL_FW_INI_TIME_POINT_EARLY, NULL);
-
 	mvm->rfkill_safe_init_done = false;
 	ret = iwl_mvm_load_ucode_wait_alive(mvm, IWL_UCODE_REGULAR);
 	if (ret)
-- 
2.30.0


  parent reply	other threads:[~2021-02-05  9:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  9:06 [RESEND PATCH 00/12] iwlwifi: updates intended for v5.12 2021-01-31 Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 01/12] iwlwifi: mvm: advertise BIGTK client support if available Luca Coelho
2021-02-05  9:57   ` Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 02/12] iwlwifi: bump FW API to 60 for AX devices Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 03/12] iwlwifi: fw api: make hdr a zero-size array again Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 04/12] iwlwifi: mvm: slightly clean up rs_fw_set_supp_rates() Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 05/12] iwlwifi: move SnJ and So rules to the new tables Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 06/12] iwlwifi: add support for SnJ with Jf devices Luca Coelho
2021-02-05  9:06 ` Luca Coelho [this message]
2021-02-05  9:06 ` [RESEND PATCH 08/12] iwlwifi: pcie: add support for SnJ with Hr1 Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 09/12] iwlwifi: mvm: cancel the scan delayed work when scan is aborted Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 10/12] iwlwifi: pcie: Disable softirqs during Rx queue init Luca Coelho
2021-02-05 10:00   ` Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 11/12] iwlwifi: mvm: make iwl_mvm_tt_temp_changed() static Luca Coelho
2021-02-05  9:06 ` [RESEND PATCH 12/12] iwlwifi: mvm: fix CSA AP side Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20210205110447.bb6d28ceca01.I770fdf3b9b9fa555fe0935926e32cc3509d980de@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.