All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 01/12] iwlwifi: mvm: write queue_sync_state only for sync
Date: Wed, 31 Mar 2021 12:14:41 +0300	[thread overview]
Message-ID: <iwlwifi.20210331121101.d11c9bcdb4aa.I0772171dbaec87433a11513e9586d98b5d920b5f@changeid> (raw)
In-Reply-To: <20210331091452.543321-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

We use mvm->queue_sync_state to wait for synchronous queue sync
messages, but if an async one happens inbetween we shouldn't
clear mvm->queue_sync_state after sending the async one, that
can run concurrently (at least from the CPU POV) with another
synchronous queue sync.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 9ed6e2783cc4..fbd37a19b6e0 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -5177,9 +5177,10 @@ void iwl_mvm_sync_rx_queues_internal(struct iwl_mvm *mvm,
 	}
 
 out:
-	mvm->queue_sync_state = 0;
-	if (notif->sync)
+	if (notif->sync) {
+		mvm->queue_sync_state = 0;
 		mvm->queue_sync_cookie++;
+	}
 }
 
 static void iwl_mvm_sync_rx_queues(struct ieee80211_hw *hw)
-- 
2.31.0


  reply	other threads:[~2021-03-31  9:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  9:14 [PATCH 00/12] iwlwifi: updates intended for v5.13 2021-03-31 Luca Coelho
2021-03-31  9:14 ` Luca Coelho [this message]
2021-04-12 10:24   ` [PATCH 01/12] iwlwifi: mvm: write queue_sync_state only for sync Luca Coelho
2021-03-31  9:14 ` [PATCH 02/12] iwlwifi: mvm: clean up queue sync implementation Luca Coelho
2021-03-31  9:14 ` [PATCH 03/12] iwlwifi: mvm: when associated with PMF, use protected NDP ranging negotiation Luca Coelho
2021-03-31  9:14 ` [PATCH 04/12] iwlwifi: add ax201 killer device Luca Coelho
2021-03-31  9:14 ` [PATCH 05/12] iwlwifi: pcie: try to grab NIC access early Luca Coelho
2021-04-12 10:22   ` Luca Coelho
2021-03-31  9:14 ` [PATCH 06/12] iwlwifi: mvm: Add support for 6GHz passive scan Luca Coelho
2021-03-31 12:03   ` Ben Greear
2021-04-11  9:41     ` Luca Coelho
2021-04-11 10:14     ` Peer, Ilan
2021-04-11 11:16       ` Ben Greear
2021-04-11 12:14         ` Peer, Ilan
2021-04-11 16:15           ` Ben Greear
2021-04-13 12:49             ` Peer, Ilan
2021-03-31  9:14 ` [PATCH 07/12] iwlwifi: mvm: enable PPAG in China Luca Coelho
2021-03-31  9:14 ` [PATCH 08/12] iwlwifi: add new so-gf device Luca Coelho
2021-03-31  9:14 ` [PATCH 09/12] iwlwifi: move iwl_configure_rxq to be used by other op_modes Luca Coelho
2021-03-31  9:14 ` [PATCH 10/12] iwlwifi: mvm: support BIOS enable/disable for 11ax in Ukraine Luca Coelho
2021-03-31  9:14 ` [PATCH 11/12] iwlwifi: mvm: refactor ACPI DSM evaluation function Luca Coelho
2021-03-31  9:14 ` [PATCH 12/12] iwlwifi: mvm: Use IWL_INFO in fw_reset_handshake() Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20210331121101.d11c9bcdb4aa.I0772171dbaec87433a11513e9586d98b5d920b5f@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.