All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: luca@coelho.fi, linux-wireless@vger.kernel.org
Subject: [PATCH 02/10] iwlwifi: mvm: disable RX-diversity in powersave
Date: Sun, 17 Oct 2021 11:43:40 +0300	[thread overview]
Message-ID: <iwlwifi.20211017113927.fc896bc5cdaa.I1d11da71b8a5cbe921a37058d5f578f1b14a2023@changeid> (raw)
In-Reply-To: <20211017084348.401570-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

Just like we have default SMPS mode as dynamic in powersave,
we should not enable RX-diversity in powersave, to reduce
power consumption when connected to a non-MIMO AP.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c b/drivers/net/wireless/intel/iwlwifi/mvm/utils.c
index 4a3d2971a98b..ec8a223f90e8 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/utils.c
@@ -405,6 +405,9 @@ bool iwl_mvm_rx_diversity_allowed(struct iwl_mvm *mvm,
 
 	lockdep_assert_held(&mvm->mutex);
 
+	if (iwlmvm_mod_params.power_scheme != IWL_POWER_SCHEME_CAM)
+		return false;
+
 	if (num_of_ant(iwl_mvm_get_valid_rx_ant(mvm)) == 1)
 		return false;
 
-- 
2.33.0


  parent reply	other threads:[~2021-10-17  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17  8:43 [PATCH 00/10] iwlwifi: updates intended for v5.16 2021-10-17 Luca Coelho
2021-10-17  8:43 ` [PATCH 01/10] iwlwifi: mvm: fix ieee80211_get_he_iftype_cap() iftype Luca Coelho
2021-10-22  7:50   ` Luca Coelho
2021-10-17  8:43 ` Luca Coelho [this message]
2021-10-17  8:43 ` [PATCH 03/10] iwlwifi: mvm: add lmac/umac PC info in case of error Luca Coelho
2021-10-17  8:43 ` [PATCH 04/10] iwlwifi: add vendor specific capabilities for some RFs Luca Coelho
2021-10-17  8:43 ` [PATCH 05/10] iwlwifi: mvm: add support for 160Mhz in ranging measurements Luca Coelho
2021-10-17  8:43 ` [PATCH 06/10] iwlwifi: mvm: Remove antenna c references Luca Coelho
2021-10-17  8:43 ` [PATCH 07/10] iwlwifi: add some missing kernel-doc in struct iwl_fw Luca Coelho
2021-10-17  8:43 ` [PATCH 08/10] iwlwifi: api: remove unused RX status bits Luca Coelho
2021-10-17  8:43 ` [PATCH 09/10] iwlwifi: remove MODULE_AUTHOR() statements Luca Coelho
2021-10-17  8:43 ` [PATCH 10/10] iwlwifi: remove contact information Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20211017113927.fc896bc5cdaa.I1d11da71b8a5cbe921a37058d5f578f1b14a2023@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.