From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4559CC433E0 for ; Tue, 19 Jan 2021 10:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB48D23133 for ; Tue, 19 Jan 2021 10:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404336AbhASKew (ORCPT ); Tue, 19 Jan 2021 05:34:52 -0500 Received: from mail-40136.protonmail.ch ([185.70.40.136]:62109 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390430AbhASKXI (ORCPT ); Tue, 19 Jan 2021 05:23:08 -0500 Date: Tue, 19 Jan 2021 10:22:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1611051746; bh=vtNRLA5CE3I6wcgKrfTHuSBUc+uTmwDqtUGt5ElNsPU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=fCKI5HfShsUoM4GF9DEiDYOMlZ/uRKpa98tcc4F3MwCi5CAGkUrK3Q2lsKW/HyolT DOF8mTyfFwjtWD/Pl+P7U2SIZbp5Z3d5avlBC1ys6SNWhOluCVb+Q3SHhM3g361gBm xc1AkQwNuMa1ELxxffG3eZ9oN7LdqZuR9dq1/0gydrrCLPXMQgJHwZxU8TVplS+9VA U6UCoO6izgl5Rt4Hb4rweU8cbOXfdzP2ljcem/VV9ajDuwSRrX+hxMax1UIgGr08Y5 xBVM56MRCWj+OGAZ/cxm2/4BCRVgowBiaxmYgMaRI0ZAbnT6SYAolFVhvCSxd0IZkF g9rPT9hQzAq3Q== To: Lyude Paul From: Simon Ser Cc: nouveau@lists.freedesktop.org, Martin Peres , Jeremy Cline , Ben Skeggs , David Airlie , Daniel Vetter , Dave Airlie , Pankaj Bharadiya , Takashi Iwai , James Jones , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Reply-To: Simon Ser Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Message-ID: In-Reply-To: <20210119015415.2511028-2-lyude@redhat.com> References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul wr= ote: > Cc: Martin Peres > Cc: Jeremy Cline > Cc: Simon Ser > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/no= uveau/dispnv50/disp.c > index c6367035970e..5f4f09a601d4 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > =09else > =09=09nouveau_display(dev)->format_modifiers =3D disp50xx_modifiers; > > +=09if (disp->disp->object.oclass >=3D GK104_DISP) { I can confirm this works fine on GK208B. Tested with wlroots. I don't have older cards to test, though. Tested-by: Simon Ser > +=09=09dev->mode_config.cursor_width =3D 256; > +=09=09dev->mode_config.cursor_height =3D 256; > +=09} else { > +=09=09dev->mode_config.cursor_width =3D 64; > +=09=09dev->mode_config.cursor_height =3D 64; > +=09} > + > =09/* create crtc objects to represent the hw heads */ > =09if (disp->disp->object.oclass >=3D GV100_DISP) > =09=09crtcs =3D nvif_rd32(&device->object, 0x610060) & 0xff; > -- > 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Ser Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Date: Tue, 19 Jan 2021 10:22:15 +0000 Message-ID: References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> Reply-To: Simon Ser Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20210119015415.2511028-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Lyude Paul Cc: David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Takashi Iwai , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ben Skeggs , Daniel Vetter , Pankaj Bharadiya , Dave Airlie List-Id: nouveau.vger.kernel.org On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul wrote: > Cc: Martin Peres > Cc: Jeremy Cline > Cc: Simon Ser > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index c6367035970e..5f4f09a601d4 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > else > nouveau_display(dev)->format_modifiers = disp50xx_modifiers; > > + if (disp->disp->object.oclass >= GK104_DISP) { I can confirm this works fine on GK208B. Tested with wlroots. I don't have older cards to test, though. Tested-by: Simon Ser > + dev->mode_config.cursor_width = 256; > + dev->mode_config.cursor_height = 256; > + } else { > + dev->mode_config.cursor_width = 64; > + dev->mode_config.cursor_height = 64; > + } > + > /* create crtc objects to represent the hw heads */ > if (disp->disp->object.oclass >= GV100_DISP) > crtcs = nvif_rd32(&device->object, 0x610060) & 0xff; > -- > 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D66C433DB for ; Tue, 19 Jan 2021 10:22:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94DC423117 for ; Tue, 19 Jan 2021 10:22:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94DC423117 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9120F6E0EA; Tue, 19 Jan 2021 10:22:29 +0000 (UTC) Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by gabe.freedesktop.org (Postfix) with ESMTPS id 104B16E0EA for ; Tue, 19 Jan 2021 10:22:28 +0000 (UTC) Date: Tue, 19 Jan 2021 10:22:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1611051746; bh=vtNRLA5CE3I6wcgKrfTHuSBUc+uTmwDqtUGt5ElNsPU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=fCKI5HfShsUoM4GF9DEiDYOMlZ/uRKpa98tcc4F3MwCi5CAGkUrK3Q2lsKW/HyolT DOF8mTyfFwjtWD/Pl+P7U2SIZbp5Z3d5avlBC1ys6SNWhOluCVb+Q3SHhM3g361gBm xc1AkQwNuMa1ELxxffG3eZ9oN7LdqZuR9dq1/0gydrrCLPXMQgJHwZxU8TVplS+9VA U6UCoO6izgl5Rt4Hb4rweU8cbOXfdzP2ljcem/VV9ajDuwSRrX+hxMax1UIgGr08Y5 xBVM56MRCWj+OGAZ/cxm2/4BCRVgowBiaxmYgMaRI0ZAbnT6SYAolFVhvCSxd0IZkF g9rPT9hQzAq3Q== To: Lyude Paul From: Simon Ser Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Message-ID: In-Reply-To: <20210119015415.2511028-2-lyude@redhat.com> References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: David Airlie , nouveau@lists.freedesktop.org, James Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jeremy Cline , Ben Skeggs , Pankaj Bharadiya , Dave Airlie Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul wrote: > Cc: Martin Peres > Cc: Jeremy Cline > Cc: Simon Ser > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index c6367035970e..5f4f09a601d4 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev) > else > nouveau_display(dev)->format_modifiers = disp50xx_modifiers; > > + if (disp->disp->object.oclass >= GK104_DISP) { I can confirm this works fine on GK208B. Tested with wlroots. I don't have older cards to test, though. Tested-by: Simon Ser > + dev->mode_config.cursor_width = 256; > + dev->mode_config.cursor_height = 256; > + } else { > + dev->mode_config.cursor_width = 64; > + dev->mode_config.cursor_height = 64; > + } > + > /* create crtc objects to represent the hw heads */ > if (disp->disp->object.oclass >= GV100_DISP) > crtcs = nvif_rd32(&device->object, 0x610060) & 0xff; > -- > 2.29.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel