* [PATCH] drm/dp: follow DP link CTS spec to read link status back
@ 2021-07-07 15:00 Lee Shawn C
2021-07-07 15:05 ` Simon Ser
2021-07-07 15:33 ` [PATCH v2] " Lee Shawn C
0 siblings, 2 replies; 8+ messages in thread
From: Lee Shawn C @ 2021-07-07 15:00 UTC (permalink / raw)
To: dri-devel; +Cc: Cooper Chiou, William Tseng, Jani Nikula, Lee Shawn C
Refer to DP link CTS 1.2/1.4 spec, the following test case request
source read DPCD 200h - 205h to get latest link status from sink.
(4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
(400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
Due to Loss of Symbol Lock: HBR2 Extension
(400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
to Loss of Clock Recovery Lock: HBR2 Extension
(400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
to Loss of Inter-lane Alignment Lock: HBR2 Extension
So far, DRM DP driver just read back the link status from 202h
to 207h. DPR-120 would judge source can't pass these cases and
shows below error messages.
"Test FAILED, Source DUT does not read DPCD registers 200h-205h
within 100 ms".
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 24bbc710c825..2b4d1f498ce3 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
u8 link_status[DP_LINK_STATUS_SIZE])
{
int ret;
+ u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
if (dp_phy == DP_PHY_DPRX) {
ret = drm_dp_dpcd_read(aux,
- DP_LANE0_1_STATUS,
- link_status,
- DP_LINK_STATUS_SIZE);
+ DP_SINK_COUNT,
+ full_link_stat,
+ DP_LINK_STATUS_SIZE + 2);
if (ret < 0)
return ret;
- WARN_ON(ret != DP_LINK_STATUS_SIZE);
+ memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
+ WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/dp: follow DP link CTS spec to read link status back
2021-07-07 15:00 [PATCH] drm/dp: follow DP link CTS spec to read link status back Lee Shawn C
@ 2021-07-07 15:05 ` Simon Ser
2021-07-07 15:14 ` Lee, Shawn C
2021-07-07 15:33 ` [PATCH v2] " Lee Shawn C
1 sibling, 1 reply; 8+ messages in thread
From: Simon Ser @ 2021-07-07 15:05 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Jani Nikula, Cooper Chiou, William Tseng, dri-devel
> + DP_LINK_STATUS_SIZE + 2);
Suggestion: use sizeof(full_link_stat) here instead to avoid this
getting out-of-sync with the real array size?
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/dp: follow DP link CTS spec to read link status back
2021-07-07 15:05 ` Simon Ser
@ 2021-07-07 15:14 ` Lee, Shawn C
0 siblings, 0 replies; 8+ messages in thread
From: Lee, Shawn C @ 2021-07-07 15:14 UTC (permalink / raw)
To: Simon Ser; +Cc: Nikula, Jani, Chiou, Cooper, Tseng, William, dri-devel
On Wed, July 7, 2021, 3:05 p.m., Simon Ser <contact@emersion.fr> wrote:
>> + DP_LINK_STATUS_SIZE + 2);
>
>Suggestion: use sizeof(full_link_stat) here instead to avoid this getting out-of-sync with the real array size?
>
I will update v2 patch later. Thanks for comment!
Best regards,
Shawn
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drm/dp: follow DP link CTS spec to read link status back
2021-07-07 15:00 [PATCH] drm/dp: follow DP link CTS spec to read link status back Lee Shawn C
2021-07-07 15:05 ` Simon Ser
@ 2021-07-07 15:33 ` Lee Shawn C
2021-07-07 16:14 ` Jani Nikula
1 sibling, 1 reply; 8+ messages in thread
From: Lee Shawn C @ 2021-07-07 15:33 UTC (permalink / raw)
To: dri-devel; +Cc: Cooper Chiou, William Tseng, Jani Nikula, Lee Shawn C
Refer to DP link CTS 1.2/1.4 spec, the following test case request
source read DPCD 200h - 205h to get latest link status from sink.
(4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
(400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
Due to Loss of Symbol Lock: HBR2 Extension
(400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
to Loss of Clock Recovery Lock: HBR2 Extension
(400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
to Loss of Inter-lane Alignment Lock: HBR2 Extension
So far, DRM DP driver just read back the link status from 202h
to 207h. DPR-120 would judge source can't pass these cases and
shows below error messages.
"Test FAILED, Source DUT does not read DPCD registers 200h-205h
within 100 ms".
v2: Use sizeof() to retrieve array size.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Simon Ser <contact@emersion.fr>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 24bbc710c825..4f03df317d62 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
u8 link_status[DP_LINK_STATUS_SIZE])
{
int ret;
+ u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
if (dp_phy == DP_PHY_DPRX) {
ret = drm_dp_dpcd_read(aux,
- DP_LANE0_1_STATUS,
- link_status,
- DP_LINK_STATUS_SIZE);
+ DP_SINK_COUNT,
+ full_link_stat,
+ sizeof(full_link_stat));
if (ret < 0)
return ret;
- WARN_ON(ret != DP_LINK_STATUS_SIZE);
+ memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
+ WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/dp: follow DP link CTS spec to read link status back
2021-07-07 15:33 ` [PATCH v2] " Lee Shawn C
@ 2021-07-07 16:14 ` Jani Nikula
2021-07-08 3:04 ` Lee, Shawn C
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2021-07-07 16:14 UTC (permalink / raw)
To: Lee Shawn C, dri-devel; +Cc: Cooper Chiou, William Tseng, Lee Shawn C
On Wed, 07 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> Refer to DP link CTS 1.2/1.4 spec, the following test case request
> source read DPCD 200h - 205h to get latest link status from sink.
>
> (4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
> (400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
> Due to Loss of Symbol Lock: HBR2 Extension
> (400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
> to Loss of Clock Recovery Lock: HBR2 Extension
> (400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
> to Loss of Inter-lane Alignment Lock: HBR2 Extension
>
> So far, DRM DP driver just read back the link status from 202h
> to 207h. DPR-120 would judge source can't pass these cases and
> shows below error messages.
>
> "Test FAILED, Source DUT does not read DPCD registers 200h-205h
> within 100 ms".
Acked-by: Jani Nikula <jani.nikula@intel.com>
for making the test pass iff everything else seems to work.
The underlying question is, though, should we look at 0x200-0x201 for
some status we don't look at?
>
> v2: Use sizeof() to retrieve array size.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Simon Ser <contact@emersion.fr>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: William Tseng <william.tseng@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 24bbc710c825..4f03df317d62 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
> u8 link_status[DP_LINK_STATUS_SIZE])
> {
> int ret;
> + u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
>
> if (dp_phy == DP_PHY_DPRX) {
> ret = drm_dp_dpcd_read(aux,
> - DP_LANE0_1_STATUS,
> - link_status,
> - DP_LINK_STATUS_SIZE);
> + DP_SINK_COUNT,
> + full_link_stat,
> + sizeof(full_link_stat));
>
> if (ret < 0)
> return ret;
>
> - WARN_ON(ret != DP_LINK_STATUS_SIZE);
> + memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
> + WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
>
> return 0;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] drm/dp: follow DP link CTS spec to read link status back
2021-07-07 16:14 ` Jani Nikula
@ 2021-07-08 3:04 ` Lee, Shawn C
2021-07-12 14:16 ` Lee, Shawn C
0 siblings, 1 reply; 8+ messages in thread
From: Lee, Shawn C @ 2021-07-08 3:04 UTC (permalink / raw)
To: Nikula, Jani, dri-devel; +Cc: Tseng, William, Chiou, Cooper
On Wed, 07 Jul 2021, 4:14 p.m, Jani Nikula <jani.nikula@intel.com> wrote:
>On Wed, 07 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> Refer to DP link CTS 1.2/1.4 spec, the following test case request
>> source read DPCD 200h - 205h to get latest link status from sink.
>>
>> (4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
>> (400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
>> Due to Loss of Symbol Lock: HBR2 Extension
>> (400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
>> to Loss of Clock Recovery Lock: HBR2 Extension
>> (400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
>> to Loss of Inter-lane Alignment Lock: HBR2 Extension
>>
>> So far, DRM DP driver just read back the link status from 202h to
>> 207h. DPR-120 would judge source can't pass these cases and shows
>> below error messages.
>>
>> "Test FAILED, Source DUT does not read DPCD registers 200h-205h within
>> 100 ms".
>
>Acked-by: Jani Nikula <jani.nikula@intel.com>
>
>for making the test pass iff everything else seems to work.
>
>The underlying question is, though, should we look at 0x200-0x201 for some status we don't look at?
>
Look into 200h. While doing link train with DPRX. In my opinion, sink_count and cp_ready status should be constant.
And sink would trigger HPD to source to notify 201h value was changed. Seems source driver don't need this value
at link training stage as well. What do you think?
Best regards,
Shawn
>
>>
>> v2: Use sizeof() to retrieve array size.
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Lyude Paul <lyude@redhat.com>
>> Cc: Simon Ser <contact@emersion.fr>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Cc: William Tseng <william.tseng@intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_dp_helper.c
>> b/drivers/gpu/drm/drm_dp_helper.c index 24bbc710c825..4f03df317d62
>> 100644
>> --- a/drivers/gpu/drm/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>> @@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
>> u8 link_status[DP_LINK_STATUS_SIZE]) {
>> int ret;
>> + u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
>>
>> if (dp_phy == DP_PHY_DPRX) {
>> ret = drm_dp_dpcd_read(aux,
>> - DP_LANE0_1_STATUS,
>> - link_status,
>> - DP_LINK_STATUS_SIZE);
>> + DP_SINK_COUNT,
>> + full_link_stat,
>> + sizeof(full_link_stat));
>>
>> if (ret < 0)
>> return ret;
>>
>> - WARN_ON(ret != DP_LINK_STATUS_SIZE);
>> + memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
>> + WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
>>
>> return 0;
>> }
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] drm/dp: follow DP link CTS spec to read link status back
2021-07-08 3:04 ` Lee, Shawn C
@ 2021-07-12 14:16 ` Lee, Shawn C
2021-08-19 7:55 ` Lee, Shawn C
0 siblings, 1 reply; 8+ messages in thread
From: Lee, Shawn C @ 2021-07-12 14:16 UTC (permalink / raw)
To: 20210707153318.13903-1-shawn.c.lee, Nikula, Jani, dri-devel
Cc: Tseng, William, Chiou, Cooper
On Wed, 08 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>On Wed, 07 Jul 2021, 4:14 p.m, Jani Nikula <jani.nikula@intel.com> wrote:
>>On Wed, 07 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>> Refer to DP link CTS 1.2/1.4 spec, the following test case request
>>> source read DPCD 200h - 205h to get latest link status from sink.
>>>
>>> (4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
>>> (400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
>>> Due to Loss of Symbol Lock: HBR2 Extension
>>> (400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
>>> to Loss of Clock Recovery Lock: HBR2 Extension
>>> (400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
>>> to Loss of Inter-lane Alignment Lock: HBR2 Extension
>>>
>>> So far, DRM DP driver just read back the link status from 202h to
>>> 207h. DPR-120 would judge source can't pass these cases and shows
>>> below error messages.
>>>
>>> "Test FAILED, Source DUT does not read DPCD registers 200h-205h
>>> within
>>> 100 ms".
>>
>>Acked-by: Jani Nikula <jani.nikula@intel.com>
>>
>>for making the test pass iff everything else seems to work.
>>
>>The underlying question is, though, should we look at 0x200-0x201 for some status we don't look at?
>>
>
>Look into 200h. While doing link train with DPRX. In my opinion, sink_count and cp_ready status should be constant.
>And sink would trigger HPD to source to notify 201h value was changed. Seems source driver don't need this value at link training stage as well. What do you think?
>
>Best regards,
>Shawn
>
Hi Simon and all,
Please share your recommendations for this patch to pass DP link layer compliance test. Thanks!
Best regards,
Shawn
>>
>>>
>>> v2: Use sizeof() to retrieve array size.
>>>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Cc: Lyude Paul <lyude@redhat.com>
>>> Cc: Simon Ser <contact@emersion.fr>
>>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>> Cc: William Tseng <william.tseng@intel.com>
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>> ---
>>> drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
>>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c
>>> b/drivers/gpu/drm/drm_dp_helper.c index 24bbc710c825..4f03df317d62
>>> 100644
>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>> @@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
>>> u8 link_status[DP_LINK_STATUS_SIZE]) {
>>> int ret;
>>> + u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
>>>
>>> if (dp_phy == DP_PHY_DPRX) {
>>> ret = drm_dp_dpcd_read(aux,
>>> - DP_LANE0_1_STATUS,
>>> - link_status,
>>> - DP_LINK_STATUS_SIZE);
>>> + DP_SINK_COUNT,
>>> + full_link_stat,
>>> + sizeof(full_link_stat));
>>>
>>> if (ret < 0)
>>> return ret;
>>>
>>> - WARN_ON(ret != DP_LINK_STATUS_SIZE);
>>> + memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
>>> + WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
>>>
>>> return 0;
>>> }
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] drm/dp: follow DP link CTS spec to read link status back
2021-07-12 14:16 ` Lee, Shawn C
@ 2021-08-19 7:55 ` Lee, Shawn C
0 siblings, 0 replies; 8+ messages in thread
From: Lee, Shawn C @ 2021-08-19 7:55 UTC (permalink / raw)
To: 20210707153318.13903-1-shawn.c.lee, Nikula, Jani, dri-devel
Cc: Ville Syrjälä,
Lyude Paul, Simon Ser, Chiou, Cooper, Tseng, William
On Wed, 08 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>On Wed, 07 Jul 2021, 4:14 p.m, Jani Nikula <jani.nikula@intel.com> wrote:
>>On Wed, 07 Jul 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>>> Refer to DP link CTS 1.2/1.4 spec, the following test case request
>>> source read DPCD 200h - 205h to get latest link status from sink.
>>>
>>> (4.3.2.4) Handling of IRQ HPD Pulse with No Error Status Bits Set
>>> (400.3.2.1) Successful Link Re-training After IRQ HPD Pulse
>>> Due to Loss of Symbol Lock: HBR2 Extension
>>> (400.3.2.2) Successful Link Re-training After IRQ HPD Pulse Due
>>> to Loss of Clock Recovery Lock: HBR2 Extension
>>> (400.3.2.3) Successful Link Re-training After IRQ HPD Pulse Due
>>> to Loss of Inter-lane Alignment Lock: HBR2 Extension
>>>
>>> So far, DRM DP driver just read back the link status from 202h to
>>> 207h. DPR-120 would judge source can't pass these cases and shows
>>> below error messages.
>>>
>>> "Test FAILED, Source DUT does not read DPCD registers 200h-205h
>>> within
>>> 100 ms".
>>
>>Acked-by: Jani Nikula <jani.nikula@intel.com>
>>
>>for making the test pass iff everything else seems to work.
>>
>>The underlying question is, though, should we look at 0x200-0x201 for some status we don't look at?
>>
>
>Look into 200h. While doing link train with DPRX. In my opinion, sink_count and cp_ready status should be constant.
>And sink would trigger HPD to source to notify 201h value was changed. Seems source driver don't need this value at link training stage as well. What do you think?
>
>Best regards,
>Shawn
>
Hi Simon and all,
Please share your recommendations for this patch to pass DP link layer compliance test. Thanks!
Best regards,
Shawn
>>
>>>
>>> v2: Use sizeof() to retrieve array size.
>>>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Cc: Lyude Paul <lyude@redhat.com>
>>> Cc: Simon Ser <contact@emersion.fr>
>>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>>> Cc: William Tseng <william.tseng@intel.com>
>>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>>> ---
>>> drivers/gpu/drm/drm_dp_helper.c | 10 ++++++----
>>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c
>>> b/drivers/gpu/drm/drm_dp_helper.c index 24bbc710c825..4f03df317d62
>>> 100644
>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>> @@ -410,17 +410,19 @@ int drm_dp_dpcd_read_phy_link_status(struct drm_dp_aux *aux,
>>> u8 link_status[DP_LINK_STATUS_SIZE]) {
>>> int ret;
>>> + u8 full_link_stat[DP_LINK_STATUS_SIZE + 2];
>>>
>>> if (dp_phy == DP_PHY_DPRX) {
>>> ret = drm_dp_dpcd_read(aux,
>>> - DP_LANE0_1_STATUS,
>>> - link_status,
>>> - DP_LINK_STATUS_SIZE);
>>> + DP_SINK_COUNT,
>>> + full_link_stat,
>>> + sizeof(full_link_stat));
>>>
>>> if (ret < 0)
>>> return ret;
>>>
>>> - WARN_ON(ret != DP_LINK_STATUS_SIZE);
>>> + memcpy(link_status, full_link_stat + 2, DP_LINK_STATUS_SIZE);
>>> + WARN_ON(ret != DP_LINK_STATUS_SIZE + 2);
>>>
>>> return 0;
>>> }
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-19 7:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 15:00 [PATCH] drm/dp: follow DP link CTS spec to read link status back Lee Shawn C
2021-07-07 15:05 ` Simon Ser
2021-07-07 15:14 ` Lee, Shawn C
2021-07-07 15:33 ` [PATCH v2] " Lee Shawn C
2021-07-07 16:14 ` Jani Nikula
2021-07-08 3:04 ` Lee, Shawn C
2021-07-12 14:16 ` Lee, Shawn C
2021-08-19 7:55 ` Lee, Shawn C
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.