From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855AEC433E1 for ; Sat, 15 Aug 2020 22:09:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE827205CB for ; Sat, 15 Aug 2020 22:09:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="Zcmp4H5t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727994AbgHOWJ3 (ORCPT ); Sat, 15 Aug 2020 18:09:29 -0400 Received: from mail-40140.protonmail.ch ([185.70.40.140]:62754 "EHLO mail-40140.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbgHOWJ3 (ORCPT ); Sat, 15 Aug 2020 18:09:29 -0400 Date: Sat, 15 Aug 2020 20:52:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1597524737; bh=c178NIdPZpX6rfti//8ogP9BIPmC2WbIfidS1RAMLtg=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Zcmp4H5tcGu5B+T2JtLHMD4r9imIrii0Chu2SD7jNgnVvRaYgcHSc30qg24UeizJ6 suWuoN0kC7jq5+u8IfzBkX5b6qhUYJzDglTKw8pEViZhsZU/XPzDJJW/URrfYGhhIA qB7d6TQx4WrNrh4k7nGZNO4dyYjwh7aV6UWAX0Io= To: jaap aarts From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jean Delvare , Guenter Roeck , "linux-hwmon@vger.kernel.org" , "linux-usb@vger.kernel.org" Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH V3] hwmon: add fan/pwm driver for corsair h100i platinum Message-ID: In-Reply-To: References: <20200814194202.327141-1-jaap.aarts1@gmail.com> <4hk1tR-p2Dc2UbnNVCvFg4AJsucTKOwY0-Kc934bQ8VJSIhiTm-iw1qb03jNb9mGDBqWhXwlnzwB6vxKNLZf6Sv7ozKSigS9IHInXizzmE0=@protonmail.com> <92GG6DNvh8x8K43ZGnot6ASLNHBD7l6R6RiI-4jv-Lfki4_tM3IJxPYbp-xajRqMV84Nyw4sp3hZft36ulU2QnxCyhf52kEr6OYe9iujBTk=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org I don't recall ever asking about sizes. I said in my previous email that I meant "type", not "size". 'bulk_out_buffer' was 'unsigned char*', but 'bulk_in_buffer' was 'char*' in the patch. That's what I referred to. 2020. augusztus 15., szombat 22:44 keltez=C3=A9ssel, jaap aarts =C3=ADrta: > sorry forgot to reply to the question about the buffer sizes. > The reason they are different sizes (in theory) is because > I get the size for each buffer from usb_endpoint_maxp. > I do not know whether or not these are the same. If you have > any experience with these functions and know they are always > the same I am willing to make them the same size. > > [...]