From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF8AC2D0E4 for ; Thu, 19 Nov 2020 11:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74B0B24706 for ; Thu, 19 Nov 2020 11:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbgKSL1u (ORCPT ); Thu, 19 Nov 2020 06:27:50 -0500 Received: from foss.arm.com ([217.140.110.172]:53904 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgKSL1t (ORCPT ); Thu, 19 Nov 2020 06:27:49 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66A571396; Thu, 19 Nov 2020 03:27:49 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12E593F718; Thu, 19 Nov 2020 03:27:46 -0800 (PST) References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-3-will@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , kernel-team@android.com Subject: Re: [PATCH v3 02/14] arm64: Allow mismatched 32-bit EL0 support In-reply-to: <20201113093720.21106-3-will@kernel.org> Date: Thu, 19 Nov 2020 11:27:41 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/11/20 09:37, Will Deacon wrote: > +const struct cpumask *system_32bit_el0_cpumask(void) > +{ > + if (!system_supports_32bit_el0()) > + return cpu_none_mask; > + > + if (static_branch_unlikely(&arm64_mismatched_32bit_el0)) > + return cpu_32bit_el0_mask; > + > + return cpu_present_mask; > +} Nit: this is used in patch 13 to implement arch_cpu_allowed_mask(). Since that latter defaults to cpu_possible_mask, this probably should too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4302C2D0E4 for ; Thu, 19 Nov 2020 11:29:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E667246EE for ; Thu, 19 Nov 2020 11:29:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MECGqpVP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E667246EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ON9KFUqCyun4MEqWtqsDD9lsR8Gfez0w2hSUXt+ZA1M=; b=MECGqpVPmxCeGF++PS6Lat9MJ OGxxnO63yCBIuMz6PIEMfeh5dxOS59ej4mauvoXwqUklDOvRVufUo4tfKSMy0q4YPRyk8w/ILayVq 9i1gmf+2vagO2epbbJh/e3gZTDdKWt2lgz3Rct7I83ZcYNkQvCSdzioyOOaDf929sbsJ6BbD7/VAz W8+ODhtsFB2ly5oJxADQ5bq/NnWBN39kqwpKjWFuUvcWn+g/90/9DA2XhK2+IOw7h2RwFvsSyez31 71UeCU1RcX2hCs80ThaBE9B6NvFXfjc6cL4fzjrO8Skm+T8aneV9KelWtdF1x/HXfdF3lSfobhAF5 qD26oZ6Ng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfi6S-0006yO-VD; Thu, 19 Nov 2020 11:27:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfi6Q-0006xm-8N for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 11:27:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66A571396; Thu, 19 Nov 2020 03:27:49 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12E593F718; Thu, 19 Nov 2020 03:27:46 -0800 (PST) References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-3-will@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Will Deacon Subject: Re: [PATCH v3 02/14] arm64: Allow mismatched 32-bit EL0 support In-reply-to: <20201113093720.21106-3-will@kernel.org> Date: Thu, 19 Nov 2020 11:27:41 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_062750_509412_586A05F3 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Marc Zyngier , kernel-team@android.com, Vincent Guittot , Juri Lelli , Quentin Perret , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Ingo Molnar , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/11/20 09:37, Will Deacon wrote: > +const struct cpumask *system_32bit_el0_cpumask(void) > +{ > + if (!system_supports_32bit_el0()) > + return cpu_none_mask; > + > + if (static_branch_unlikely(&arm64_mismatched_32bit_el0)) > + return cpu_32bit_el0_mask; > + > + return cpu_present_mask; > +} Nit: this is used in patch 13 to implement arch_cpu_allowed_mask(). Since that latter defaults to cpu_possible_mask, this probably should too. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel