From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBCBC433E0 for ; Fri, 26 Jun 2020 23:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2FE92073E for ; Fri, 26 Jun 2020 23:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbgFZXPs (ORCPT ); Fri, 26 Jun 2020 19:15:48 -0400 Received: from foss.arm.com ([217.140.110.172]:34892 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgFZXPs (ORCPT ); Fri, 26 Jun 2020 19:15:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88A4230E; Fri, 26 Jun 2020 16:15:47 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6B9C3F73C; Fri, 26 Jun 2020 16:15:45 -0700 (PDT) References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-16-maz@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Russell King , Thomas Gleixner , Jason Cooper , Sumit Garg , Florian Fainelli , Gregory Clement , Andrew Lunn , kernel-team@android.com Subject: Re: [PATCH v2 15/17] arm64: Remove custom IRQ stat accounting In-reply-to: Date: Sat, 27 Jun 2020 00:15:40 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/20 12:58, Marc Zyngier wrote: > On 2020-06-25 19:26, Valentin Schneider wrote: >> On 24/06/20 20:58, Marc Zyngier wrote: >>> @@ -801,26 +802,15 @@ void show_ipi_list(struct seq_file *p, int prec) >>> unsigned int cpu, i; >>> >>> for (i = 0; i < NR_IPI; i++) { >>> + unsigned int irq = irq_desc_get_irq(ipi_desc[i]); >>> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i, >>> prec >= 4 ? " " : ""); >>> for_each_online_cpu(cpu) >>> - seq_printf(p, "%10u ", >>> - __get_irq_stat(cpu, ipi_irqs[i])); >>> + seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu)); >>> seq_printf(p, " %s\n", ipi_types[i]); >> >> How attached are we to that custom IPI printout? AIUI we *could* give >> them >> a "prettier" name in request_percpu_irq() and let the standard procfs >> printout take the wheel. > > I wish. Unfortunately, /proc/interrupts is likely to be considered ABI, > and I'm really worried to change this (see what happened last time we > tried to update /proc/cpuinfo to be less braindead...). > Hmph, it's borderline here I think: we're not introducing a new field or format in the file, so any tool that can parse /proc/interrupts can parse the IPIs if they are formatted like the other "regular" interrupts. But then said tool could die in flames when not seeing the special IPI fields because sturdiness is overrated :( Oh well. > M. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124D0C433E0 for ; Fri, 26 Jun 2020 23:18:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD55B2073E for ; Fri, 26 Jun 2020 23:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dkezyno1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD55B2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jqjppAyqF6RctBiCbKHXWEq7xhAuD7DO1A5lbxlTTCM=; b=Dkezyno1YPhmwQftGOzLI0i/b ANHunejybfVvY2e2BjyzRuqYRYLjzAp7UlDLTrSb8KKhS3ufl3v7vaIiSL4iR4en17Mwbukl2vrn/ MVxlJszDTg62b+7wc9nYMSjI1OxkRMuMcttSrt4kRX1XYBPiLuuaRnsj6GrsGrDXqBTiu+CmnWPuZ nBQp1wIWSiRwrqgIVr0Hc2TfsLGpEvMKOVsKIb73XkPSYU7jKBTCKXw8aO+Yj3dph1R1LyrZSHxMG JkNrXYhVPEuZbqwhe7mdM3wJ28Cn7/6khhXr6Uv4kwFSI/iHEX/aGkLzZNoP5N4UXm3bE0A1/toHH 6GXr1le5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joxZc-000699-1d; Fri, 26 Jun 2020 23:15:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joxZX-00067X-HB for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 23:15:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88A4230E; Fri, 26 Jun 2020 16:15:47 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6B9C3F73C; Fri, 26 Jun 2020 16:15:45 -0700 (PDT) References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-16-maz@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Marc Zyngier Subject: Re: [PATCH v2 15/17] arm64: Remove custom IRQ stat accounting In-reply-to: Date: Sat, 27 Jun 2020 00:15:40 +0100 Message-ID: MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , kernel-team@android.com, Andrew Lunn , Catalin Marinas , Gregory Clement , linux-kernel@vger.kernel.org, Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/06/20 12:58, Marc Zyngier wrote: > On 2020-06-25 19:26, Valentin Schneider wrote: >> On 24/06/20 20:58, Marc Zyngier wrote: >>> @@ -801,26 +802,15 @@ void show_ipi_list(struct seq_file *p, int prec) >>> unsigned int cpu, i; >>> >>> for (i = 0; i < NR_IPI; i++) { >>> + unsigned int irq = irq_desc_get_irq(ipi_desc[i]); >>> seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i, >>> prec >= 4 ? " " : ""); >>> for_each_online_cpu(cpu) >>> - seq_printf(p, "%10u ", >>> - __get_irq_stat(cpu, ipi_irqs[i])); >>> + seq_printf(p, "%10u ", kstat_irqs_cpu(irq, cpu)); >>> seq_printf(p, " %s\n", ipi_types[i]); >> >> How attached are we to that custom IPI printout? AIUI we *could* give >> them >> a "prettier" name in request_percpu_irq() and let the standard procfs >> printout take the wheel. > > I wish. Unfortunately, /proc/interrupts is likely to be considered ABI, > and I'm really worried to change this (see what happened last time we > tried to update /proc/cpuinfo to be less braindead...). > Hmph, it's borderline here I think: we're not introducing a new field or format in the file, so any tool that can parse /proc/interrupts can parse the IPIs if they are formatted like the other "regular" interrupts. But then said tool could die in flames when not seeing the special IPI fields because sturdiness is overrated :( Oh well. > M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel