From: Valentin Schneider <valentin.schneider@arm.com>
To: "Song Bao Hua \(Barry Song\)" <song.bao.hua@hisilicon.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "mingo\@kernel.org" <mingo@kernel.org>,
"peterz\@infradead.org" <peterz@infradead.org>,
"vincent.guittot\@linaro.org" <vincent.guittot@linaro.org>,
"dietmar.eggemann\@arm.com" <dietmar.eggemann@arm.com>,
"morten.rasmussen\@arm.com" <morten.rasmussen@arm.com>,
"mgorman\@suse.de" <mgorman@suse.de>
Subject: RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort
Date: Mon, 25 Jan 2021 16:45:41 +0000 [thread overview]
Message-ID: <jhjtur50xu2.mognet@arm.com> (raw)
In-Reply-To: <jhj1re92wqm.mognet@arm.com>
On 25/01/21 09:26, Valentin Schneider wrote:
> On 25/01/21 02:23, Song Bao Hua (Barry Song) wrote:
>
>> with the below topology:
>> qemu-system-aarch64 -M virt -nographic \
>> -smp cpus=8 \
>> -numa node,cpus=0-1,nodeid=0 \
>> -numa node,cpus=2-3,nodeid=1 \
>> -numa node,cpus=4-5,nodeid=2 \
>> -numa node,cpus=6-7,nodeid=3 \
>> -numa dist,src=0,dst=1,val=12 \
>> -numa dist,src=0,dst=2,val=20 \
>> -numa dist,src=0,dst=3,val=22 \
>> -numa dist,src=1,dst=2,val=22 \
>> -numa dist,src=2,dst=3,val=12 \
>> -numa dist,src=1,dst=3,val=24 \
>>
>>
>> The panic address is *1294:
>>
>> if (sdd->sd) {
>> 1280: f9400e61 ldr x1, [x19, #24]
>> 1284: b4000201 cbz x1, 12c4 <build_sched_domains+0x414>
>> sd = *per_cpu_ptr(sdd->sd, j);
>> 1288: 93407eb7 sxtw x23, w21
>> 128c: aa0103e0 mov x0, x1
>> 1290: f8777ac2 ldr x2, [x22, x23, lsl #3]
>> *1294: f8626800 ldr x0, [x0, x2]
>> if (sd && (sd->flags & SD_OVERLAP))
>> 1298: b4000120 cbz x0, 12bc <build_sched_domains+0x40c>
>> 129c: b9403803 ldr w3, [x0, #56]
>> 12a0: 365800e3 tbz w3, #11, 12bc
>> <build_sched_domains+0x40c>
>> free_sched_groups(sd->groups, 0);
>> 12a4: f9400800 ldr x0, [x0, #16]
>> if (!sg)
>>
>
> Thanks for giving it a shot, let me run that with your topology and see
> where I end up.
>
I can't seem to reproduce this - your topology is actually among the ones
I tested this against.
Applying this patch obviously doesn't get rid of the group span issue, but
it does remove this warning:
[ 0.354806] ERROR: Node-0 not representative
[ 0.354806]
[ 0.355223] 10 12 20 22
[ 0.355475] 12 10 22 24
[ 0.355648] 20 22 10 12
[ 0.355814] 22 24 12 10
I'm running this based on tip/sched/core:
65bcf072e20e ("sched: Use task_current() instead of 'rq->curr == p'")
next prev parent reply other threads:[~2021-01-25 16:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 12:39 [PATCH 0/1] sched/topology: NUMA distance deduplication Valentin Schneider
2021-01-22 12:39 ` [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort Valentin Schneider
2021-01-25 2:23 ` Song Bao Hua (Barry Song)
2021-01-25 9:26 ` Valentin Schneider
2021-01-25 16:45 ` Valentin Schneider [this message]
2021-01-25 21:35 ` Song Bao Hua (Barry Song)
2021-01-28 14:47 ` Valentin Schneider
2021-01-29 2:02 ` Song Bao Hua (Barry Song)
2021-02-01 12:03 ` Valentin Schneider
2021-02-01 9:53 ` Dietmar Eggemann
2021-02-01 10:19 ` Vincent Guittot
2021-02-01 10:35 ` Song Bao Hua (Barry Song)
2021-02-01 11:55 ` Valentin Schneider
2021-02-02 10:03 ` [tip: sched/core] sched/topology: Fix sched_domain_topology_level alloc in sched_init_numa() tip-bot2 for Dietmar Eggemann
2021-02-17 13:17 ` tip-bot2 for Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjtur50xu2.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=song.bao.hua@hisilicon.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.