From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nEbfB-0001xd-EQ for mharc-grub-devel@gnu.org; Mon, 31 Jan 2022 13:44:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEbf4-0001to-Gz for grub-devel@gnu.org; Mon, 31 Jan 2022 13:44:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEbey-0005xt-Ff for grub-devel@gnu.org; Mon, 31 Jan 2022 13:44:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643654655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=THP01/hP47+gDtWs4LAmFnWJKvqPNO3RXENfCjWzaOk=; b=aH4h0alJpUp6VtvESp+HBI9+Ghpiq1JP/3hKbxNJ52VW0X6sIX0oOZ0pCdGfXM0TSBqVNz tD6V/FrWxrUtT8b23Dv86uCcwWcZDRG5fioM08GDOYQr3cLHrMgR7oNVNoe6imj097+AHF mc3IRXvBONruVaoxjdzCHofy6DAJtMU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-482-VHCR1DCfMY2OlxR9wk9KOg-1; Mon, 31 Jan 2022 13:44:13 -0500 X-MC-Unique: VHCR1DCfMY2OlxR9wk9KOg-1 Received: by mail-qt1-f198.google.com with SMTP id z1-20020ac87ca1000000b002d11bc8d795so10995592qtv.17 for ; Mon, 31 Jan 2022 10:44:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=THP01/hP47+gDtWs4LAmFnWJKvqPNO3RXENfCjWzaOk=; b=Lp4lxXuUo9Kdrl7vNCWh1ygtS3/wWJ96N6Ey3LeWdDAx+4+iYLHck3OmxSqvojwA0w DoePtnUP/fknZGpf9lTKex1ZeloM7b+gXKJQrLWbE93KBvvw3Hvn7YmmfA3MS0DLpzEc TxMsOA/1S0X7NrnJSiQ4dfzFu58Wq13t+cdU3zbxb5gIqhgpj38nVV8zYNu1Wo2SlVy8 5MbPI66BKuOblTayPlzOO1jPs3yNMgji4M/yFl6fHS0xwdw/pgfBkyFbZvbM9gxndZdj 6bE+CrWXv1MwOn/bCC1Rfs85XV+jL6AMoxSHcWmG+MA0DtNa8uayndBxPXjXelpyFbxZ R7Sw== X-Gm-Message-State: AOAM533uQInxvAlDPllicqgl2eg4vHxt6m/kjP7vKyvZcYWN4mp53D65 1HjTPkCjAANNSQ7w3boal5efSoCwaHnd/4QBbSOFNALpNwYTRv+2CdRNP4jzqbu52iyQFs+s6rk izqa7zUxLG5s= X-Received: by 2002:a05:622a:2cd:: with SMTP id a13mr13211306qtx.108.1643654652302; Mon, 31 Jan 2022 10:44:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyduphmfVVtu7cfBH6KCt3CI5m3ft+1UNzvAAspozjJmb0+bnQVnvyX+HkADSP8iEBkTWX28A== X-Received: by 2002:a05:622a:2cd:: with SMTP id a13mr13211250qtx.108.1643654651273; Mon, 31 Jan 2022 10:44:11 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id h10sm10194093qko.92.2022.01.31.10.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 10:44:10 -0800 (PST) From: Robbie Harwood To: Javier Martinez Canillas , The development of GNU GRUB , Hans de Goede Subject: Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text output In-Reply-To: <761420ab-d5ce-15ee-4ab7-a9e1a2627cd5@redhat.com> References: <20220128114349.87480-1-hdegoede@redhat.com> <20220128114349.87480-2-hdegoede@redhat.com> <761420ab-d5ce-15ee-4ab7-a9e1a2627cd5@redhat.com> Date: Mon, 31 Jan 2022 13:44:07 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 18:44:24 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Javier Martinez Canillas writes: > On 1/28/22 12:43, Hans de Goede wrote: >> To allow flickerfree boot the EFI console code does not call >> grub_efi_set_text_mode (1) until some text is actually output. >>=20 >> Depending on if the output text is because of an error loading >> e.g. the .cfg file; or because of showing the menu the cursor needs >> to be on or off when the first text is shown. >>=20 >> So far the cursor was hardcoded to being on, but this is causing >> drawing artifacts + slow drawing of the menu as reported here: >> https://bugzilla.redhat.com/show_bug.cgi?id=3D1946969 >>=20 >> Handle the cursorstate in the same way as the colorstate to fix this, >> when no text has been output yet, just cache the cursorstate and >> then use the last set value when the first text is output. >>=20 >> Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actuall= y need it") >> Signed-off-by: Hans de Goede >> --- > > Reviewed-by: Javier Martinez Canillas Reviewed-by: Robbie Harwood Be well, =2D-Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmH4LfcUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEL5mw//RC77NpnsafdSaQuRSbreA9wdcHtE Qb/B32aiz1b6bHJwHSgtOpgVvwxh5cplyXjeFwag8TTxUkcRbFC9AeCg/vKfZ261 BytXumhrQ0YORsioRYb7mmaXMcu+9tCamPUd4ZBItHw/1Ln0TOfEkYUaIQNUeNxo 6yaRxwQIIJUCX/bC8kPILxu5VLiiFKYpQge78ucNYzj/5zAcRDigUM7RVf2+/ayS 2vzjziqVc89Gj8lX+tQweL3xEKs/og8dBTd0SmstShDxJW4N2QEYyYeL2ofvLyWL 7cvVCefravQpvQo6VDXVhdr/MVG8IN/tF6tca05ew91ZK2XkI9jHQljlXdjPVN3v FJhQ8kTSjfGEW/WQpa2T+uheytsTPxKo5fgkO+mTjnEIPvLvmPwda/7pm03uanYn v4dC2Mi8PNI6rX6sBuGF0J+HMV0JVJwXQ75+ATjTtYEwuMcpP0ueSYM4WSp4Wqao 7vVe/BnNMuVRhL4K4NEfmlF92hNgiN19X8FYn5ZdIqafVxtYX+UjZ+KPSuXdulwo T6HtDek7O3VYXBPhyoHdlNeBT+X6JC1ydLJyCPsR/ug3HuvilJTDQKOCGSnnk542 vCxYA9oCOsxq2n57vUyFbV5j+TJw6xO9qdimA5QnIKWlajiuXudl8bOnpdcd6BcS OmZEQbi2oZM98/4= =SQYr -----END PGP SIGNATURE----- --=-=-=--