From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pKQkl-0004V3-F2 for mharc-grub-devel@gnu.org; Tue, 24 Jan 2023 16:22:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKQkk-0004U7-7H for grub-devel@gnu.org; Tue, 24 Jan 2023 16:22:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKQkh-0006vt-LI for grub-devel@gnu.org; Tue, 24 Jan 2023 16:22:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674595366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHVsEJccllYRPUnUDIXUkrLX9mN+dSy+T82Ye9dlx+4=; b=inZ7/PXc0UkMWpCK/bcwNEJiYfuRDEoU/vfcRk0LWy2ATEIR2SwXp2+MjtE4/HA/Vx7pt9 PfclGEgYJSYjgerMFG+EAXS/JOG9SDeD9TVb3oMLuNrd1j19EQYLwG/GNmww3gxdhUdCqt LgnsZdN6osbStu8+qZ2LajAgBgayx5Q= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-27-gUl8zwDJM9eQiTdOgL6pOg-1; Tue, 24 Jan 2023 16:22:44 -0500 X-MC-Unique: gUl8zwDJM9eQiTdOgL6pOg-1 Received: by mail-qv1-f71.google.com with SMTP id f16-20020ad442d0000000b005376362aa66so2274287qvr.1 for ; Tue, 24 Jan 2023 13:22:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HHVsEJccllYRPUnUDIXUkrLX9mN+dSy+T82Ye9dlx+4=; b=HXAsAN01pCctBVsO2BRTf2fFA6cDfzRd0pRbznqlrt9yF0+l043QxKWM3kiJffVT9v 7Q+X6UCGTAeEZrfQSWStKrIndx0uOqIoJRqVA0cFIFc+eHCRpvS7gYg5lEpTeRm7acfw 5MsL2h5GP0VsM+CmH79U5OifHcrB/HJCC2pt+7Y4T8RvVKFaCt55QboNRDYFXarmIVeM XAZ6oGfwLXthWfOFEzFJLZsbRq+2v7TP8/vSJndS+KvKILA52tL/Cnweo4nuD21U2xWE 2l551XyTAgUuIx62e5SieTpQzUpu2U4mXZbfSU9N7o5QFAP6FCObuc+CoF/Fn+GdbE11 jexQ== X-Gm-Message-State: AFqh2kr7e90SH+Clq9HJPqBzKmQWfpEkY3KQE6ArYXk1uOL3PVv2HaNN qz5c9efxxWcx9xRevCRr6hi4RjGJYIYJ8WrzvWYHPL8NK87P72qefYOfvkAByNuuSfb/P1ROHjV wIY9xBtHfZaU= X-Received: by 2002:a0c:db07:0:b0:537:4b34:45e9 with SMTP id d7-20020a0cdb07000000b005374b3445e9mr26788786qvk.38.1674595363353; Tue, 24 Jan 2023 13:22:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXs0IHkNIzMWaZrSt4ecqQZ0bQt8Tx12CFhddQv1mWeHd5ry8YcLsEHmlWvTJIFCb4nnp46lsg== X-Received: by 2002:a0c:db07:0:b0:537:4b34:45e9 with SMTP id d7-20020a0cdb07000000b005374b3445e9mr26788735qvk.38.1674595362854; Tue, 24 Jan 2023 13:22:42 -0800 (PST) Received: from localhost ([2600:4040:520a:8800:7d1c:f0a7:5c44:ed0e]) by smtp.gmail.com with ESMTPSA id q16-20020ae9e410000000b006ec62032d3dsm2172995qkc.30.2023.01.24.13.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 13:22:01 -0800 (PST) From: Robbie Harwood To: Glenn Washburn , Gerd Hoffmann Cc: The development of GNU GRUB , Daniel Kiper Subject: Re: [PATCH] grub-shell: Add flexibility in QEMU firmware handling In-Reply-To: <20230123140947.7998a115@crass-HP-ZBook-15-G2> References: <20230121061520.1619840-1-development@efficientek.com> <20230123092809.sycmpu4iu5hn6b6n@sirius.home.kraxel.org> <20230123140947.7998a115@crass-HP-ZBook-15-G2> Date: Tue, 24 Jan 2023 16:21:34 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2023 21:22:50 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Glenn Washburn writes: > On Mon, 23 Jan 2023 10:28:09 +0100 > Gerd Hoffmann wrote: > >> On Sat, Jan 21, 2023 at 12:15:20AM -0600, Glenn Washburn wrote: >> > The current qemu firmware paths for arm-efi and arm64-efi are not >> > available on Ubuntu/Debian but are hardcoded. Switch to first >> > looking for firmware files in the source directory and if not >> > found, look for them in locations where Debian installs them. >>=20 >> I'd suggest to inspect the *.json files in /usr/share/qemu/firmware/ >> to find distro-installed firmware files. > > Yes, I know about this, but decided against it so as not to do real or > hacked up json parsing and add another dependency (eg. jq). I think > right now the unstated GRUB policy is that these tests are only > officially supported to run on (newer) debian systems, so I felt that > hard coding was reasonable. It occurs to me that its possible (though I > suspect very improbable), that Redhat based distros run the tests when > building the official RPM. Is there a reason that redhat would be very > interested in the change you're suggesting? We don't run the tests during builds. That has more to do with buildtimes and historical considerations than the tests themselves. Personally, I would write this in such a way that we could, e.g., check the debian locations, and fallback to the fedora locations if they don't exist, and so forth for other distros. That said, grub has not been in favor of handling compatibility in this way in the past and seems to prefer pushing that burden onto the distros and their users. Be well, =2D-Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmPQS94UHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJKbQ/4xQXWLPazzb4nOZrx7f3sezBISsmz BNQCFd+E0g90jUHi4hMMth7DGlnQ3B5wnOr2Ojq5UFop00HykyEDbJ1V2kHVPolp aR3Xnm143pvQVGDNJEaDykYM1rckY4d6tyjZj5kDZHXxmB/gswgIax1gEVfD9HUn 6xGT7erffbIkpoQgHeX/Iu35HPJJleSeURaVWN9G/1dQ6Tb8cM4GeOf4tbORkp0y kqC65e+TxPnOvQ+mNtLGPKmAE4AOj6igSoguLePHZUYBr+jsoOTxpZKRC8wvm+PD 3/pP0ezV7d8Sg1bHVC5RYGAmW2ExfVoiIsKsfeUBd+HiOmCcTSguj2VCs5RrapPM N8TIs9Y9Jlgzw09qGlhN2/h3RRNyz+sMsREtfmUmQg1fJ7BG79hmSZ8Xw7scNDTJ gD3dUoba7/Ax/aP+XW+lnsqcp2opjrVewvhd+p6bjDgMZ87mfYM2h4v35IRn//jM QRbRkHkGP5oXgQ8rBqG9XWvQ7uQctYqQzlKUWJpfj5aBdtdEELZclC+sQI6LnclR 3kRfDwGoOSEabRHgwUU2kYRQcYc3Xb5nQ0fne/qeAQKtsb1G2Q2L2XLYNe0b28X9 1zoRUaRRtilWh6pUcaxwBoh6J3usCPvf/tNn3rMaPgtfGpgA+oLmpglb38a6VF6q GR51Yshx3rIAPg== =Jw0V -----END PGP SIGNATURE----- --=-=-=--