Re: [Qemu-devel] [PATCH] usb-mtp: fix return status of delete

[Bandan Das <bsd@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 8 Mar 2019 at 22:14, Bandan Das <bsd@redhat.com> wrote:
>>
>>
>> Spotted by Coverity: CID 1399414
>>
>> mtp delete allows the a return status of delete succeeded,
>> partial_delete or readonly - when none of the objects could be
>> deleted.
>>
>> Some initiators recurse over the objects themselves. In that case,
>> only READ_ONLY can be returned.
>>
>> Signed-off-by: Bandan Das <bsd@redhat.com>
>> ---
>>  hw/usb/dev-mtp.c | 25 +++++++++----------------
>>  1 file changed, 9 insertions(+), 16 deletions(-)
>>
>> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
>> index 06e376bcd2..e3401aad75 100644
>> --- a/hw/usb/dev-mtp.c
>> +++ b/hw/usb/dev-mtp.c
>> @@ -1137,9 +1137,9 @@ static MTPData *usb_mtp_get_object_prop_value(MTPState *s, MTPControl *c,
>>
>>  /* Return correct return code for a delete event */
>>  enum {
>> -    ALL_DELETE,
>> -    PARTIAL_DELETE,
>> +    ALL_DELETE = 1,
>>      READ_ONLY,
>> +    PARTIAL_DELETE,
>
> This is an enum, ie a set of incrementing values, but you're
> using them as bit positions you're ORing together. If they're
> really bit flags you should define them properly that way,
> so it's clear what you're doing.
>
Sure, no problem

> At the moment PARTIAL_DELETE is "ALL_DELETE | READ_ONLY", which
> doesn't seem like it makes much sense.
>

Sorry, can you please clarify what doesn't make sense ?

> thanks
> -- PMM