From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755333AbdEDSMc (ORCPT ); Thu, 4 May 2017 14:12:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbdEDSLx (ORCPT ); Thu, 4 May 2017 14:11:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 250B63B717 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bsd@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 250B63B717 From: Bandan Das To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging References: <20170503221457.18869-1-bsd@redhat.com> <20170503221457.18869-3-bsd@redhat.com> Date: Thu, 04 May 2017 14:11:51 -0400 In-Reply-To: (Paolo Bonzini's message of "Thu, 4 May 2017 11:21:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 04 May 2017 18:11:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini writes: > On 04/05/2017 00:14, Bandan Das wrote: >> + if (vmx->nested.pml_full) { >> + exit_reason = EXIT_REASON_PML_FULL; >> + vmx->nested.pml_full = false; >> + } else if (fault->error_code & PFERR_RSVD_MASK) >> exit_reason = EXIT_REASON_EPT_MISCONFIG; >> else >> exit_reason = EXIT_REASON_EPT_VIOLATION; >> + /* >> + * The definition of bit 12 for EPT violations and PML >> + * full event is the same, so pass it through since >> + * the rest of the bits are undefined. >> + */ > > Please zero all other bits instead. It's as easy as adding an "u64 > exit_qualification" local variable. Will do, thanks for the review. Bandan > Paolo > >> nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);