All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, aik@ozlabs.ru
Subject: Re: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function
Date: Fri, 20 May 2016 12:29:58 -0400	[thread overview]
Message-ID: <jpgvb28y9o9.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <09450c5c-f7e9-a71f-0416-92e7bf97ad99@redhat.com> (Paolo Bonzini's message of "Fri, 20 May 2016 09:50:27 +0200")

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 20/05/2016 00:15, Bandan Das wrote:
>>  void qmp_inject_nmi(Error **errp)
>>  {
>> -#if defined(TARGET_I386)
>> -    CPUState *cs;
>> -
>> -    CPU_FOREACH(cs) {
>> -        X86CPU *cpu = X86_CPU(cs);
>> -
>> -        if (!cpu->apic_state) {
>> -            cpu_interrupt(cs, CPU_INTERRUPT_NMI);
>> -        } else {
>> -            apic_deliver_nmi(cpu->apic_state);
>> -        }
>> -    }
>> -#else
>> -    nmi_monitor_handle(monitor_get_cpu_index(), errp);
>> -#endif
>> +    inject_nmi(errp);
>
> This changes the first argument to nmi_monitor_handle in the !i386 case.
>  It should just remove the #ifdef, which I think makes the third patch
> unnecessary.  The first two patches are okay.

Thanks for the review, I have sent a v2.

> Paolo

  reply	other threads:[~2016-05-20 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 22:15 [Qemu-devel] [PATCH 0/4] Minor nmi cleanups Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 1/4] target-i386: add a generic x86 nmi handler Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 2/4] nmi: remove x86 specific nmi handling Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 3/4] nmi: add errp function parameter to inject_nmi() Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function Bandan Das
2016-05-20  7:50   ` Paolo Bonzini
2016-05-20 16:29     ` Bandan Das [this message]
2016-05-20  7:50   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jpgvb28y9o9.fsf@linux.bootlegged.copy \
    --to=bsd@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.