From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRD6-00010V-TA for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGRD4-0001BF-UR for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57942) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGRD0-0000zj-WC for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:25 -0400 From: Bandan Das References: <20190415154503.6758-1-berrange@redhat.com> <20190415165426.GT5718@redhat.com> <20190416084059.GD31311@redhat.com> <20190416161242.GU31311@redhat.com> Date: Tue, 16 Apr 2019 12:45:04 -0400 In-Reply-To: <20190416161242.GU31311@redhat.com> ("Daniel P. \=\?utf-8\?Q\?Ber\?\= \=\?utf-8\?Q\?rang\=C3\=A9\=22's\?\= message of "Tue, 16 Apr 2019 17:12:42 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" Cc: qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Gerd Hoffmann , Greg Kurz Daniel P. Berrang=C3=A9 writes: > On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote: >> Daniel P. Berrang=C3=A9 writes: >> ... >> >> > The store is read only by default. Are you trying something like: >> >> > -device usb-mtp,rootdir=3D/code/mtpshare,readonly=3Dfalse ? >> >>=20 >> >> Ah ha, I didn't realize I had to enable write support explicitly. Will >> >> retry with that. >> > >> > Even after setting readonly=3Dfalse, I still can't get "mtp-sendfile" >> > to succeed in a guest. >> > >> I posted a patch for a bug introduced by a recent commit that made small= er >> file sizes return back with a incomplete file transfer. >>=20 >> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02552.html > > Yes, I applied that and didn't see any difference in behaviour > Just noticed the error message you posted: Error sending file. Error 2: PTP Layer error 02ff: send_file_object_info(): Could not send = object info. Error 2: Error 02ff: PTP I/O Error ERROR: Could not close session! I can't find usb-mtp sending a "I/O error" on an error condition for the objectinfo phase. It might be libmtp or even the command itself failing for some reason. For incomplete transfer, I just checked, it's spitting out the error message correctly as INCOMPLETE_FILE_TRANSFER. With libmtp version 1.13 on a FC24 guest, here's the output: $ mtp-sendfile test.txt test.img libmtp version: 1.1.13 Device 0 (VID=3D46f4 and PID=3D0004) is UNKNOWN in libmtp v1.1.13. Please report this VID/PID and the device model to the libmtp development t= eam ignoring libusb_claim_interface() =3D -6PTP_ERROR_IO: failed to open sessio= n, trying again after resetting USB interface LIBMTP libusb: Attempt to reset device Sending test.txt to test.img type: txt, 44 Sending file... Progress: 322 of 322 (100%) New file ID: 7 What guest is this ? I can try to reproduce. > Regards, > Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A69C10F13 for ; Tue, 16 Apr 2019 16:46:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 578FB206B6 for ; Tue, 16 Apr 2019 16:46:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578FB206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:39583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGREU-0001iw-Jn for qemu-devel@archiver.kernel.org; Tue, 16 Apr 2019 12:46:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGRD6-00010V-TA for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGRD4-0001BF-UR for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57942) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGRD0-0000zj-WC for qemu-devel@nongnu.org; Tue, 16 Apr 2019 12:45:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B015C04959F; Tue, 16 Apr 2019 16:45:10 +0000 (UTC) Received: from gigantic.usersys.redhat.com (helium.bos.redhat.com [10.18.17.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EEA1608A4; Tue, 16 Apr 2019 16:45:05 +0000 (UTC) From: Bandan Das To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= References: <20190415154503.6758-1-berrange@redhat.com> <20190415165426.GT5718@redhat.com> <20190416084059.GD31311@redhat.com> <20190416161242.GU31311@redhat.com> Date: Tue, 16 Apr 2019 12:45:04 -0400 In-Reply-To: <20190416161242.GU31311@redhat.com> ("Daniel P. \=\?utf-8\?Q\?Ber\?\= \=\?utf-8\?Q\?rang\=C3\=A9\=22's\?\= message of "Tue, 16 Apr 2019 17:12:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 16 Apr 2019 16:45:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Greg Kurz , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190416164504.oLkjNNp2KyA6Tr0turyRN4qSliMGiigLfDxV_uo7snw@z> Daniel P. Berrang=C3=A9 writes: > On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote: >> Daniel P. Berrang=C3=A9 writes: >> ... >> >> > The store is read only by default. Are you trying something like: >> >> > -device usb-mtp,rootdir=3D/code/mtpshare,readonly=3Dfalse ? >> >>=20 >> >> Ah ha, I didn't realize I had to enable write support explicitly. Will >> >> retry with that. >> > >> > Even after setting readonly=3Dfalse, I still can't get "mtp-sendfile" >> > to succeed in a guest. >> > >> I posted a patch for a bug introduced by a recent commit that made small= er >> file sizes return back with a incomplete file transfer. >>=20 >> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02552.html > > Yes, I applied that and didn't see any difference in behaviour > Just noticed the error message you posted: Error sending file. Error 2: PTP Layer error 02ff: send_file_object_info(): Could not send = object info. Error 2: Error 02ff: PTP I/O Error ERROR: Could not close session! I can't find usb-mtp sending a "I/O error" on an error condition for the objectinfo phase. It might be libmtp or even the command itself failing for some reason. For incomplete transfer, I just checked, it's spitting out the error message correctly as INCOMPLETE_FILE_TRANSFER. With libmtp version 1.13 on a FC24 guest, here's the output: $ mtp-sendfile test.txt test.img libmtp version: 1.1.13 Device 0 (VID=3D46f4 and PID=3D0004) is UNKNOWN in libmtp v1.1.13. Please report this VID/PID and the device model to the libmtp development t= eam ignoring libusb_claim_interface() =3D -6PTP_ERROR_IO: failed to open sessio= n, trying again after resetting USB interface LIBMTP libusb: Attempt to reset device Sending test.txt to test.img type: txt, 44 Sending file... Progress: 322 of 322 (100%) New file ID: 7 What guest is this ? I can try to reproduce. > Regards, > Daniel