From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [PATCH 1/3] KVM: nVMX: Advertise support for interrupt acknowledgement Date: Thu, 20 Mar 2014 16:45:23 -0400 Message-ID: References: <1395286089-5406-1-git-send-email-bsd@redhat.com> <1395286089-5406-2-git-send-email-bsd@redhat.com> <532AA732.60803@siemens.com> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org, Paolo Bonzini , Gleb Natapov To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760007AbaCTUp2 (ORCPT ); Thu, 20 Mar 2014 16:45:28 -0400 In-Reply-To: <532AA732.60803@siemens.com> (Jan Kiszka's message of "Thu, 20 Mar 2014 09:30:42 +0100") Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka writes: > On 2014-03-20 04:28, Bandan Das wrote: >> Some Type 1 hypervisors such as XEN won't enable VMX without it present >> >> Signed-off-by: Bandan Das >> --- >> arch/x86/kvm/vmx.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index 3927528..26c1d38 100644 >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -2273,7 +2273,8 @@ static __init void nested_vmx_setup_ctls_msrs(void) >> nested_vmx_pinbased_ctls_high &= ~PIN_BASED_VMX_PREEMPTION_TIMER; >> } >> nested_vmx_exit_ctls_high |= (VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR | >> - VM_EXIT_LOAD_IA32_EFER | VM_EXIT_SAVE_IA32_EFER); >> + VM_EXIT_LOAD_IA32_EFER | VM_EXIT_SAVE_IA32_EFER | >> + VM_EXIT_ACK_INTR_ON_EXIT); >> >> /* entry controls */ >> rdmsr(MSR_IA32_VMX_ENTRY_CTLS, >> > > Shouldn't this come after patch 2? Right, that makes sense. Will fix in v2. > Jan