From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15467C433DF for ; Thu, 14 May 2020 06:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB09B205CB for ; Thu, 14 May 2020 06:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="1vCUkV73" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725952AbgENGgc (ORCPT ); Thu, 14 May 2020 02:36:32 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:63749 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbgENGgb (ORCPT ); Thu, 14 May 2020 02:36:31 -0400 Date: Thu, 14 May 2020 06:36:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1589438190; bh=TG6q1oVn9yu9TrPo2CgKnbg1pqUklx0m8C5AyvFrsr0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=1vCUkV73e9+2C9vkOYc1D6vdpRtlHdDeQrRHX4cHoHzn8aW/pC5hhzjarnFMWscQa EH2CeI6KQACny43AmtwusPMeJ0cjVuLTJawObnMDecKzs8iuotyxHqmQuz3JiX0A1b BmlqTDSBIMY3fYF3X4XjDxL8Yy55+HsB7E3o8na8= To: Laurent Pinchart From: Simon Ser Cc: "dri-devel@lists.freedesktop.org" , "linux-renesas-soc@vger.kernel.org" Reply-To: Simon Ser Subject: Re: [PATCH v2] drm: plane: Verify that no or all planes have a zpos property Message-ID: In-Reply-To: <20200513225835.19361-1-laurent.pinchart+renesas@ideasonboard.com> References: <20200513225835.19361-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thursday, May 14, 2020 12:58 AM, Laurent Pinchart wrote: > The zpos property is used by userspace to sort the order of planes. > While the property is not mandatory for drivers to implement, mixing > planes with and without zpos confuses userspace, and shall not be > allowed. Clarify this in the documentation and warn at runtime if the > drivers mixes planes with and without zpos properties. Thanks for the patch, this looks good to me! Acked-by: Simon Ser From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E17C433E0 for ; Thu, 14 May 2020 06:36:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13952205CB for ; Thu, 14 May 2020 06:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="1vCUkV73" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13952205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 661E16E10B; Thu, 14 May 2020 06:36:34 +0000 (UTC) Received: from mail1.protonmail.ch (mail1.protonmail.ch [185.70.40.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20E8E6E10B for ; Thu, 14 May 2020 06:36:33 +0000 (UTC) Date: Thu, 14 May 2020 06:36:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1589438190; bh=TG6q1oVn9yu9TrPo2CgKnbg1pqUklx0m8C5AyvFrsr0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=1vCUkV73e9+2C9vkOYc1D6vdpRtlHdDeQrRHX4cHoHzn8aW/pC5hhzjarnFMWscQa EH2CeI6KQACny43AmtwusPMeJ0cjVuLTJawObnMDecKzs8iuotyxHqmQuz3JiX0A1b BmlqTDSBIMY3fYF3X4XjDxL8Yy55+HsB7E3o8na8= To: Laurent Pinchart From: Simon Ser Subject: Re: [PATCH v2] drm: plane: Verify that no or all planes have a zpos property Message-ID: In-Reply-To: <20200513225835.19361-1-laurent.pinchart+renesas@ideasonboard.com> References: <20200513225835.19361-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: "linux-renesas-soc@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thursday, May 14, 2020 12:58 AM, Laurent Pinchart wrote: > The zpos property is used by userspace to sort the order of planes. > While the property is not mandatory for drivers to implement, mixing > planes with and without zpos confuses userspace, and shall not be > allowed. Clarify this in the documentation and warn at runtime if the > drivers mixes planes with and without zpos properties. Thanks for the patch, this looks good to me! Acked-by: Simon Ser _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel