All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: Mitchell Augustin <mitchell.augustin@canonical.com>
Cc: linux-aio@kvack.org, brauner@kernel.org, bcrl@kvack.org,
	 linux-fsdevel@vger.kernel.org, colin.i.king@gmail.com,
	 dann frazier <dann.frazier@canonical.com>,
	Ian May <ian.may@canonical.com>
Subject: Re: [PATCH] fs/aio: obey min_nr when doing wakeups
Date: Sat, 30 Mar 2024 16:29:32 -0400	[thread overview]
Message-ID: <kgkn6pklnafahldqznbf3zgqch3dyoxgsvmse4xfcz5rdgilxf@veery7hzv3zf> (raw)
In-Reply-To: <CAHTA-uZo15smL6f=S7kMcJiGMNjUQ7fZMj7-5e6is=2HUeYr-Q@mail.gmail.com>

On Fri, Mar 29, 2024 at 12:09:10PM -0500, Mitchell Augustin wrote:
> I was able to reproduce this panic with the following ktest:
> 
> ~/ktest/tests/stress_ng.ktest:
> 
> #!/usr/bin/env bash
> 
> . $(dirname $(readlink -e "${BASH_SOURCE[0]}"))/test-libs.sh
> 
> test_stressng()
> {
>     apt install stress-ng
>     count=15
>     for i in $(seq $count); do
>         echo "Starting Stress #${i}/${count} for $(uname -r)"
>         mkdir /tmp/kerneltest
>         stress-ng --aggressive --verify --timeout 240 --temp-path
> //tmp/kerneltest --hdd-opts dsync --readahead-bytes 16M -k --aiol 0
>         rm -rf /tmp/kerneltest
>         echo "Completed Stress #${i}/${count} for $(uname -r)"
>     done
> }
> 
> main "$@"
> 
> by running ~/ktest/build-test-kernel run -I ~/ktest/tests/stress_ng.ktest
> 
> Note that the panic may not necessarily happen on the first run of
> that stress-ng command, so you might have to wait several iterations.
> 
> Panic:
> Running test stress_ng.ktest on gunyolk at /home/ubuntu/upstream/linux
> building kernel... done
> Kernel version: 6.9.0-rc1-ktest-00061-g8d025e2092e2

Thanks for the quick reproducer.

I got it to pop - a few times, actually - but now that I've added debug
code (cookie values to check for some sort of a stray write), it's now
decided not to pop anymore, after 24 hours of testing, with and without
my debug changes.

Hmm.

We may just have to revert this for now, unless anyone else has any
bright ideas.

  reply	other threads:[~2024-03-30 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b8e4d93c-f2f2-4a0e-a47f-15a740434356@mitchellaugustin.com>
2024-03-28 22:29 ` [PATCH] fs/aio: obey min_nr when doing wakeups Mitchell Augustin
2024-03-29  0:18   ` Kent Overstreet
2024-03-29  1:40     ` Mitchell Augustin
2024-03-29 17:09       ` Mitchell Augustin
2024-03-30 20:29         ` Kent Overstreet [this message]
2023-11-22 23:42 Kent Overstreet
2023-11-23 17:40 ` Christian Brauner
2023-11-24  0:24   ` Kent Overstreet
2023-11-24  7:47 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kgkn6pklnafahldqznbf3zgqch3dyoxgsvmse4xfcz5rdgilxf@veery7hzv3zf \
    --to=kent.overstreet@linux.dev \
    --cc=bcrl@kvack.org \
    --cc=brauner@kernel.org \
    --cc=colin.i.king@gmail.com \
    --cc=dann.frazier@canonical.com \
    --cc=ian.may@canonical.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mitchell.augustin@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.