From: "Arve Hjønnevåg" <arve@android.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Randy Dunlap <rdunlap@xenotime.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Nigel Cunningham <nigel@tuxonice.net>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Ming Lei <tom.leiming@gmail.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/9] PM: Add suspend block api.
Date: Fri, 23 Apr 2010 20:14:19 -0700 [thread overview]
Message-ID: <l2sd6200be21004232014r806b0c67ucf5508ac7ff50a44@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1004232224380.30686-100000@netrider.rowland.org>
2010/4/23 Alan Stern <stern@rowland.harvard.edu>:
> On Fri, 23 Apr 2010, Arve Hjønnevåg wrote:
>
>> 2010/4/23 Alan Stern <stern@rowland.harvard.edu>:
>> > On Thu, 22 Apr 2010, [UTF-8] Arve Hjønnevåg wrote:
>> ...
>> >> +Calling suspend_block when the suspend blocker is active or suspend_unblock when
>> >> +it is not active has no effect. This allows drivers to update their state and
>> >> +call suspend suspend_block or suspend_unblock based on the result.
>> >
>> > But suspend_block() and suspend_unblock() don't nest. You should
>> > mention this.
>> >
>>
>> I'm not sure what you mean by this? I think the first sentence
>> dictates nesting is not supported.
>
> That fact is implicit from the first sentence. Mentioning it
> _explicitly_ will help people to understand more easily. You don't
> have to add much; a parenthetical remark would be enough:
>
> Calling suspend_block when the suspend blocker is active or
> suspend_unblock when it is not active has no effect (i.e.,
> these functions don't nest). This allows drivers to ...
>
OK.
--
Arve Hjønnevåg
next prev parent reply other threads:[~2010-04-24 3:14 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 1:08 [PATCH 0/9] Suspend block api (version 4) Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 1/9] PM: Add suspend block api Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 3/9] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 4/9] PM: suspend_block: Switch to list of active and inactive suspend blockers Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 5/9] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 6/9] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 7/9] PM: Add suspend blocking work Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 8/9] Input: Block suspend while event queue is not empty Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 9/9] power_supply: Block suspend while power supply change notifications are pending Arve Hjønnevåg
2010-04-23 1:08 ` Arve Hjønnevåg
2010-04-23 20:56 ` [PATCH 8/9] Input: Block suspend while event queue is not empty Randy Dunlap
2010-04-23 21:08 ` Dmitry Torokhov
2010-04-23 21:08 ` Dmitry Torokhov
2010-04-23 21:08 ` Dmitry Torokhov
2010-04-24 5:02 ` Arve Hjønnevåg
2010-04-24 5:02 ` Arve Hjønnevåg
2010-04-24 5:02 ` Arve Hjønnevåg
2010-04-24 14:36 ` Alan Stern
2010-04-24 14:36 ` [linux-pm] " Alan Stern
2010-04-24 14:36 ` Alan Stern
2010-04-25 2:30 ` Rafael J. Wysocki
2010-04-25 2:30 ` Rafael J. Wysocki
2010-04-25 15:29 ` Alan Stern
2010-04-25 15:29 ` Alan Stern
2010-04-25 22:41 ` Arve Hjønnevåg
2010-04-25 22:41 ` Arve Hjønnevåg
2010-04-25 22:41 ` Arve Hjønnevåg
2010-04-25 15:29 ` Alan Stern
2010-04-25 2:30 ` Rafael J. Wysocki
2010-04-24 4:58 ` Arve Hjønnevåg
2010-04-24 4:58 ` Arve Hjønnevåg
2010-04-24 4:58 ` Arve Hjønnevåg
2010-04-23 20:56 ` Randy Dunlap
2010-04-23 8:16 ` [PATCH 7/9] PM: Add suspend blocking work Tejun Heo
2010-04-23 12:20 ` Oleg Nesterov
2010-04-23 22:49 ` Arve Hjønnevåg
2010-04-23 22:49 ` Arve Hjønnevåg
2010-04-24 5:21 ` Arve Hjønnevåg
2010-04-24 5:21 ` Arve Hjønnevåg
2010-04-24 6:33 ` Tejun Heo
2010-04-24 7:21 ` Arve Hjønnevåg
2010-04-24 7:21 ` Arve Hjønnevåg
2010-04-24 7:43 ` Tejun Heo
2010-04-24 7:43 ` Tejun Heo
2010-04-24 6:33 ` Tejun Heo
2010-04-26 14:06 ` Oleg Nesterov
2010-04-26 14:06 ` Oleg Nesterov
2010-04-23 12:20 ` Oleg Nesterov
2010-04-23 8:16 ` Tejun Heo
2010-04-23 20:58 ` [PATCH 5/9] PM: suspend_block: Add debugfs file Randy Dunlap
2010-04-23 20:58 ` Randy Dunlap
2010-04-24 3:23 ` Arve Hjønnevåg
2010-04-24 4:24 ` Randy Dunlap
2010-04-24 4:24 ` Randy Dunlap
2010-04-24 4:54 ` Arve Hjønnevåg
2010-04-24 4:54 ` Arve Hjønnevåg
2010-04-24 3:23 ` Arve Hjønnevåg
2010-04-25 18:15 ` Greg KH
2010-04-25 18:15 ` Greg KH
2010-04-25 19:53 ` Randy Dunlap
2010-04-26 0:00 ` tytso
2010-04-26 0:00 ` tytso
2010-04-26 0:23 ` Randy Dunlap
2010-04-26 0:23 ` Randy Dunlap
2010-04-26 0:45 ` tytso
2010-04-26 0:45 ` tytso
2010-04-26 0:50 ` Randy Dunlap
2010-04-26 0:50 ` Randy Dunlap
2010-04-26 1:39 ` [linux-pm] " Alan Stern
2010-04-26 1:39 ` Alan Stern
2010-04-26 6:24 ` Brian Swetland
2010-04-26 13:28 ` Randy Dunlap
2010-04-26 13:28 ` Randy Dunlap
2010-04-26 6:24 ` Brian Swetland
2010-04-25 19:53 ` Randy Dunlap
2010-04-23 1:08 ` [PATCH 4/9] PM: suspend_block: Switch to list of active and inactive suspend blockers Arve Hjønnevåg
2010-04-23 2:25 ` [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Matt Helsley
2010-04-23 2:25 ` [linux-pm] " Matt Helsley
2010-04-23 3:54 ` Arve Hjønnevåg
2010-04-23 3:54 ` [linux-pm] " Arve Hjønnevåg
2010-04-23 4:38 ` Greg KH
2010-04-23 4:38 ` [linux-pm] " Greg KH
2010-04-23 8:43 ` Pavel Machek
2010-04-23 16:43 ` Alan Stern
2010-04-23 16:43 ` [linux-pm] " Alan Stern
2010-04-24 3:20 ` Arve Hjønnevåg
2010-04-24 3:20 ` [linux-pm] " Arve Hjønnevåg
2010-04-24 5:55 ` Pavel Machek
2010-04-24 5:55 ` [linux-pm] " Pavel Machek
2010-04-24 14:44 ` Alan Stern
2010-04-25 22:34 ` Arve Hjønnevåg
2010-04-25 22:34 ` [linux-pm] " Arve Hjønnevåg
2010-04-26 19:25 ` Alan Stern
2010-04-27 4:04 ` Arve Hjønnevåg
2010-04-27 18:33 ` Alan Stern
2010-04-27 18:33 ` [linux-pm] " Alan Stern
2010-04-27 22:03 ` Rafael J. Wysocki
2010-04-27 22:03 ` [linux-pm] " Rafael J. Wysocki
2010-04-27 23:22 ` Arve Hjønnevåg
2010-04-27 23:22 ` [linux-pm] " Arve Hjønnevåg
2010-04-27 4:04 ` Arve Hjønnevåg
2010-04-26 19:25 ` Alan Stern
2010-04-24 14:44 ` Alan Stern
2010-04-24 1:53 ` tytso
2010-04-24 5:39 ` Pavel Machek
2010-04-24 5:39 ` Pavel Machek
2010-04-24 1:53 ` tytso
2010-04-23 8:43 ` Pavel Machek
2010-04-23 16:33 ` [PATCH 1/9] PM: Add suspend block api Alan Stern
2010-04-23 16:33 ` Alan Stern
2010-04-23 16:45 ` [linux-pm] " Alan Stern
2010-04-23 16:45 ` Alan Stern
2010-04-24 2:15 ` Arve Hjønnevåg
2010-04-24 2:15 ` Arve Hjønnevåg
2010-04-24 2:30 ` Alan Stern
2010-04-24 2:30 ` Alan Stern
2010-04-24 3:14 ` Arve Hjønnevåg
2010-04-24 3:14 ` Arve Hjønnevåg [this message]
2010-04-23 4:39 ` [linux-pm] [PATCH 0/9] Suspend block api (version 4) Greg KH
2010-04-23 4:39 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-05-06 4:18 [RFC][PATCH 0/9] Suspend block api (version 3) Arve Hjønnevåg
2009-05-06 4:18 ` [PATCH 1/9] PM: Add suspend block api Arve Hjønnevåg
2009-04-30 3:09 [RFC][PATCH 0/9] Suspend block api (version 2) Arve Hjønnevåg
2009-04-30 3:10 ` [PATCH 1/9] PM: Add suspend block api Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2sd6200be21004232014r806b0c67ucf5508ac7ff50a44@mail.gmail.com \
--to=arve@android.com \
--cc=akpm@linux-foundation.org \
--cc=cornelia.huck@de.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=maximlevitsky@gmail.com \
--cc=nigel@tuxonice.net \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.