From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753263Ab3JNHaF (ORCPT ); Mon, 14 Oct 2013 03:30:05 -0400 Received: from plane.gmane.org ([80.91.229.3]:35959 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259Ab3JNHaE (ORCPT ); Mon, 14 Oct 2013 03:30:04 -0400 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Romain Izard Subject: Re: [PATCH 2/4] drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe Date: Mon, 14 Oct 2013 07:28:09 +0000 (UTC) Message-ID: References: <1381681071-6021-1-git-send-email-wsa@the-dreams.de> <1381681071-6021-3-git-send-email-wsa@the-dreams.de> X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 146.187.3.109.rev.sfr.net User-Agent: slrn/pre1.0.0-18 (Linux) Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013-10-13, Wolfram Sang wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij (personally at LCE13) > Signed-off-by: Wolfram Sang > --- > drivers/mmc/host/mvsdio.c | 7 +------ > drivers/mmc/host/omap_hsmmc.c | 7 ------- > drivers/mmc/host/sdhci-esdhc-imx.c | 8 -------- > 3 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 06c5b0b..8c9f448 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include > #include > @@ -685,7 +684,7 @@ static int __init mvsd_probe(struct platform_device *pdev) > const struct mbus_dram_target_info *dram; > struct resource *r; > int ret, irq; > - struct pinctrl *pinctrl; > + int gpio_card_detect, gpio_write_protect; > This new line does not belong to this patch. > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > irq = platform_get_irq(pdev, 0); > @@ -702,10 +701,6 @@ static int __init mvsd_probe(struct platform_device *pdev) > host->mmc = mmc; > host->dev = &pdev->dev; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, "no pins associated\n"); > - > /* > * Some non-DT platforms do not pass a clock, and the clock > * frequency is passed through platform_data. On DT platforms, Best regards, -- Romain Izard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Izard Subject: Re: [PATCH 2/4] drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe Date: Mon, 14 Oct 2013 07:28:09 +0000 (UTC) Message-ID: References: <1381681071-6021-1-git-send-email-wsa@the-dreams.de> <1381681071-6021-3-git-send-email-wsa@the-dreams.de> Return-path: Received: from plane.gmane.org ([80.91.229.3]:48601 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235Ab3JNH2d (ORCPT ); Mon, 14 Oct 2013 03:28:33 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VVcZr-00008X-MB for linux-mmc@vger.kernel.org; Mon, 14 Oct 2013 09:28:31 +0200 Received: from 146.187.3.109.rev.sfr.net ([109.3.187.146]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 14 Oct 2013 09:28:31 +0200 Received: from romain.izard.pro by 146.187.3.109.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 14 Oct 2013 09:28:31 +0200 Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: linux-mmc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org On 2013-10-13, Wolfram Sang wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij (personally at LCE13) > Signed-off-by: Wolfram Sang > --- > drivers/mmc/host/mvsdio.c | 7 +------ > drivers/mmc/host/omap_hsmmc.c | 7 ------- > drivers/mmc/host/sdhci-esdhc-imx.c | 8 -------- > 3 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 06c5b0b..8c9f448 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include > #include > @@ -685,7 +684,7 @@ static int __init mvsd_probe(struct platform_device *pdev) > const struct mbus_dram_target_info *dram; > struct resource *r; > int ret, irq; > - struct pinctrl *pinctrl; > + int gpio_card_detect, gpio_write_protect; > This new line does not belong to this patch. > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > irq = platform_get_irq(pdev, 0); > @@ -702,10 +701,6 @@ static int __init mvsd_probe(struct platform_device *pdev) > host->mmc = mmc; > host->dev = &pdev->dev; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, "no pins associated\n"); > - > /* > * Some non-DT platforms do not pass a clock, and the clock > * frequency is passed through platform_data. On DT platforms, Best regards, -- Romain Izard