From: Simon Ser <contact@emersion.fr>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 8/8] drm/doc: document the type plane property
Date: Thu, 17 Dec 2020 11:09:17 +0000 [thread overview]
Message-ID: <l8nD7pGzktK4GDrnjyZEBoStfFM0qfKm2h4rnZZB3Fr5VUK2lSgGXHXwCw3HlVbCnHM9WqDykkrHqJNNeX0Qo1h6ymVDtrKIcaCU4U2nLSU=@emersion.fr> (raw)
In-Reply-To: <CAKMK7uFbG+x0kHQfZjqwmRQ7zQjTDSBo2FYkoLHG9yf1mzApMA@mail.gmail.com>
On Thursday, December 17th, 2020 at 11:52 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > + * capability, the plane type is just a hint and is mostly superseded by
> > > > + * atomic test-only commits. The type hint can still be used to come up
> > > > + * more easily with a plane configuration accepted by the driver.
> > > > + *
> > > > + * The value of this property can be one of the following:
> > > > + *
> > > > + * "Primary":
> > > > + * To light up a CRTC, attaching a primary plane is the most likely to
> > > > + * work if it covers the whole CRTC and doesn't have scaling or
> > > > + * cropping set up.
> > > > + *
> > > > + * Drivers may support more features for the primary plane, user-space
> > > > + * can find out with test-only atomic commits.
> > >
> > > We need to mention here that this is the implicit plane used by the
> > > PAGE_FLIP and SETCRTC ioctl (maybe spell them out in full since these are
> > > userspace docs).
> >
> > I intentionally didn't write that down here, because as previously discussed,
> > user-space has no way to guess the drm_crtc.{primary,cursor} pointers, so
> > user-space cannot guess which planes will be used for legacy IOCTLs. Adding any
> > hint that user-space _could_ do it will result in broken user-space.
>
> Hm then at least a warning that userspace must not mix legacy ioctls
> with using primary planes explicitly, since havoc will ensue? More
> relevant for cursor planes, since some compositors do use atomic +
> legacy cursor planes, but imo good to have the same blurb with the
> list of relevant ioctls for each.
Oh, right, good idea, this sounds important. Will add in v2.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-12-17 11:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 20:22 [PATCH 0/8] drm/doc: improve plane property docs Simon Ser
2020-12-16 20:22 ` [PATCH 1/8] drm/doc: rename FB_DAMAGE_CLIPS section Simon Ser
2020-12-16 20:22 ` [PATCH 2/8] drm/doc: move composition function docs to new section Simon Ser
2020-12-16 20:22 ` [PATCH 3/8] drm/doc: move damage tracking functions " Simon Ser
2020-12-16 20:22 ` [PATCH 4/8] drm/doc: move color management functions under CRTC section Simon Ser
2020-12-16 21:14 ` Daniel Vetter
2020-12-16 20:22 ` [PATCH 5/8] drm/doc: the KMS properties section is for user-space devs Simon Ser
2020-12-16 21:14 ` Daniel Vetter
2020-12-16 20:22 ` [PATCH 6/8] drm/doc: introduce new section for standard plane properties Simon Ser
2020-12-16 21:19 ` Daniel Vetter
2020-12-16 20:22 ` [PATCH 7/8] drm/doc: fix drm_plane_type docs Simon Ser
2020-12-16 21:19 ` Daniel Vetter
2020-12-17 10:37 ` Simon Ser
2020-12-17 10:50 ` Daniel Vetter
2020-12-17 11:07 ` Simon Ser
2020-12-16 20:22 ` [PATCH 8/8] drm/doc: document the type plane property Simon Ser
2020-12-16 21:23 ` Daniel Vetter
2020-12-17 10:40 ` Simon Ser
2020-12-17 10:52 ` Daniel Vetter
2020-12-17 11:09 ` Simon Ser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='l8nD7pGzktK4GDrnjyZEBoStfFM0qfKm2h4rnZZB3Fr5VUK2lSgGXHXwCw3HlVbCnHM9WqDykkrHqJNNeX0Qo1h6ymVDtrKIcaCU4U2nLSU=@emersion.fr' \
--to=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.