All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: David Miller <davem@davemloft.net>, shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, jarkao2@gmail.com,
	herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [RFC] gro: Is it ok to share a single napi from several devs ?
Date: Sat, 28 Aug 2010 21:07:10 -0700	[thread overview]
Message-ID: <lexmby2wgxuu9h0vljo2a16m.1283054830069@email.android.com> (raw)

I am not really worried. about sky2 dual port since the dual port boards are rare. I might have one of the few in use 

David Miller <davem@davemloft.net> wrote:

>From: Stephen Hemminger <shemminger@vyatta.com>
>Date: Sat, 28 Aug 2010 15:31:24 -0700
>
>> On Sat, 28 Aug 2010 14:41:30 -0700 (PDT)
>> David Miller <davem@davemloft.net> wrote:
>> 
>>> Since netpoll does similar things, this means both NAPI and netpoll
>>> cannot function properly with SKY2's second port.  It will only work
>>> right on the first port.
>> 
>> I knew netpoll was broken on second port.
>
>Well, now we know that GRO is too :-)
>
>If we wish to keep the one-to-one mapping of NAPI contexts to
>interrupt sources, what we can do is provide some kind of "dev list".
>
>The other option is to register two NAPI contexts and schedule them
>both on an interrupt.
>
>But in both cases, detecting the end of polling, and thus when to turn
>the interrupts back on, is non-trivial.
>
>I really don't like either solution, therefore, so I'll try to brain
>storm on this a bit more.

             reply	other threads:[~2010-08-29  4:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-29  4:07 Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-27 20:50 [PATCH] net: Fix vlan_gro_frags vs netpoll and bonding paths Jarek Poplawski
2010-08-28  0:13 ` Herbert Xu
2010-08-28  9:44   ` Jarek Poplawski
2010-08-28 10:54     ` [RFC] gro: Is it ok to share a single napi from several devs ? Eric Dumazet
2010-08-28 14:31       ` Jarek Poplawski
2010-08-28 14:48         ` Eric Dumazet
2010-08-28 15:16           ` Jarek Poplawski
2010-08-28 17:14           ` Stephen Hemminger
2010-08-28 21:41             ` David Miller
2010-08-28 22:31               ` Stephen Hemminger
2010-08-28 22:33                 ` David Miller
2010-08-29  9:59               ` Jarek Poplawski
2010-08-29 17:06                 ` David Miller
2010-08-29 18:39                   ` Eric Dumazet
2010-08-30  6:42                     ` Jarek Poplawski
2010-08-30 15:57                       ` Stephen Hemminger
2010-08-30 16:50                         ` David Miller
2010-08-30 18:36                           ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lexmby2wgxuu9h0vljo2a16m.1283054830069@email.android.com \
    --to=stephen.hemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.