All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu CASTET <matthieu.castet@parrot.fr>
To: linux-mtd@lists.infradead.org
Subject: 2.6.20 : BUG in nand_do_read_oob with MTD_OOB_PLACE ?
Date: Fri, 9 Feb 2007 15:09:59 +0000 (UTC)	[thread overview]
Message-ID: <loom.20070209T155657-545@post.gmane.org> (raw)

Hi,

2.6.20 nand mtd seems to read wrongly oob in MTD_OOB_PLACE.
If I dump a page with uboot I get [1] and if I dump it with nanddump I get [2].
As you could can see OOB doesn't match. Moreover the 2 snd 8 bytes OOB data
given by nanddump are the 1st 8 bytes OOB of the next page.

If we look in nand_base.c, we saw that in case of MTD_OOB_PLACE, the len of oob
is set to chip->ecc.layout->oobavail. This seems wrong as user expect to be
mtd->oobsize.

Does this bug is know ?

It seems quite critical as it impact on jffs2 (at least
jffs2_check_nand_cleanmarker).


Matthieu

[1]
        3f 00 57 00 0c 00 00 48  10 00 00 48 13 03 00 00                       
                                              
        00 40 00 30 00 00 70 30  74 01 00 40 03 20 c2 e3                       
                                              
        02 20 80 e0 02 00 50 e1  00 30 a0 e1 0e f0 a0 01                       
                                              
OOB:                                                                           
                                              
        96 a5 96 9a 05 ff c0 43                                                
                                              
        05 00 18 36 05 00 ff 0f
[2]
[....]
0x000001d0: 3f 00 57 00 0c 00 00 48 10 00 00 48 13 03 00 00                    
                                              
0x000001e0: 00 40 00 30 00 00 70 30 74 01 00 40 03 20 c2 e3                    
                                              
0x000001f0: 02 20 80 e0 02 00 50 e1 00 30 a0 e1 0e f0 a0 01                    
                                              
  OOB Data: 96 a5 96 9a 05 ff c0 43 fc 03 00 9a 05 ff c0 43

             reply	other threads:[~2007-02-09 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 15:09 Matthieu CASTET [this message]
2007-02-15 15:37 ` 2.6.20 : BUG in nand_do_read_oobwith MTD_OOB_PLACE ? Matthieu CASTET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20070209T155657-545@post.gmane.org \
    --to=matthieu.castet@parrot.fr \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.