From: Matthieu CASTET <matthieu.castet@parrot.fr>
To: linux-mtd@lists.infradead.org
Subject: Re: PATCH: calculate s3c2410 NAND timing values more accurately
Date: Tue, 13 Feb 2007 10:46:40 +0000 (UTC) [thread overview]
Message-ID: <loom.20070213T114255-129@post.gmane.org> (raw)
In-Reply-To: f383264b0702121139w7b5dc50ds8bdd96b708c1336d@mail.gmail.com
Hi,
Matt Reimer <mattjreimer <at> gmail.com> writes:
>
> Calculate NAND timing values more accurately on S3C2410, 2412, and
> 2440, whose registers differ slightly:
>
> Enforce the TACLS max value as 3 on 2440 but 7 on 2410/2412.
>
> Also, make it possible to specify a value of 0 on 2412/2440.
>
If you remove the "if (result < 1) result = 1;" check in s3c_nand_calc_rate, I
believe you should check for twrph0 or twrph1 equal 0 in s3c2410_nand_inithw (ie
if (tacls < 0 || twrph0 <= 0 || twrph1 <= 0) { return error).
Matthieu
next prev parent reply other threads:[~2007-02-13 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 19:39 PATCH: calculate s3c2410 NAND timing values more accurately Matt Reimer
2007-02-13 10:46 ` Matthieu CASTET [this message]
2007-02-13 11:09 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20070213T114255-129@post.gmane.org \
--to=matthieu.castet@parrot.fr \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.