* What's cooking in git.git (Jun 2013, #04; Tue, 11)
@ 2013-06-11 22:34 Junio C Hamano
2013-06-11 23:24 ` Felipe Contreras
2013-06-12 13:56 ` Jakub Narebski
0 siblings, 2 replies; 6+ messages in thread
From: Junio C Hamano @ 2013-06-11 22:34 UTC (permalink / raw)
To: git
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
You can find the changes described here in the integration branches
of the repositories listed at
http://git-blame.blogspot.com/p/git-public-repositories.html
--------------------------------------------------
[Graduated to "master"]
* ar/wildmatch-foldcase (2013-06-02) 1 commit
(merged to 'next' on 2013-06-04 at 3180bcc)
+ wildmatch: properly fold case everywhere
The wildmatch engine did not honor WM_CASEFOLD option correctly.
* cb/log-follow-with-combined (2013-05-28) 1 commit
(merged to 'next' on 2013-06-04 at d5bf4f3)
+ fix segfault with git log -c --follow
* cm/gitweb-project-list-persistent-cgi-fix (2013-06-07) 1 commit
(merged to 'next' on 2013-06-07 at b16ca1f)
+ gitweb: fix problem causing erroneous project list
"gitweb" forgot to clear a global variable $search_regexp upon each
request, mistakenly carrying over the previous search to a new one
when used as a persistent CGI.
* cr/git-work-tree-sans-git-dir (2013-06-03) 1 commit
(merged to 'next' on 2013-06-04 at bebedca)
+ git.txt: remove stale comment regarding GIT_WORK_TREE
These days, "git --work-tree=there cmd" without specifying an
explicit --git-dir=here will do the usual discovery, but we had a
description of older behaviour in the documentation.
* fc/at-head (2013-05-08) 13 commits
(merged to 'next' on 2013-06-04 at f334a2a)
+ sha1_name: compare variable with constant, not constant with variable
+ Add new @ shortcut for HEAD
+ sha1_name: refactor reinterpret()
+ sha1_name: check @{-N} errors sooner
+ sha1_name: reorganize get_sha1_basic()
+ sha1_name: don't waste cycles in the @-parsing loop
+ sha1_name: remove unnecessary braces
+ sha1_name: remove no-op
+ tests: at-combinations: @{N} versus HEAD@{N}
+ tests: at-combinations: increase coverage
+ tests: at-combinations: improve nonsense()
+ tests: at-combinations: check ref names directly
+ tests: at-combinations: simplify setup
Instead of typing four capital letters "HEAD", you can say "@".
* fc/completion-less-ls-remote (2013-06-02) 1 commit
(merged to 'next' on 2013-06-03 at 6624f0b)
+ completion: avoid ls-remote in certain scenarios
* fc/do-not-use-the-index-in-add-to-index (2013-06-03) 2 commits
(merged to 'next' on 2013-06-04 at 94e7b60)
+ read-cache: trivial style cleanups
+ read-cache: fix wrong 'the_index' usage
* fc/remote-bzr (2013-05-28) 8 commits
(merged to 'next' on 2013-06-04 at a603082)
+ remote-bzr: add fallback check for a partial clone
+ remote-bzr: reorganize the way 'wanted' works
+ remote-bzr: trivial cleanups
+ remote-bzr: change global repo
+ remote-bzr: delay cloning/pulling
+ remote-bzr: simplify get_remote_branch()
+ remote-bzr: fix for files with spaces
+ remote-bzr: recover from failed clones
* fc/remote-hg (2013-05-28) 50 commits
(merged to 'next' on 2013-06-04 at 9ee7dab)
+ remote-hg: add support for --force
+ remote-hg: add support for --dry-run
+ remote-hg: check if a fetch is needed
+ remote-hg: trivial cleanup
+ remote-helpers: improve marks usage
+ remote-hg: add check_push() helper
+ remote-hg: add setup_big_push() helper
+ remote-hg: remove files before modifications
+ remote-hg: improve lightweight tag author
+ remote-hg: use remote 'default' not local one
+ remote-hg: improve branch listing
+ remote-hg: simplify branch_tip()
+ remote-hg: check diverged bookmarks
+ remote-hg: pass around revision refs
+ remote-hg: implement custom checkheads()
+ remote-hg: implement custom push()
+ remote-hg: only update necessary revisions
+ remote-hg: force remote bookmark push selectively
+ remote-hg: reorganize bookmark handling
+ remote-hg: add test for failed double push
+ remote-hg: add test for big push
+ remote-hg: add test for new bookmark special
+ remote-hg: add test for bookmark diverge
+ remote-hg: add test for diverged push
+ remote-hg: add test to push new bookmark
+ remote-hg: add remote tests
+ remote-hg: update bookmarks when using a remote
+ remote-hg: add check_bookmark() test helper
+ remote-bzr: simplify test checks
+ remote-hg: add tests for 'master' bookmark
+ remote-hg: always point HEAD to master
+ remote-hg: improve progress calculation
+ remote-hg: trivial cleanups
+ remote-hg: ensure remote rebasing works
+ remote-hg: upgrade version 1 marks
+ remote-hg: switch from revisions to SHA-1 noteids
+ remote-hg: add version checks to the marks
+ remote-hg: improve node traversing
+ remote-hg: shuffle some code
+ remote-hg: use a shared repository store
+ remote-hg: load all extensions
+ remote-hg: test: simplify previous branch checkout
+ remote-helpers: test: simplify remote URLs
+ remote-helpers: tests: general improvements
+ remote-helpers: test: cleanup style
+ remote-helpers: test: cleanup white-spaces
+ remote-hg: trivial reorganization
+ remote-hg: test: be a little more quiet
+ remote-hg: tests: fix hg merge
+ remote-helpers: tests: use python directly
* jk/test-exit-code-by-signal (2013-06-06) 2 commits
(merged to 'next' on 2013-06-06 at 6fdea1b)
+ t0005: skip signal death exit code test on Windows
(merged to 'next' on 2013-06-03 at 25af892)
+ t0005: test git exit code from signal death
* mm/mediawiki-https-fail-message (2013-05-29) 1 commit
(merged to 'next' on 2013-06-04 at fb2671c)
+ git-remote-mediawiki: better error message when HTTP(S) access fails
Hint users when https:// connection failed to check the
certificate; it is a good hint if we assumie that it is common
error for the end users to make.
* nd/warn-ambiguous-object-name (2013-05-29) 1 commit
(merged to 'next' on 2013-06-04 at e87c9d1)
+ get_sha1: warn about full or short object names that look like refs
"git cmd <name>", when <name> happens to be a 40-hex string,
directly uses the 40-hex string as an object name, even if a ref
"refs/<some hierarchy>/<name>" exists. This disambiguation order
is unlikely to change, but we should warn about the ambiguity just
like we warn when more than one refs/ hierachies share the same
name.
* rj/mingw-cygwin (2013-05-08) 2 commits
(merged to 'next' on 2013-06-04 at 308fdb4)
+ cygwin: Remove the CYGWIN_V15_WIN32API build variable
+ mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE
Update build for Cygwin 1.[57]. Torsten Bögershausen reports that
this is fine with Cygwin 1.7 ($gmane/225824) so let's try moving it
ahead.
* rr/die-on-missing-upstream (2013-06-02) 2 commits
(merged to 'next' on 2013-06-03 at 00847ea)
+ sha1_name: fix error message for @{<N>}, @{<date>}
+ sha1_name: fix error message for @{u}
When a reflog notation is used for implicit "current branch", we
did not say which branch and worse said "branch ''".
* rr/diffcore-pickaxe-doc (2013-06-03) 2 commits
(merged to 'next' on 2013-06-04 at 67d1fc7)
+ diffcore-pickaxe doc: document -S and -G properly
+ diffcore-pickaxe: make error messages more consistent
Update the low-level diffcore documentation on -S/-G and --pickaxe-all.
* rr/maint-fetch-tag-doc-asterisks (2013-06-07) 1 commit
(merged to 'next' on 2013-06-07 at bfa4e7b)
+ fetch-options.txt: prevent a wildcard refspec from getting misformatted
* rr/rebase-autostash (2013-05-29) 7 commits
(merged to 'next' on 2013-06-04 at 16f7c54)
+ rebase: implement --[no-]autostash and rebase.autostash
+ rebase --merge: return control to caller, for housekeeping
+ rebase -i: return control to caller, for housekeeping
+ am: return control to caller, for housekeeping
+ rebase: prepare to do generic housekeeping
+ rebase -i: don't error out if $state_dir already exists
+ am: tighten a conditional that checks for $dotest
* rs/unpack-trees-plug-leak (2013-06-02) 7 commits
(merged to 'next' on 2013-06-03 at 97e7b6d)
+ unpack-trees: free cache_entry array members for merges
+ diff-lib, read-tree, unpack-trees: mark cache_entry array paramters const
+ diff-lib, read-tree, unpack-trees: mark cache_entry pointers const
+ unpack-trees: create working copy of merge entry in merged_entry
+ unpack-trees: factor out dup_entry
+ read-cache: mark cache_entry pointers const
+ cache: mark cache_entry pointers const
* tr/sha1-file-silence-loose-object-info-under-prune-race (2013-06-03) 1 commit
(merged to 'next' on 2013-06-04 at e891bb8)
+ sha1_file: silence sha1_loose_object_info
* tr/test-commit-only-on-orphan (2013-06-02) 1 commit
(merged to 'next' on 2013-06-03 at b1864fd)
+ Test 'commit --only' after 'checkout --orphan'
* xq/credential-osxkeychain (2013-05-28) 1 commit
(merged to 'next' on 2013-06-04 at a4ee0e0)
+ credential-osxkeychain: support more protocols
--------------------------------------------------
[New Topics]
* jc/topo-author-date-sort (2013-06-11) 4 commits
- log: --author-date-order
- sort-in-topological-order: use prio-queue
- prio-queue: priority queue of pointers to structs
- toposort: rename "lifo" field
(this branch uses jk/commit-info-slab; is tangled with jc/show-branch.)
"git log" learned the "--author-date-order" option, with which the
output is topologically sorted and commits in parallel histories
are shown intermixed together based on the author timestamp.
Will merge to 'next'.
* fc/makefile (2013-06-09) 4 commits
- Makefile: use $^ to avoid listing prerequisites on the command line
- build: do not install git-remote-testgit
- build: generate and clean test scripts
- Merge branch 'js/transport-helper-error-reporting-fix' into fc/makefile
Will merge to 'next'.
* fc/show-non-empty-errors-in-test (2013-06-09) 1 commit
- test: test_must_be_empty helper
Will merge to 'next'.
* nd/traces (2013-06-09) 2 commits
- git.txt: document GIT_TRACE_PACKET
- core: use env variable instead of config var to turn on logging pack access
Will merge to 'next'.
* rr/complete-difftool-fixup (2013-06-09) 2 commits
(merged to 'next' on 2013-06-11 at fe91170)
+ completion: show can take both revlist and paths
+ completion: difftool takes both revs and files
(this branch is tangled with rr/complete-difftool.)
Replaces rr/complete-difftool.
Will merge to 'master'.
* rr/triangle-push-fix (2013-06-09) 4 commits
- t/push-default: test pushdefault with all modes
- t/push-default: generalize test_push_{success, commit}
- push: make upstream, simple work with pushdefault
- t/push-default: remove redundant test_config lines
Tries to apply the 'push.default = upstream' semantics to
triangular workflow where it does not quite apply.
Will be worked further.
* rs/discard-index-discard-array (2013-06-09) 2 commits
- read-cache: free cache in discard_index
- read-cache: add simple performance test
Will merge to 'next'.
* cm/remote-mediawiki (2013-06-11) 1 commit
- git-remote-mediawiki: display message when launched directly
Will merge to 'next'.
* jg/status-config (2013-06-11) 2 commits
- status:introduce status.branch to enable --branch by default
- status: introduce status.short to enable --short by default
Will merge to 'next'.
* mh/loose-refs-race-with-pack-ref (2013-06-11) 4 commits
- resolve_ref_unsafe(): close race condition reading loose refs
- resolve_ref_unsafe(): nest reference-reading code in an infinite loop
- resolve_ref_unsafe(): handle the case of an SHA-1 within loop
- resolve_ref_unsafe(): extract function handle_missing_loose_ref()
--------------------------------------------------
[Stalled]
* jh/shorten-refname (2013-05-07) 4 commits
- t1514: refname shortening is done after dereferencing symbolic refs
- shorten_unambiguous_ref(): Fix shortening refs/remotes/origin/HEAD to origin
- t1514: Demonstrate failure to correctly shorten "refs/remotes/origin/HEAD"
- t1514: Add tests of shortening refnames in strict/loose mode
When remotes/origin/HEAD is not a symbolic ref, "rev-parse
--abbrev-ref remotes/origin/HEAD" ought to show "origin", not
"origin/HEAD", which is fixed with this series (if it is a symbolic
ref that points at remotes/origin/something, then it should show
"origin/something" and it already does).
Expecting a reroll, as an early part of a larger series.
* jk/submodule-subdirectory-ok (2013-04-24) 3 commits
- submodule: fix quoting in relative_path()
- submodule: drop the top-level requirement
- rev-parse: add --prefix option
Allow various subcommands of "git submodule" to be run not from the
top of the working tree of the superproject.
Waiting for a reroll.
* jl/submodule-mv (2013-04-23) 5 commits
- submodule.c: duplicate real_path's return value
- rm: delete .gitmodules entry of submodules removed from the work tree
- Teach mv to update the path entry in .gitmodules for moved submodules
- Teach mv to move submodules using a gitfile
- Teach mv to move submodules together with their work trees
"git mv A B" when moving a submodule A does "the right thing",
inclusing relocating its working tree and adjusting the paths in
the .gitmodules file.
Waiting for a reroll.
* jk/list-objects-sans-blobs (2013-06-06) 4 commits
. archive: ignore blob objects when checking reachability
. list-objects: optimize "revs->blob_objects = 0" case
. upload-archive: restrict remote objects with reachability check
. clear parsed flag when we free tree buffers
Attempt to allow "archive --remote=$there $arbitrary_sha1" while
keeping the reachability safety.
Seems to break some tests in a trivial and obvious way.
* fc/remote-helpers-use-specified-python (2013-05-28) 4 commits
- remote-helpers: add exec-path links
- remote-helpers: allow direct test execution
- remote-helpers: rename tests
- remote-helpers: generate scripts
I do not particularly think the second from the bottom is a good
change, but it takes the remainder of the series hostage.
Waiting for a reroll.
* jk/packed-refs-race (2013-05-06) 4 commits
. for_each_ref: load all loose refs before packed refs
. get_packed_refs: reload packed-refs file when it changes
. add a stat_validity struct
. resolve_ref: close race condition for packed refs
Will be rerolled.
* mg/more-textconv (2013-05-10) 7 commits
- grep: honor --textconv for the case rev:path
- grep: allow to use textconv filters
- t7008: demonstrate behavior of grep with textconv
- cat-file: do not die on --textconv without textconv filters
- show: honor --textconv for blobs
- diff_opt: track whether flags have been set explicitly
- t4030: demonstrate behavior of show with textconv
Make "git grep" and "git show" pay attention to --textconv when
dealing with blob objects.
I thought this was pretty well designed and executed, but it seems
there are some doubts on the list; kicking back to 'pu'.
* mh/multimail (2013-04-21) 1 commit
- git-multimail: a replacement for post-receive-email
Waiting for the initial history to pull from.
$gmane/223564
* jc/format-patch (2013-04-22) 2 commits
- format-patch: --inline-single
- format-patch: rename "no_inline" field
A new option to send a single patch to the standard output to be
appended at the bottom of a message. I personally have no need for
this, but it was easy enough to cobble together. Tests, docs and
stripping out more MIMEy stuff are left as exercises to interested
parties.
Not ready for inclusion.
Will discard unless we hear from anybody who is interested in
tying its loose ends.
* jk/gitweb-utf8 (2013-04-08) 4 commits
- gitweb: Fix broken blob action parameters on blob/commitdiff pages
- gitweb: Don't append ';js=(0|1)' to external links
- gitweb: Make feed title valid utf8
- gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch
Various fixes to gitweb.
Drew Northup volunteered to take a look into this.
$gmane/226216
* jc/show-branch (2013-06-07) 5 commits
- show-branch: use commit slab to represent bitflags of arbitrary width
- show-branch.c: remove "all_mask"
- show-branch.c: abstract out "flags" operation
- show-branch.c: lift all_mask/all_revs to a global static
- show-branch.c: update comment style
(this branch uses jk/commit-info-slab; is tangled with jc/topo-author-date-sort.)
Waiting for the final step to lift the hard-limit before sending it out.
--------------------------------------------------
[Cooking]
* jk/commit-info-slab (2013-06-07) 3 commits
- commit-slab: introduce a macro to define a slab for new type
- commit-slab: avoid large realloc
- commit: allow associating auxiliary info on-demand
(this branch is used by jc/show-branch and jc/topo-author-date-sort.)
Technology demonstration to show a way we could add custom
information to represent unbound number of flag bits etc. to commit
objects.
Will be in 'next' with jc/topo-author-date-sort.
* fc/sequencer-skip-quiet (2013-06-06) 5 commits
- sequencer: run post-rewrite hook
- cherry-pick: store rewritten commits
- cherry-pick: add --skip-empty option
- sequencer: avoid leaking message buffer when refusing to create an empty commit
- sequencer: remove useless indentation
The bottom three looked more or less reasonable. Execution of
post-rewrite hook could use a better refactoring from the original
code copied from builtin/commit.c, though.
Will discard the top 3, merge the rest to 'next'.
* js/test-ln-s-add (2013-06-07) 10 commits
- t4011: remove SYMLINKS prerequisite
- t6035: use test_ln_s_add to remove SYMLINKS prerequisite
- t3509, t4023, t4114: use test_ln_s_add to remove SYMLINKS prerequisite
- t3100: use test_ln_s_add to remove SYMLINKS prerequisite
- t3030: use test_ln_s_add to remove SYMLINKS prerequisite
- t0000: use test_ln_s_add to remove SYMLINKS prerequisite
- tests: use test_ln_s_add to remove SYMLINKS prerequisite (trivial cases)
- tests: introduce test_ln_s_add
- t3010: modernize style
- test-chmtime: Fix exit code on Windows
Many tests that check the behaviour of symbolic links stored in the
index or the tree objects do not have to be skipped on a filesystem
that lack symbolic link support.
Will merge to 'next'.
* mt/send-email-cc-match-fix (2013-06-05) 7 commits
(merged to 'next' on 2013-06-06 at e4d0831)
+ test-send-email: test for pre-sanitized self name
+ t/send-email: test suppress-cc=self with non-ascii
+ t/send-email: add test with quoted sender
+ send-email: make --suppress-cc=self sanitize input
+ t/send-email: test suppress-cc=self on cccmd
+ send-email: fix suppress-cc=self on cccmd
+ t/send-email.sh: add test for suppress-cc=self
Logic git-send-email used to suppress cc mishandled names like "A
U. Thor" <author@example.xz>, where the human readable part needs
to be quoted (the user input may not have the double quotes around
the name, and comparison was done between quoted and unquoted
strings).
Will merge to 'master'.
* rr/complete-difftool (2013-06-09) 4 commits
(merged to 'next' on 2013-06-09 at 2ee40cb)
+ Revert 77c1305 and 3c3b46b
(merged to 'next' on 2013-06-07 at 90e5f58)
+ completion: add deprecated __git_complete_file ()
(merged to 'next' on 2013-06-04 at 01c7611)
+ completion: clarify ls-tree, archive, show completion
+ completion: difftool takes both revs and files
(this branch is tangled with rr/complete-difftool-fixup.)
Update command line completion (in contrib/) to use a better named
completion helper function for commands that take revisions and
paths.
Reverted, to be replaced with rr/complete-difftool-fixup.
* bp/mediawiki-credential (2013-06-05) 1 commit
(merged to 'next' on 2013-06-05 at ea07ec1)
+ git-remote-mediawiki: use Git.pm functions for credentials
The bridge to MediaWiki has been updated to use the credential
helper interface in Git.pm, losing its own and the original
implementation the former was based on.
Will merge to 'master'.
* mz/rebase-tests (2013-06-07) 7 commits
- tests: move test for rebase messages from t3400 to t3406
- t3406: modernize style
- add tests for rebasing merged history
- add tests for rebasing root
- add tests for rebasing of empty commits
- add tests for rebasing with patch-equivalence present
- add simple tests of consistency across rebase types
Will merge to 'next'.
* nd/make-wildmatch-default (2013-06-02) 1 commit
- Makefile: promote wildmatch to be the default fnmatch implementation
Will merge to 'next'.
* rr/remove-contrib-some (2013-06-02) 1 commit
(merged to 'next' on 2013-06-05 at fc15705)
+ contrib: remove continuous/ and patches/
Remove stale contrib/ material.
Will merge to 'master'.
* ap/diff-ignore-blank-lines (2013-06-10) 1 commit
- diff: add --ignore-blank-lines option
"git diff" learned a mode that ignores hunks whose change consists
only of additions and removals of blank lines, which is the same as
"diff -B" (ignore blank lines) of GNU diff.
* mh/reflife (2013-06-02) 25 commits
(merged to 'next' on 2013-06-05 at 291d863)
+ refs: document the lifetime of the args passed to each_ref_fn
+ register_ref(): make a copy of the bad reference SHA-1
+ exclude_existing(): set existing_refs.strdup_strings
+ string_list_add_refs_by_glob(): add a comment about memory management
+ string_list_add_one_ref(): rename first parameter to "refname"
+ show_head_ref(): rename first parameter to "refname"
+ show_head_ref(): do not shadow name of argument
+ add_existing(): do not retain a reference to sha1
+ do_fetch(): clean up existing_refs before exiting
+ do_fetch(): reduce scope of peer_item
+ object_array_entry: fix memory handling of the name field
+ find_first_merges(): remove unnecessary code
+ find_first_merges(): initialize merges variable using initializer
+ fsck: don't put a void*-shaped peg in a char*-shaped hole
+ object_array_remove_duplicates(): rewrite to reduce copying
+ revision: use object_array_filter() in implementation of gc_boundary()
+ object_array: add function object_array_filter()
+ revision: split some overly-long lines
+ cmd_diff(): make it obvious which cases are exclusive of each other
+ cmd_diff(): rename local variable "list" -> "entry"
+ cmd_diff(): use an object_array for holding trees
+ builtin_diff_tree(): make it obvious that function wants two entries
+ add_rev_cmdline(): make a copy of the name argument
+ fetch: make own copies of refnames
+ describe: make own copy of refname
Define memory ownership and lifetime rules for what for-each-ref
feeds to its callbacks (in short, "you do not own it, so make a
copy if you want to keep it").
Will merge to 'master'.
* jx/clean-interactive (2013-06-03) 15 commits
- test: add t7301 for git-clean--interactive
- git-clean: add documentation for interactive git-clean
- git-clean: add ask each interactive action
- git-clean: add select by numbers interactive action
- git-clean: add filter by pattern interactive action
- git-clean: use a git-add-interactive compatible UI
- git-clean: add colors to interactive git-clean
- git-clean: show items of del_list in columns
- git-clean: add support for -i/--interactive
- git-clean: refactor git-clean into two phases
- Refactor write_name_quoted_relative, remove unused params
- Refactor quote_path_relative, remove unused params
- quote.c: remove path_relative, use relative_path instead
- path.c: refactor relative_path(), not only strip prefix
- test: add test cases for relative_path
* tr/test-v-and-v-subtest-only (2013-05-16) 6 commits
- test-lib: support running tests under valgrind in parallel
- test-lib: allow prefixing a custom string before "ok N" etc.
- test-lib: valgrind for only tests matching a pattern
- test-lib: verbose mode for only tests matching a pattern
- test-lib: refactor $GIT_SKIP_TESTS matching
- test-lib: enable MALLOC_* for the actual tests
Allows N instances of tests run in parallel, each running 1/N parts
of the test suite under Valgrind, to speed things up.
The tip one may be useful in practice but is a tad ugly ;-)
There seem to be some miscounting by toggling the verbose/valgrind
mode at wrong places? Cf. $gmane/225735
Waiting for a reroll.
* fc/contrib-related (2013-06-09) 5 commits
- contrib: related: print the amount of involvement
- contrib: related: parse committish like format-patch
- contrib: related: add option to parse from committish
- contrib: related: add support for multiple patches
- Add new git-related helper to contrib
* hv/config-from-blob (2013-05-12) 5 commits
- do not die when error in config parsing of buf occurs
- teach config --blob option to parse config from database
- config: make parsing stack struct independent from actual data source
- config: drop cf validity check in get_next_char()
- config: factor out config file stack management
Waiting for a reroll.
$gmane/223964
* kb/full-history-compute-treesame-carefully-2 (2013-05-16) 15 commits
(merged to 'next' on 2013-06-05 at 193242b)
+ revision.c: make default history consider bottom commits
+ revision.c: don't show all merges for --parents
+ revision.c: discount side branches when computing TREESAME
+ revision.c: add BOTTOM flag for commits
+ simplify-merges: drop merge from irrelevant side branch
+ simplify-merges: never remove all TREESAME parents
+ t6012: update test for tweaked full-history traversal
+ revision.c: Make --full-history consider more merges
+ Documentation: avoid "uninteresting"
+ rev-list-options.txt: correct TREESAME for P
+ t6111: add parents to tests
+ t6111: allow checking the parents as well
+ t6111: new TREESAME test set
+ t6019: test file dropped in -s ours merge
+ decorate.c: compact table when growing
Major update to a very core part of the revision traversal logic to
improve culling of irrelevant parents while traversing a mergy
history.
Will merge to 'master'.
* mm/color-auto-default (2013-06-10) 2 commits
- make color.ui default to 'auto'
- config: refactor management of color.ui's default value
Flip the default for color.ui to 'auto', which is what many
tutorials recommend new users to do.
Will merge to 'next'.
* jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit
- git add: -u/-A now affects the entire working tree
Will cook in 'next' until Git 2.0.
* jc/core-checkstat-2.0 (2013-05-06) 1 commit
- core.statinfo: remove as promised in Git 2.0
Will cook in 'next' until Git 2.0.
* jc/push-2.0-default-to-simple (2013-04-03) 1 commit
- push: switch default from "matching" to "simple"
Will cook in 'next' until Git 2.0.
* jc/add-2.0-ignore-removal (2013-04-22) 1 commit
- git add <pathspec>... defaults to "-A"
Updated endgame for "git add <pathspec>" that defaults to "--all"
aka "--no-ignore-removal".
Will cook in 'next' until Git 2.0.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: What's cooking in git.git (Jun 2013, #04; Tue, 11)
2013-06-11 22:34 What's cooking in git.git (Jun 2013, #04; Tue, 11) Junio C Hamano
@ 2013-06-11 23:24 ` Felipe Contreras
2013-06-11 23:40 ` Junio C Hamano
2013-06-12 13:56 ` Jakub Narebski
1 sibling, 1 reply; 6+ messages in thread
From: Felipe Contreras @ 2013-06-11 23:24 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Tue, Jun 11, 2013 at 5:34 PM, Junio C Hamano <gitster@pobox.com> wrote:
> * fc/remote-helpers-use-specified-python (2013-05-28) 4 commits
> - remote-helpers: add exec-path links
> - remote-helpers: allow direct test execution
> - remote-helpers: rename tests
> - remote-helpers: generate scripts
>
> I do not particularly think the second from the bottom is a good
> change, but it takes the remainder of the series hostage.
>
> Waiting for a reroll.
Waiting for a reroll? This is the first time I hear you are not going
to merge these.
You say actions have consequences... well, you are right, you can stop
waiting for a reroll.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: What's cooking in git.git (Jun 2013, #04; Tue, 11)
2013-06-11 23:24 ` Felipe Contreras
@ 2013-06-11 23:40 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2013-06-11 23:40 UTC (permalink / raw)
To: Felipe Contreras; +Cc: git
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Tue, Jun 11, 2013 at 5:34 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> * fc/remote-helpers-use-specified-python (2013-05-28) 4 commits
>> - remote-helpers: add exec-path links
>> - remote-helpers: allow direct test execution
>> - remote-helpers: rename tests
>> - remote-helpers: generate scripts
>>
>> I do not particularly think the second from the bottom is a good
>> change, but it takes the remainder of the series hostage.
>>
>> Waiting for a reroll.
>
> Waiting for a reroll? This is the first time I hear you are not going
> to merge these.
>
> You say actions have consequences... well, you are right, you can stop
> waiting for a reroll.
It has been listed in that state in the previous issue #03 as well.
And if you do not want to reroll, that is fine. We can discard it
for now and the next person who finds the need to can redo the
change.
Will discard the topic, then.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: What's cooking in git.git (Jun 2013, #04; Tue, 11)
2013-06-11 22:34 What's cooking in git.git (Jun 2013, #04; Tue, 11) Junio C Hamano
2013-06-11 23:24 ` Felipe Contreras
@ 2013-06-12 13:56 ` Jakub Narebski
2013-06-12 19:49 ` Jeff King
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Narebski @ 2013-06-12 13:56 UTC (permalink / raw)
To: git
Junio C Hamano <gitster <at> pobox.com> writes:
> * rr/remove-contrib-some (2013-06-02) 1 commit
> (merged to 'next' on 2013-06-05 at fc15705)
> + contrib: remove continuous/ and patches/
>
> Remove stale contrib/ material.
>
> Will merge to 'master'.
What about contrib/blameview by Aneesh Kumar K.V <aneesh.kumar@gmail.com>
and Jeff King <peff@peff.net>?
It is also 6 years old, uses GTK 2.x (via Gtk2 Perl bindings), "git gui
blame" also uses incremental mode moreover comparing blame with and without
code movement detection.
Though this was intended more as a demo of using incremental blame... (c.f.
contrib/examples).
--
Jakub Narębski
(via GMane)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: What's cooking in git.git (Jun 2013, #04; Tue, 11)
2013-06-12 13:56 ` Jakub Narebski
@ 2013-06-12 19:49 ` Jeff King
2013-06-12 22:02 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Jeff King @ 2013-06-12 19:49 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Junio C Hamano, git
On Wed, Jun 12, 2013 at 01:56:20PM +0000, Jakub Narebski wrote:
> Junio C Hamano <gitster <at> pobox.com> writes:
>
> > * rr/remove-contrib-some (2013-06-02) 1 commit
> > (merged to 'next' on 2013-06-05 at fc15705)
> > + contrib: remove continuous/ and patches/
> >
> > Remove stale contrib/ material.
> >
> > Will merge to 'master'.
>
> What about contrib/blameview by Aneesh Kumar K.V <aneesh.kumar@gmail.com>
> and Jeff King <peff@peff.net>?
Yeah, I mentioned it earlier in the thread as something that I consider
clutter at this point (but somehow the thread drifted away from contrib/
and into other topics, and I forgot).
Here is a patch.
-- >8 --
Subject: [PATCH] contrib: drop blameview/ directory
Blameview was a quick-and-dirty demonstration of how blame's
incremental output could be used in an interface. These days
one can find much better (and less ugly!) demonstrations in
"git gui blame" and "tig blame".
The only advantage blameview has is that its code is perhaps
simpler to read. However, that is balanced by the fact that
it probably has bugs, as nobody uses it nor has touched the
code in 6 years. An implementor is probably better off just
reading the "incremental output" section of "man git-blame".
Signed-off-by: Jeff King <peff@peff.net>
---
contrib/blameview/README | 9 ---
contrib/blameview/blameview.perl | 155 ---------------------------------------
2 files changed, 164 deletions(-)
delete mode 100644 contrib/blameview/README
delete mode 100755 contrib/blameview/blameview.perl
diff --git a/contrib/blameview/README b/contrib/blameview/README
deleted file mode 100644
index fada5ce..0000000
--- a/contrib/blameview/README
+++ /dev/null
@@ -1,9 +0,0 @@
-This is a sample program to use 'git-blame --incremental', based
-on this message.
-
-From: Jeff King <peff@peff.net>
-Subject: Re: More precise tag following
-To: Linus Torvalds <torvalds@linux-foundation.org>
-Cc: git@vger.kernel.org
-Date: Sat, 27 Jan 2007 18:52:38 -0500
-Message-ID: <20070127235238.GA28706@coredump.intra.peff.net>
diff --git a/contrib/blameview/blameview.perl b/contrib/blameview/blameview.perl
deleted file mode 100755
index 1dec001..0000000
--- a/contrib/blameview/blameview.perl
+++ /dev/null
@@ -1,155 +0,0 @@
-#!/usr/bin/perl
-
-use Gtk2 -init;
-use Gtk2::SimpleList;
-
-my $hash;
-my $fn;
-if ( @ARGV == 1 ) {
- $hash = "HEAD";
- $fn = shift;
-} elsif ( @ARGV == 2 ) {
- $hash = shift;
- $fn = shift;
-} else {
- die "Usage blameview [<rev>] <filename>";
-}
-
-Gtk2::Rc->parse_string(<<'EOS');
-style "treeview_style"
-{
- GtkTreeView::vertical-separator = 0
-}
-class "GtkTreeView" style "treeview_style"
-EOS
-
-my $window = Gtk2::Window->new('toplevel');
-$window->signal_connect(destroy => sub { Gtk2->main_quit });
-my $vpan = Gtk2::VPaned->new();
-$window->add($vpan);
-my $scrolled_window = Gtk2::ScrolledWindow->new;
-$vpan->pack1($scrolled_window, 1, 1);
-my $fileview = Gtk2::SimpleList->new(
- 'Commit' => 'text',
- 'FileLine' => 'text',
- 'Data' => 'text'
-);
-$scrolled_window->add($fileview);
-$fileview->get_column(0)->set_spacing(0);
-$fileview->set_size_request(1024, 768);
-$fileview->set_rules_hint(1);
-$fileview->signal_connect (row_activated => sub {
- my ($sl, $path, $column) = @_;
- my $row_ref = $sl->get_row_data_from_path ($path);
- system("blameview @$row_ref[0]~1 $fn &");
- });
-
-my $commitwindow = Gtk2::ScrolledWindow->new();
-$commitwindow->set_policy ('GTK_POLICY_AUTOMATIC','GTK_POLICY_AUTOMATIC');
-$vpan->pack2($commitwindow, 1, 1);
-my $commit_text = Gtk2::TextView->new();
-my $commit_buffer = Gtk2::TextBuffer->new();
-$commit_text->set_buffer($commit_buffer);
-$commitwindow->add($commit_text);
-
-$fileview->signal_connect (cursor_changed => sub {
- my ($sl) = @_;
- my ($path, $focus_column) = $sl->get_cursor();
- my $row_ref = $sl->get_row_data_from_path ($path);
- my $c_fh;
- open($c_fh, '-|', "git cat-file commit @$row_ref[0]")
- or die "unable to find commit @$row_ref[0]";
- my @buffer = <$c_fh>;
- $commit_buffer->set_text("@buffer");
- close($c_fh);
- });
-
-my $fh;
-open($fh, '-|', "git cat-file blob $hash:$fn")
- or die "unable to open $fn: $!";
-
-while(<$fh>) {
- chomp;
- $fileview->{data}->[$.] = ['HEAD', "$fn:$.", $_];
-}
-
-my $blame;
-open($blame, '-|', qw(git blame --incremental --), $fn, $hash)
- or die "cannot start git-blame $fn";
-
-Glib::IO->add_watch(fileno($blame), 'in', \&read_blame_line);
-
-$window->show_all;
-Gtk2->main;
-exit 0;
-
-my %commitinfo = ();
-
-sub flush_blame_line {
- my ($attr) = @_;
-
- return unless defined $attr;
-
- my ($commit, $s_lno, $lno, $cnt) =
- @{$attr}{qw(COMMIT S_LNO LNO CNT)};
-
- my ($filename, $author, $author_time, $author_tz) =
- @{$commitinfo{$commit}}{qw(FILENAME AUTHOR AUTHOR-TIME AUTHOR-TZ)};
- my $info = $author . ' ' . format_time($author_time, $author_tz);
-
- for(my $i = 0; $i < $cnt; $i++) {
- @{$fileview->{data}->[$lno+$i-1]}[0,1,2] =
- (substr($commit, 0, 8), $filename . ':' . ($s_lno+$i));
- }
-}
-
-my $buf;
-my $current;
-sub read_blame_line {
-
- my $r = sysread($blame, $buf, 1024, length($buf));
- die "I/O error" unless defined $r;
-
- if ($r == 0) {
- flush_blame_line($current);
- $current = undef;
- return 0;
- }
-
- while ($buf =~ s/([^\n]*)\n//) {
- my $line = $1;
-
- if (($commit, $s_lno, $lno, $cnt) =
- ($line =~ /^([0-9a-f]{40}) (\d+) (\d+) (\d+)$/)) {
- flush_blame_line($current);
- $current = +{
- COMMIT => $1,
- S_LNO => $2,
- LNO => $3,
- CNT => $4,
- };
- next;
- }
-
- # extended attribute values
- if ($line =~ /^(author|author-mail|author-time|author-tz|committer|committer-mail|committer-time|committer-tz|summary|filename) (.*)$/) {
- my $commit = $current->{COMMIT};
- $commitinfo{$commit}{uc($1)} = $2;
- next;
- }
- }
- return 1;
-}
-
-sub format_time {
- my $time = shift;
- my $tz = shift;
-
- my $minutes = $tz < 0 ? 0-$tz : $tz;
- $minutes = ($minutes / 100)*60 + ($minutes % 100);
- $minutes = $tz < 0 ? 0-$minutes : $minutes;
- $time += $minutes * 60;
- my @t = gmtime($time);
- return sprintf('%04d-%02d-%02d %02d:%02d:%02d %s',
- $t[5] + 1900, @t[4,3,2,1,0], $tz);
-}
--
1.8.3.rc2.14.g7eee6b3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: What's cooking in git.git (Jun 2013, #04; Tue, 11)
2013-06-12 19:49 ` Jeff King
@ 2013-06-12 22:02 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2013-06-12 22:02 UTC (permalink / raw)
To: Jeff King; +Cc: Jakub Narebski, git
Jeff King <peff@peff.net> writes:
> On Wed, Jun 12, 2013 at 01:56:20PM +0000, Jakub Narebski wrote:
>
>> Junio C Hamano <gitster <at> pobox.com> writes:
>>
>> > * rr/remove-contrib-some (2013-06-02) 1 commit
>> > (merged to 'next' on 2013-06-05 at fc15705)
>> > + contrib: remove continuous/ and patches/
>> >
>> > Remove stale contrib/ material.
>> >
>> > Will merge to 'master'.
>>
>> What about contrib/blameview by Aneesh Kumar K.V <aneesh.kumar@gmail.com>
>> and Jeff King <peff@peff.net>?
>
> Yeah, I mentioned it earlier in the thread as something that I consider
> clutter at this point (but somehow the thread drifted away from contrib/
> and into other topics, and I forgot).
>
> Here is a patch.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-12 22:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-11 22:34 What's cooking in git.git (Jun 2013, #04; Tue, 11) Junio C Hamano
2013-06-11 23:24 ` Felipe Contreras
2013-06-11 23:40 ` Junio C Hamano
2013-06-12 13:56 ` Jakub Narebski
2013-06-12 19:49 ` Jeff King
2013-06-12 22:02 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.