All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Modify fsck_commit. Replace memcmp by skip_prefix
Date: Sun, 23 Mar 2014 06:08:19 +0000 (UTC)	[thread overview]
Message-ID: <loom.20140323T065455-697@post.gmane.org> (raw)
In-Reply-To: 1395501132-12894-1-git-send-email-ajha.dev@gmail.com

Hi,

Nit: In subject, patch should be like [PATCH v2] for each increasing order
of revision.

Also, after the --- (three dashes), you can write what you changed with each
patch revision. Also to link the previous patches if you can.

So the corrected mail subject header will look something like this,
 
  [PATCH v2] fsck_commit.c: Replace memcmp() by skip_prefix()

Cheers,
Tanay Abhra.

  reply	other threads:[~2014-03-23  6:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-22 15:12 [PATCH] Modify fsck_commit. Replace memcmp by skip_prefix Ashwin Jha
2014-03-23  6:08 ` Tanay Abhra [this message]
2014-03-23  8:40 ` Eric Sunshine
2014-03-23 13:10   ` Ashwin Jha
2014-03-24  1:36     ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20140323T065455-697@post.gmane.org \
    --to=tanayabh@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.