From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753789AbbDAOkO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Apr 2015 10:40:14 -0400
Received: from plane.gmane.org ([80.91.229.3]:52124 "EHLO plane.gmane.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753357AbbDAOkK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Apr 2015 10:40:10 -0400
X-Injected-Via-Gmane: http://gmane.org/
To: linux-kernel@vger.kernel.org
From: Hai Li <hali@codeaurora.org>
Subject: Re: [PATCH v3 3/3] clk: qcom: Introduce =?utf-8?b?cGFyZW50X21hcA==?= tables
Date: Wed, 1 Apr 2015 14:22:55 +0000 (UTC)
Message-ID: <loom.20150401T161124-231@post.gmane.org>
References: <1426869026-26006-1-git-send-email-georgi.djakov@linaro.org> <1426869026-26006-4-git-send-email-georgi.djakov@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: sea.gmane.org
User-Agent: Loom/3.14 (http://gmane.org/)
X-Loom-IP: 67.52.130.30 (Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.101 Safari/537.36)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Djakov,

Georgi Djakov <georgi.djakov <at> linaro.org> writes:

> 
> In the current parent mapping code, we can get duplicate or 
inconsistent
> indexes, which leads to discrepancy between the number of elements in 
the
> array and the number of parents. Until now, this was solved with some
> reordering but this is not always possible.
> 
> This patch introduces index tables that are used to define the 
relations
> between the PLL source and the hardware mux configuration value.
> To accomplish this, here we do the following:


There are other functions using f->src as index directly to find the 
parent clock, at least the followings in file clk-rcg2.c:
clk_pixel_determine_rate()
_freq_tbl_determine_rate()
clk_pixel_set_rate()
clk_edp_pixel_determine_rate()
clk_byte_determine_rate()

Shall we convert the index using qcom_find_src_index() at all these 
places?

Thanks,
Hai