All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Support specifying the network namespace upon device creation.
Date: Tue, 03 Nov 2009 02:32:56 -0800	[thread overview]
Message-ID: <m1639rew4n.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20091103.020555.156050455.davem@davemloft.net> (David Miller's message of "Tue\, 03 Nov 2009 02\:05\:55 -0800 \(PST\)")

David Miller <davem@davemloft.net> writes:

> From: ebiederm@xmission.com (Eric W. Biederman)
> Date: Tue, 03 Nov 2009 01:50:23 -0800
>
>> Eric Dumazet <eric.dumazet@gmail.com> writes:
>>>
>>> Very nice, with only one long line you could wrap differently.
>> 
>> Say again?  Was that very nice with respect to the rest of the patch?
>> Or sarcasm because I overlooked this wrap at 80 columns
>> opportunity in ipgre?
>
> It can also be argued that for functions, wrapping the args is
> worse because it makes grep output less useful.  In fact that's,
> I believe, Linus's most recent recommendation in this area :)

The arguments are already wrapped in this instance.

But since I don't have clear guidance to change the patch I
will leave it.

Eric



  parent reply	other threads:[~2009-11-03 10:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03  9:03 [PATCH] net: Support specifying the network namespace upon device creation Eric W. Biederman
2009-11-03  9:28 ` Eric Dumazet
2009-11-03  9:50   ` Eric W. Biederman
2009-11-03  9:56     ` Eric Dumazet
2009-11-03 10:06       ` Eric W. Biederman
2009-11-03 10:05     ` David Miller
2009-11-03 10:16       ` Eric Dumazet
2009-11-03 10:44         ` David Miller
2009-11-03 13:26           ` [PATCH net-next-2.6] net: cleanup include/net Eric Dumazet
2009-11-04 13:07             ` David Miller
2009-11-04 17:48               ` [PATCH net-next-2.6] net: cleanup include/linux Eric Dumazet
2009-11-04 17:51                 ` David Miller
2009-11-03 10:32       ` Eric W. Biederman [this message]
2009-11-08  8:54 ` [PATCH] net: Support specifying the network namespace upon device creation David Miller
  -- strict thread matches above, loose matches on Subject: below --
2008-10-03  0:39 [PATCH] netns: Delete virtual interfaces during namespace cleanup Eric W. Biederman
     [not found] ` <m18wt6v7eb.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-03  0:46   ` [PATCH] net: Support specifying the network namespace upon device creation Eric W. Biederman
     [not found]     ` <m1vdwatshs.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-07 12:20       ` Daniel Lezcano
     [not found]         ` <48EB541A.5070306-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-07 23:38           ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1639rew4n.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.